From fffaf735f58f1ac57781c095eb552de6d1fcdc47 Mon Sep 17 00:00:00 2001 From: xmo-odoo Date: Wed, 10 May 2017 09:39:55 +0200 Subject: [FIX] P3: list -> iterable builtins (#16811) In Python 3: * various builtins and dict methods were changed to return view/iterable objects rather than lists * and the separate Python 2 view/iterable builtins and methods were removed altogether This is problematic when using these items as list (which the happens repeatedly in Odoo), but more viciously when iterating *multiple times* over them (which also happens, which I've messed up multiple times while writing this, and which is a pain to debug even when you've just created the issue). Convert all code using these to semantics-matching cross-version helper functions to get the LCD behaviour between P2 and P3, and forbid the builtins via lint. issue #8530 --- odoo/tools/appdirs.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'odoo/tools/appdirs.py') diff --git a/odoo/tools/appdirs.py b/odoo/tools/appdirs.py index f98fa1f8ae3..8617dabfa4f 100644 --- a/odoo/tools/appdirs.py +++ b/odoo/tools/appdirs.py @@ -15,7 +15,7 @@ from __future__ import print_function # - XDG spec for Un*x: http://standards.freedesktop.org/basedir-spec/basedir-spec-latest.html __version_info__ = (1, 3, 0) -__version__ = '.'.join(map(str, __version_info__)) +__version__ = '.'.join(str(v) for v in __version_info__) import sys -- cgit v1.2.3