From d9287caf9408bb4ff85ad734cbca08e44321e205 Mon Sep 17 00:00:00 2001 From: Martin Trigaux Date: Fri, 14 Feb 2020 11:22:15 +0100 Subject: [IMP] *: convert to private methods render, render_template, load, activity_schedule_with_view, get_website_pages should all be private: It should not be possible to render an aribtrary template only with its name or id Still need to render some qweb views from js so the method render_template is kept public. This explains why the website editor still need read access on ir.ui.view as we want to allow any snippet to be rendered. --- odoo/addons/test_assetsbundle/tests/test_assetsbundle.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'odoo/addons/test_assetsbundle/tests/test_assetsbundle.py') diff --git a/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py b/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py index c38245eb19e..7399983af55 100644 --- a/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py +++ b/odoo/addons/test_assetsbundle/tests/test_assetsbundle.py @@ -471,7 +471,7 @@ class TestJavascriptAssetsBundle(FileTouchable): self.assertEqual(len(css_bundle), 1) def test_20_exteral_lib_assets(self): - html = self.env['ir.ui.view'].render_template('test_assetsbundle.template2') + html = self.env['ir.ui.view']._render_template('test_assetsbundle.template2') attachments = self.env['ir.attachment'].search([('url', '=like', '/web/content/%-%/test_assetsbundle.bundle4.%')]) self.assertEqual(len(attachments), 2) self.assertEqual(html.strip(), (""" @@ -490,7 +490,7 @@ class TestJavascriptAssetsBundle(FileTouchable): """ % {"js": attachments[0].url, "css": attachments[1].url}).encode('utf8')) def test_21_exteral_lib_assets_debug_mode(self): - html = self.env['ir.ui.view'].render_template('test_assetsbundle.template2', {"debug": "assets"}) + html = self.env['ir.ui.view']._render_template('test_assetsbundle.template2', {"debug": "assets"}) attachments = self.env['ir.attachment'].search([('url', '=like', '/web/content/%-%/test_assetsbundle.bundle4.%')]) self.assertEqual(len(attachments), 0) self.assertEqual(html.strip(), (""" -- cgit v1.2.3