From d4e0fe018d05fd0dc3e9ab77977d6e97440c73c0 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Fri, 7 Feb 2020 13:42:17 +0000
Subject: [IMP] *: use `ref=` instead of `eval="ref('` in xml field tags.

* Code cleanup
* Avoid a safe evaluation of the field value when loading those records.

closes odoo/odoo#44883

Related: odoo/enterprise#8283
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 odoo/addons/base/data/res_partner_demo.xml | 50 +++++++++++++++---------------
 1 file changed, 25 insertions(+), 25 deletions(-)

(limited to 'odoo/addons/base/data')

diff --git a/odoo/addons/base/data/res_partner_demo.xml b/odoo/addons/base/data/res_partner_demo.xml
index 6975f0db46b..ece298c2c67 100644
--- a/odoo/addons/base/data/res_partner_demo.xml
+++ b/odoo/addons/base/data/res_partner_demo.xml
@@ -141,49 +141,49 @@
 
         <record id="res_partner_address_1" model="res.partner">
             <field name="name">Willie Burke</field>
-            <field name="parent_id" eval="ref('res_partner_1')"/>
+            <field name="parent_id" ref="res_partner_1"/>
             <field name="function">Service Manager</field>
             <field name="email">willie.burke80@example.com</field>
             <field name="phone">(846)-523-2111</field>
         </record>
         <record id="res_partner_address_2" model="res.partner">
             <field name="name">Ron Gibson</field>
-            <field name="parent_id" eval="ref('res_partner_1')"/>
+            <field name="parent_id" ref="res_partner_1"/>
             <field name="function">Store Manager</field>
             <field name="email">ron.gibson76@example.com</field>
             <field name="phone">(976)-397-4091</field>
         </record>
         <record id="res_partner_address_3" model="res.partner">
             <field name="name">Douglas Fletcher</field>
-            <field name="parent_id" eval="ref('res_partner_2')"/>
+            <field name="parent_id" ref="res_partner_2"/>
             <field name="function">Functional Consultant</field>
             <field name="email">douglas.fletcher51@example.com</field>
             <field name="phone">(132)-553-7242</field>
         </record>
         <record id="res_partner_address_4" model="res.partner">
             <field name="name">Floyd Steward</field>
-            <field name="parent_id" eval="ref('res_partner_2')"/>
+            <field name="parent_id" ref="res_partner_2"/>
             <field name="function">Analyst</field>
             <field name="email">floyd.steward34@example.com</field>
             <field name="phone">(145)-138-3401</field>
         </record>
         <record id="res_partner_address_5" model="res.partner">
             <field name="name">Edwin Hansen</field>
-            <field name="parent_id" eval="ref('res_partner_3')"/>
+            <field name="parent_id" ref="res_partner_3"/>
             <field name="function">Marketing Manager</field>
             <field name="email">edwin.hansen58@example.com</field>
             <field name="phone">(943)-352-2555</field>
         </record>
         <record id="res_partner_address_7" model="res.partner">
             <field name="name">Billy Fox</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="function">Production Supervisor</field>
             <field name="email">billy.fox45@example.com</field>
             <field name="phone">(915)-498-5611</field>
         </record>
         <record id="res_partner_address_10" model="res.partner">
             <field name="name">Jesse Brown</field>
-            <field name="parent_id" eval="ref('res_partner_3')"/>
+            <field name="parent_id" ref="res_partner_3"/>
             <field name="function">Senior Consultant</field>
             <field name="email">jesse.brown74@example.com</field>
             <field name="phone">(829)-386-3277</field>
@@ -191,21 +191,21 @@
         </record>
         <record id="res_partner_address_11" model="res.partner">
             <field name="name">Soham Palmer</field>
-            <field name="parent_id" eval="ref('res_partner_3')"/>
+            <field name="parent_id" ref="res_partner_3"/>
             <field name="function">Director</field>
             <field name="email">soham.palmer15@example.com</field>
             <field name="phone">(379)-167-2040</field>
         </record>
         <record id="res_partner_address_13" model="res.partner">
             <field name="name">Kim Snyder</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="function">Senior Associate</field>
             <field name="email">kim.snyder96@example.com</field>
             <field name="phone">(215)-379-4865</field>
         </record>
         <record id="res_partner_address_14" model="res.partner">
             <field name="name">Edith Sanchez</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="function">Analyst</field>
             <field name="email">edith.sanchez68@example.com</field>
             <field name="phone">(938)-175-2048</field>
@@ -213,48 +213,48 @@
         <record id="res_partner_address_15" model="res.partner">
             <field name="name">Brandon Freeman</field>
             <field name="function">Creative Director</field>
-            <field name="parent_id" eval="ref('res_partner_12')"/>
+            <field name="parent_id" ref="res_partner_12"/>
             <field name="email">brandon.freeman55@example.com</field>
             <field name="phone">(355)-687-3262</field>
         </record>
         <record id="res_partner_address_16" model="res.partner">
             <field name="name">Nicole Ford</field>
             <field name="function">Director</field>
-            <field name="parent_id" eval="ref('res_partner_12')"/>
+            <field name="parent_id" ref="res_partner_12"/>
             <field name="email">nicole.ford75@example.com</field>
             <field name="phone">(946)-638-6034</field>
         </record>
         <record id="res_partner_address_17" model="res.partner">
             <field name="name">Toni Rhodes</field>
             <field name="function">Managing Partner</field>
-            <field name="parent_id" eval="ref('res_partner_10')"/>
+            <field name="parent_id" ref="res_partner_10"/>
             <field name="email">toni.rhodes11@example.com</field>
             <field name="phone">(198)-539-4948</field>
         </record>
         <record id="res_partner_address_18" model="res.partner">
             <field name="name">Gordon Owens</field>
             <field name="function">Senior Consultant</field>
-            <field name="parent_id" eval="ref('res_partner_10')"/>
+            <field name="parent_id" ref="res_partner_10"/>
             <field name="email">gordon.owens47@example.com</field>
             <field name="phone">(336)-723-6569</field>
         </record>
         <record id="res_partner_address_24" model="res.partner">
             <field name="name">Theodore Gardner</field>
             <field name="function">System Analyst</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="email">theodore.gardner36@example.com</field>
             <field name="phone">(186)-612-6561</field>
         </record>
         <record id="res_partner_address_25" model="res.partner">
             <field name="name">Oscar Morgan</field>
-            <field name="parent_id" eval="ref('res_partner_3')"/>
+            <field name="parent_id" ref="res_partner_3"/>
             <field name="function">Order Clerk</field>
             <field name="email">oscar.morgan11@example.com</field>
             <field name="phone">(561)-239-1744</field>
         </record>
         <record id="res_partner_address_27" model="res.partner">
             <field name="name">Tom Ruiz</field>
-            <field name="parent_id" eval="ref('res_partner_1')"/>
+            <field name="parent_id" ref="res_partner_1"/>
             <field name="function">Software Developer</field>
             <field name="email">tom.ruiz89@example.com</field>
             <field name="phone">(102)-834-1602</field>
@@ -262,48 +262,48 @@
         <record id="res_partner_address_28" model="res.partner">
             <field name="name">Colleen Diaz</field>
             <field name="function">Business Executive</field>
-            <field name="parent_id" eval="ref('res_partner_12')"/>
+            <field name="parent_id" ref="res_partner_12"/>
             <field name="email">colleen.diaz83@example.com</field>
             <field name="phone">(255)-595-8393</field>
         </record>
         <record id="res_partner_address_30" model="res.partner">
             <field name="name">Lorraine Douglas</field>
             <field name="function">Functional Consultant</field>
-            <field name="parent_id" eval="ref('res_partner_18')"/>
+            <field name="parent_id" ref="res_partner_18"/>
             <field name="email">lorraine.douglas35@example.com</field>
             <field name="phone">(443)-648-9155</field>
         </record>
         <record id="res_partner_address_31" model="res.partner">
             <field name="name">Addison Olson</field>
-            <field name="parent_id" eval="ref('res_partner_2')"/>
+            <field name="parent_id" ref="res_partner_2"/>
             <field name="function">Sales Representative</field>
             <field name="email">addison.olson28@example.com</field>
             <field name="phone">(223)-399-7637</field>
         </record>
         <record id="res_partner_address_32" model="res.partner">
             <field name="name">Sandra Neal</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="function">Sales Manager</field>
             <field name="email">sandra.neal80@example.com</field>
             <field name="phone">(430)-371-7293</field>
         </record>
         <record id="res_partner_address_33" model="res.partner">
             <field name="name">Julie Richards</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="function">Financial Manager</field>
             <field name="email">julie.richards84@example.com</field>
             <field name="phone">(225)-148-7811</field>
         </record>
         <record id="res_partner_address_34" model="res.partner">
             <field name="name">Travis Mendoza</field>
-            <field name="parent_id" eval="ref('res_partner_4')"/>
+            <field name="parent_id" ref="res_partner_4"/>
             <field name="function">Knowledge Manager</field>
             <field name="email">travis.mendoza24@example.com</field>
             <field name="phone">(840)-944-8661</field>
         </record>
         <record id="res_partner_main1" model="res.partner">
             <field name="name">Chester Reed</field>
-            <field name="parent_id" eval="ref('main_partner')"/>
+            <field name="parent_id" ref="main_partner"/>
             <field name="function">Chief Executive Officer (CEO)</field>
             <field name="email">chester.reed79@example.com</field>
             <field name="phone">(979)-904-8902</field>
@@ -311,7 +311,7 @@
         <record id="res_partner_main2" model="res.partner">
             <field name="name">Dwayne Newman</field>
             <field name="function">Chief Operations Officer (COO)</field>
-            <field name="parent_id" eval="ref('main_partner')"/>
+            <field name="parent_id" ref="main_partner"/>
             <field name="email">dwayne.newman28@example.com</field>
             <field name="phone">(614)-177-4937</field>
         </record>
-- 
cgit v1.2.3