From 5a9c65a063d71ad3cb284ce72e83a2313da65e65 Mon Sep 17 00:00:00 2001 From: Kaushalya Mandaliya Date: Wed, 23 Sep 2020 10:54:28 +0000 Subject: [FIX] doc: fix some typing mistakes in guidelines closes odoo/odoo#58322 closes odoo/odoo#58434 X-original-commit: 7ceb73d324cd90038c80a5c7d65d9f43fd4b264a Signed-off-by: Martin Trigaux (mat) --- doc/reference/guidelines.rst | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'doc/reference') diff --git a/doc/reference/guidelines.rst b/doc/reference/guidelines.rst index 91bf367fbdd..09d8fbe1fd8 100644 --- a/doc/reference/guidelines.rst +++ b/doc/reference/guidelines.rst @@ -578,7 +578,7 @@ So, you can write ``if some_collection:`` instead of ``if len(some_collection):` for element in iterable: values.setdefault(element, []).append(other_value) -- As a good developper, document your code (docstring on methods, simple +- As a good developer, document your code (docstring on methods, simple comments for tricky part of code) - In additions to these guidelines, you may also find the following link interesting: http://python.net/~goodger/projects/pycon/2007/idiomatic/handout.html @@ -604,14 +604,14 @@ on self to treat each record. for record in self: record.do_cool_stuff() -For performance issue, when developping a 'stat button' (for instance), do not +For performance issue, when developing a 'stat button' (for instance), do not perform a ``search`` or a ``search_count`` in a loop. It is recommended to use ``read_group`` method, to compute all value in only one request. .. code-block:: python def _compute_equipment_count(self): - """ Count the number of equipement per category """ + """ Count the number of equipment per category """ equipment_data = self.env['hr.equipment'].read_group([('category_id', 'in', self.ids)], ['category_id'], ['category_id']) mapped_data = dict([(m['category_id'][0], m['category_id_count']) for m in equipment_data]) for category in self: -- cgit v1.2.3