From 44a11226fe23c693c65036f8a94ba70bad154bcf Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Sat, 28 Nov 2009 11:48:10 +0100 Subject: [IMP] improve usage of the ET API, use SubElement instead of Element/append, kwarg attributes setting instead of node.set bzr revid: xmo@tinyerp.com-20091128104810-52uhz28fiw53joaz --- bin/report/render/rml2html/rml2html.py | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) (limited to 'bin/report/render/rml2html/rml2html.py') diff --git a/bin/report/render/rml2html/rml2html.py b/bin/report/render/rml2html/rml2html.py index 5e7bb5cf4e9..ea2a5583250 100644 --- a/bin/report/render/rml2html/rml2html.py +++ b/bin/report/render/rml2html/rml2html.py @@ -104,12 +104,10 @@ class _flowable(object): process(node,new_node) if new_node.get('colWidths',False): sizes = map(lambda x: utils.unit_get(x), new_node.get('colWidths').split(',')) - tr = etree.Element('tr') + tr = etree.SubElement(new_node, 'tr') for s in sizes: - td = etree.Element('td') - td.set("width", str(s)) - tr.append(td) - new_node.append(tr) + etree.SubElement(tr, 'td', width=str(s)) + return etree.tostring(new_node) def _tag_para(self, node): @@ -458,4 +456,4 @@ if __name__=="__main__": print 'Usage: trml2pdf input.rml >output.pdf' print 'Try \'trml2pdf --help\' for more information.' -# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: \ No newline at end of file +# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: -- cgit v1.2.3 From 70ab8c460759f70e738f795bb2d1954af1a8f1ec Mon Sep 17 00:00:00 2001 From: Xavier Morel Date: Sat, 28 Nov 2009 12:58:09 +0100 Subject: [IMP] removal of usages of the deprecated node.getchildren call, better usage of the attributes & tostring ET APIs, style fixes bzr revid: xmo@tinyerp.com-20091128115809-pk5zqrc3zp8h6pir --- bin/report/render/rml2html/rml2html.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'bin/report/render/rml2html/rml2html.py') diff --git a/bin/report/render/rml2html/rml2html.py b/bin/report/render/rml2html/rml2html.py index ea2a5583250..a3a14fc8aee 100644 --- a/bin/report/render/rml2html/rml2html.py +++ b/bin/report/render/rml2html/rml2html.py @@ -296,7 +296,7 @@ class _rml_template(object): posx = int(utils.unit_get(tmpl.get('x1'))) frames[(posy,posx,tmpl.get('id'))] = _rml_tmpl_frame(posx, utils.unit_get(tmpl.get('width'))) for tmpl in pt.findall('pageGraphics'): - for n in tmpl.getchildren(): + for n in tmpl: if n.tag == 'image': self.data = rc + utils._process_text(self, n.text) if n.tag in self._tags: -- cgit v1.2.3