From 2f361bec36dff09181b96d140d62c477cdf013a1 Mon Sep 17 00:00:00 2001 From: Romain Derie Date: Thu, 1 Aug 2019 16:35:35 +0000 Subject: [FIX] website(_*): better ondelete management on website_id MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Before this commit, every model having website_id would have the default `set null` as ondelete value for that field. Exception for `ir.ui.view` and `website.redirect` which are set to `cascade`. This meant that deleting a website would basically transform all its specific records into generic ones. That would lead to unwanted behavior, such as multiple `ir.attachment` with same URL, when 2 websites had been theme-customized. Deleting one of the website would result in later crashes when trying to open theme customization in the remaining website(s), since those website would find their specific scss custom attachment as well as the generic one from the deleted website. Probably more behavior might be problematic when deleting a website before this commit. To summarize the choice of this commit implementation, every model not existing outside website module are set to `cascade` (website.redirect, website.menu, product.wishlist..). The rest should be in restrict, as we don't want to delete a whole forum, blog or job, which should probably be managed case by case to decide what to do. Thus, restrict is a good choice to notify user of what should be handled. Some exception remains, ir.ui.view should be delete on cascade while sale.order should be set to null. opw-2038414 opw-2035249 closes odoo/odoo#35398 Signed-off-by: Jérémy Kersten (jke) --- addons/website_twitter/models/website_twitter_tweet.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/website_twitter') diff --git a/addons/website_twitter/models/website_twitter_tweet.py b/addons/website_twitter/models/website_twitter_tweet.py index 4e80e439296..6fa6fb1564c 100644 --- a/addons/website_twitter/models/website_twitter_tweet.py +++ b/addons/website_twitter/models/website_twitter_tweet.py @@ -8,7 +8,7 @@ class WebsiteTwitterTweet(models.Model): _name = 'website.twitter.tweet' _description = 'Website Twitter' - website_id = fields.Many2one('website', string='Website') + website_id = fields.Many2one('website', string='Website', ondelete='cascade') screen_name = fields.Char(string='Screen Name') tweet = fields.Text(string='Tweets') -- cgit v1.2.3 From ab38242cbd6f6d511aafafc9909bd1dc9303a426 Mon Sep 17 00:00:00 2001 From: Odoo Translation Bot Date: Sun, 18 Aug 2019 01:18:20 +0200 Subject: [I18N] Update translation terms from Transifex --- addons/website_twitter/i18n/bn.po | 2 +- addons/website_twitter/i18n/km.po | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) (limited to 'addons/website_twitter') diff --git a/addons/website_twitter/i18n/bn.po b/addons/website_twitter/i18n/bn.po index a65d23fc50e..4ae2cbd0726 100644 --- a/addons/website_twitter/i18n/bn.po +++ b/addons/website_twitter/i18n/bn.po @@ -365,7 +365,7 @@ msgstr "" #: model:ir.model,name:website_twitter.model_website #: model:ir.model.fields,field_description:website_twitter.field_website_twitter_tweet__website_id msgid "Website" -msgstr "" +msgstr "ওয়েবসাইট" #. module: website_twitter #: model:ir.model,name:website_twitter.model_website_twitter_tweet diff --git a/addons/website_twitter/i18n/km.po b/addons/website_twitter/i18n/km.po index 5bdd66a38cb..c4c7a672e52 100644 --- a/addons/website_twitter/i18n/km.po +++ b/addons/website_twitter/i18n/km.po @@ -260,7 +260,7 @@ msgstr "" #. module: website_twitter #: model:ir.model.fields,field_description:website_twitter.field_website_twitter_tweet__tweet msgid "Tweets" -msgstr "" +msgstr "Tweets" #. module: website_twitter #: model_terms:ir.ui.view,arch_db:website_twitter.res_config_settings_view_form @@ -270,12 +270,12 @@ msgstr "" #. module: website_twitter #: model:ir.model.fields,help:website_twitter.field_website__twitter_api_key msgid "Twitter API Key" -msgstr "" +msgstr "Twitter API Key" #. module: website_twitter #: model:ir.model.fields,help:website_twitter.field_website__twitter_api_secret msgid "Twitter API Secret" -msgstr "" +msgstr "Twitter API Secret" #. module: website_twitter #: model:ir.model.fields,field_description:website_twitter.field_website__twitter_api_key @@ -372,7 +372,7 @@ msgstr "វែបសាយ" #. module: website_twitter #: model:ir.model,name:website_twitter.model_website_twitter_tweet msgid "Website Twitter" -msgstr "" +msgstr "គេហទំព័រ Twitter " #. module: website_twitter #: model_terms:ir.ui.view,arch_db:website_twitter.res_config_settings_view_form -- cgit v1.2.3