From 216d73d727d8cb8bf1b0858c4c84e21c59b3e4b0 Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Fri, 23 Feb 2018 13:30:03 +0100 Subject: [FIX] website_slides: fix slide loading (function call with wrong this) Strangelly, this worked in 9.0 as the `this` element refers to the `window` which also contains the `$` function. This may still be wrong in some cases though, so it is fixed here (even if reported for 10.0). opw-(1)817789 --- addons/website_slides/static/src/js/slides_embed.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'addons/website_slides/static/src/js') diff --git a/addons/website_slides/static/src/js/slides_embed.js b/addons/website_slides/static/src/js/slides_embed.js index 4e7d3e71652..d3d1321e6c8 100644 --- a/addons/website_slides/static/src/js/slides_embed.js +++ b/addons/website_slides/static/src/js/slides_embed.js @@ -50,12 +50,12 @@ $(document).ready(function () { }, // page switching render_page: function (page_number) { - this.pdf_viewer.renderPage(page_number).then(this.on_rendered_page); + this.pdf_viewer.renderPage(page_number).then(this.on_rendered_page.bind(this)); }, change_page: function () { var page_asked = parseInt(this.$('#page_number').val(), 10); if(1 <= page_asked && page_asked <= this.pdf_viewer.pdf_page_total){ - this.pdf_viewer.changePage(page_asked).then(this.on_rendered_page); + this.pdf_viewer.changePage(page_asked).then(this.on_rendered_page.bind(this)); }else{ // if page number out of range, reset the page_counter to the actual page this.$('#page_number').val(this.pdf_viewer.pdf_page_current); -- cgit v1.2.3