From d4e0fe018d05fd0dc3e9ab77977d6e97440c73c0 Mon Sep 17 00:00:00 2001
From: Victor Feyens <vfe@odoo.com>
Date: Fri, 7 Feb 2020 13:42:17 +0000
Subject: [IMP] *: use `ref=` instead of `eval="ref('` in xml field tags.

* Code cleanup
* Avoid a safe evaluation of the field value when loading those records.

closes odoo/odoo#44883

Related: odoo/enterprise#8283
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
---
 addons/website_slides/data/gamification_data.xml | 54 ++++++++++++------------
 1 file changed, 27 insertions(+), 27 deletions(-)

(limited to 'addons/website_slides/data/gamification_data.xml')

diff --git a/addons/website_slides/data/gamification_data.xml b/addons/website_slides/data/gamification_data.xml
index cefecaac089..134b13020ce 100644
--- a/addons/website_slides/data/gamification_data.xml
+++ b/addons/website_slides/data/gamification_data.xml
@@ -1,5 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<odoo><data noupdate="0">
+<odoo>
 
     <!-- Get started: register to the platform -->
     <record id="badge_data_register" model="gamification.badge">
@@ -15,14 +15,14 @@
         <field name="description">Register to the platform</field>
         <field name="computation_mode">count</field>
         <field name="display_mode">boolean</field>
-        <field name="model_id" eval="ref('base.model_res_users')"/>
+        <field name="model_id" ref="base.model_res_users"/>
         <field name="condition">higher</field>
         <field name="domain">[
             ('active', '!=', False),
             ('karma', '>', 0),
         ]</field>
         <field name="batch_mode">True</field>
-        <field name="batch_distinctive_field" eval="ref('base.field_res_users__id')"/>
+        <field name="batch_distinctive_field" ref="base.field_res_users__id"/>
         <field name="batch_user_expression">user.id</field>
     </record>
     <record id="badge_data_register_challenge" model="gamification.challenge">
@@ -31,14 +31,14 @@
         <field name="period">once</field>
         <field name="visibility_mode">personal</field>
         <field name="report_message_frequency">never</field>
-        <field name="reward_id" eval="ref('badge_data_register')"/>
+        <field name="reward_id" ref="badge_data_register"/>
         <field name="reward_realtime">True</field>
         <field name="user_domain">[('karma', '>', 0)]</field>
         <field name="state">inprogress</field>
     </record>
     <record id="badge_data_register_challenge_line_0" model="gamification.challenge.line">
-        <field name="definition_id" eval="ref('badge_data_register_goal')"/>
-        <field name="challenge_id" eval="ref('badge_data_register_challenge')"/>
+        <field name="definition_id" ref="badge_data_register_goal"/>
+        <field name="challenge_id" ref="badge_data_register_challenge"/>
         <field name="target_goal">1</field>
     </record>
 
@@ -56,7 +56,7 @@
         <field name="description">Complete your profile</field>
         <field name="computation_mode">count</field>
         <field name="display_mode">boolean</field>
-        <field name="model_id" eval="ref('base.model_res_users')"/>
+        <field name="model_id" ref="base.model_res_users"/>
         <field name="condition">higher</field>
         <field name="domain">[
             ('partner_id.country_id', '!=', False),
@@ -64,7 +64,7 @@
             ('partner_id.email', '!=', False)
         ]</field>
         <field name="batch_mode">True</field>
-        <field name="batch_distinctive_field" eval="ref('base.field_res_users__id')"/>
+        <field name="batch_distinctive_field" ref="base.field_res_users__id"/>
         <field name="batch_user_expression">user.id</field>
     </record>
     <record id="badge_data_profile_challenge" model="gamification.challenge">
@@ -73,14 +73,14 @@
         <field name="period">once</field>
         <field name="visibility_mode">personal</field>
         <field name="report_message_frequency">never</field>
-        <field name="reward_id" eval="ref('badge_data_profile')"/>
+        <field name="reward_id" ref="badge_data_profile"/>
         <field name="reward_realtime">True</field>
         <field name="user_domain">[('karma', '>', 0)]</field>
         <field name="state">inprogress</field>
     </record>
     <record id="badge_data_profile_challenge_line_0" model="gamification.challenge.line">
-        <field name="definition_id" eval="ref('badge_data_profile_goal')"/>
-        <field name="challenge_id" eval="ref('badge_data_profile_challenge')"/>
+        <field name="definition_id" ref="badge_data_profile_goal"/>
+        <field name="challenge_id" ref="badge_data_profile_challenge"/>
         <field name="target_goal">1</field>
     </record>
 
@@ -98,13 +98,13 @@
         <field name="description">Complete a course</field>
         <field name="computation_mode">count</field>
         <field name="display_mode">boolean</field>
-        <field name="model_id" eval="ref('website_slides.model_slide_channel_partner')"/>
+        <field name="model_id" ref="website_slides.model_slide_channel_partner"/>
         <field name="condition">higher</field>
         <field name="domain">[
             ('completed', '=', True)
         ]</field>
         <field name="batch_mode">True</field>
-        <field name="batch_distinctive_field" eval="ref('website_slides.field_slide_channel_partner__partner_id')"/>
+        <field name="batch_distinctive_field" ref="website_slides.field_slide_channel_partner__partner_id"/>
         <field name="batch_user_expression">user.partner_id.id</field>
     </record>
     <record id="badge_data_course_challenge" model="gamification.challenge">
@@ -113,14 +113,14 @@
         <field name="period">once</field>
         <field name="visibility_mode">personal</field>
         <field name="report_message_frequency">never</field>
-        <field name="reward_id" eval="ref('badge_data_course')"/>
+        <field name="reward_id" ref="badge_data_course"/>
         <field name="reward_realtime">True</field>
         <field name="user_domain">[('karma', '>', 0)]</field>
         <field name="state">inprogress</field>
     </record>
     <record id="badge_data_course_challenge_line_0" model="gamification.challenge.line">
-        <field name="definition_id" eval="ref('badge_data_course_goal')"/>
-        <field name="challenge_id" eval="ref('badge_data_course_challenge')"/>
+        <field name="definition_id" ref="badge_data_course_goal"/>
+        <field name="challenge_id" ref="badge_data_course_challenge"/>
         <field name="target_goal">1</field>
     </record>
 
@@ -138,14 +138,14 @@
         <field name="description">Get a certification</field>
         <field name="computation_mode">count</field>
         <field name="display_mode">boolean</field>
-        <field name="model_id" eval="ref('website_slides.model_slide_slide_partner')"/>
+        <field name="model_id" ref="website_slides.model_slide_slide_partner"/>
         <field name="condition">higher</field>
         <field name="domain">[
             ('completed', '=', True),
             (0, '=', 1)
         ]</field>
         <field name="batch_mode">True</field>
-        <field name="batch_distinctive_field" eval="ref('website_slides.field_slide_slide_partner__partner_id')"/>
+        <field name="batch_distinctive_field" ref="website_slides.field_slide_slide_partner__partner_id"/>
         <field name="batch_user_expression">user.partner_id.id</field>
     </record>
     <record id="badge_data_certification_challenge" model="gamification.challenge">
@@ -154,14 +154,14 @@
         <field name="period">once</field>
         <field name="visibility_mode">personal</field>
         <field name="report_message_frequency">never</field>
-        <field name="reward_id" eval="ref('badge_data_certification')"/>
+        <field name="reward_id" ref="badge_data_certification"/>
         <field name="reward_realtime">True</field>
         <field name="user_domain">[('karma', '>', 0)]</field>
         <field name="state">inprogress</field>
     </record>
     <record id="badge_data_certification_challenge_line_0" model="gamification.challenge.line">
-        <field name="definition_id" eval="ref('badge_data_certification_goal')"/>
-        <field name="challenge_id" eval="ref('badge_data_certification_challenge')"/>
+        <field name="definition_id" ref="badge_data_certification_goal"/>
+        <field name="challenge_id" ref="badge_data_certification_challenge"/>
         <field name="target_goal">1</field>
     </record>
 
@@ -179,13 +179,13 @@
         <field name="description">Reach 2000 XP</field>
         <field name="computation_mode">count</field>
         <field name="display_mode">boolean</field>
-        <field name="model_id" eval="ref('base.model_res_users')"/>
+        <field name="model_id" ref="base.model_res_users"/>
         <field name="condition">higher</field>
         <field name="domain">[
             ('karma', '>=', 2000)
         ]</field>
         <field name="batch_mode">True</field>
-        <field name="batch_distinctive_field" eval="ref('base.field_res_users__id')"/>
+        <field name="batch_distinctive_field" ref="base.field_res_users__id"/>
         <field name="batch_user_expression">user.id</field>
     </record>
     <record id="badge_data_karma_challenge" model="gamification.challenge">
@@ -194,14 +194,14 @@
         <field name="period">once</field>
         <field name="visibility_mode">personal</field>
         <field name="report_message_frequency">never</field>
-        <field name="reward_id" eval="ref('badge_data_karma')"/>
+        <field name="reward_id" ref="badge_data_karma"/>
         <field name="reward_realtime">True</field>
         <field name="user_domain">[('karma', '>', 0)]</field>
         <field name="state">inprogress</field>
     </record>
     <record id="badge_data_karma_challenge_line_0" model="gamification.challenge.line">
-        <field name="definition_id" eval="ref('badge_data_karma_goal')"/>
-        <field name="challenge_id" eval="ref('badge_data_karma_challenge')"/>
+        <field name="definition_id" ref="badge_data_karma_goal"/>
+        <field name="challenge_id" ref="badge_data_karma_challenge"/>
         <field name="target_goal">1</field>
     </record>
-</data></odoo>
+</odoo>
-- 
cgit v1.2.3