From 4bd8e3e2ed48eb05b9e155826fd47753a85b5731 Mon Sep 17 00:00:00 2001 From: rde Date: Fri, 29 Sep 2017 13:48:33 +0200 Subject: [IMP] website: Script injected in DOM: window.onerror empty params Before this commit, error thrown by scripts injected in DOM won't return a clean error on window.onerror. It would open the crash_manager's show_error's dialog that wouldn't display any informations except "Script Error." and "Traceback:". This is because of browser's security reason: it will just give you a 'Script error.' as message and nothing else for security issue. Now, this kind of error will show a clearer message informing that it is probably originating from a Javascript file served from a different origin. There is now also the possibility for developers to handle/override the behavior when this kind of error is catch to prevent the dialog to open for example. Might be of use: https://blog.sentry.io/2016/05/17/what-is-script-error.html https://stackoverflow.com/a/7778424 https://danlimerick.wordpress.com/2014/01/18/how-to-catch-javascript-errors-with-window-onerror-even-on-chrome-and-firefox/ (Search for Script Error) --- addons/website/static/src/xml/website.backend.xml | 1 + 1 file changed, 1 insertion(+) (limited to 'addons/website/static/src/xml/website.backend.xml') diff --git a/addons/website/static/src/xml/website.backend.xml b/addons/website/static/src/xml/website.backend.xml index c96396ea9a9..e0d467489e6 100644 --- a/addons/website/static/src/xml/website.backend.xml +++ b/addons/website/static/src/xml/website.backend.xml @@ -89,6 +89,7 @@
You need to log in to your Google Account before: You do not seem to have access to this Analytics Account. + Google Analytics initialization failed. Maybe this domain is not whitelisted in your Google Analytics project for this client ID.
-- cgit v1.2.3