From d9287caf9408bb4ff85ad734cbca08e44321e205 Mon Sep 17 00:00:00 2001 From: Martin Trigaux Date: Fri, 14 Feb 2020 11:22:15 +0100 Subject: [IMP] *: convert to private methods render, render_template, load, activity_schedule_with_view, get_website_pages should all be private: It should not be possible to render an aribtrary template only with its name or id Still need to render some qweb views from js so the method render_template is kept public. This explains why the website editor still need read access on ir.ui.view as we want to allow any snippet to be rendered. --- addons/web_editor/controllers/main.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/web_editor/controllers/main.py') diff --git a/addons/web_editor/controllers/main.py b/addons/web_editor/controllers/main.py index 488c203d35f..cd8ade0f108 100644 --- a/addons/web_editor/controllers/main.py +++ b/addons/web_editor/controllers/main.py @@ -476,4 +476,4 @@ class Web_Editor(http.Controller): if request.env.user._is_public() \ and xmlid in request.env['web_editor.assets']._get_public_asset_xmlids(): View = View.sudo() - return View.render_template(xmlid, {k: values[k] for k in values if k in trusted_value_keys}) + return View._render_template(xmlid, {k: values[k] for k in values if k in trusted_value_keys}) -- cgit v1.2.3