From 8782de993d922b321d3be479dbb84e9d20a0c87a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Fri, 2 Apr 2021 15:50:20 +0000 Subject: [FIX] web: ignore recursiveCallMounted on not yet rendered children MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This should hopefully fix the race condition that is described in the related task. The issue is that our mounted callbacks are legitimately relying on the component to be actually rendered. task-2481713 closes odoo/odoo#68711 Signed-off-by: Géry Debongnie (ged) --- addons/web/static/src/js/owl_compatibility.js | 11 +++++++++++ 1 file changed, 11 insertions(+) (limited to 'addons/web') diff --git a/addons/web/static/src/js/owl_compatibility.js b/addons/web/static/src/js/owl_compatibility.js index b20ad7890f0..aabb0f9861c 100644 --- a/addons/web/static/src/js/owl_compatibility.js +++ b/addons/web/static/src/js/owl_compatibility.js @@ -375,6 +375,17 @@ odoo.define('web.OwlCompatibility', function () { */ on_attach_callback() { function recursiveCallMounted(component) { + if ( + component.__owl__.status !== 2 /* RENDERED */ && + component.__owl__.status !== 3 /* MOUNTED */ && + component.__owl__.status !== 4 /* UNMOUNTED */ + ) { + // Avoid calling mounted on a component that is not even + // rendered. Doing otherwise will lead to a crash if a + // specific mounted callback is legitimately relying on the + // component being mounted. + return; + } for (const key in component.__owl__.children) { recursiveCallMounted(component.__owl__.children[key]); } -- cgit v1.2.3