From 32b8cec5361174c92c45a4975d4e02f1fb448aa2 Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Fri, 17 Nov 2017 13:14:02 +0100 Subject: [REF] web,*: ActionManager/ViewManager refactoring This rev. is the first part (out of 3) of the refactoring of the ActionManager and ViewManager layer of the webclient. The main changes are: - there is no ViewManager anymore, its work is now handled by the ActionManager itself, but isolated in a specific file ; this eases a lot of things, as the breadcrumbs handling for example. - the ActionManager code is converted to the new coding principles and guidelines ; mainly, children widgets communicate with it by triggering events up, and not by function calls anymore. - the ActionManager layer is now testable, and a lot of tests have already been written. - the code in other addons has been adapted consequently. What's coming next: - introduce the 'AbstractAction' Widget, and make client actions and view controllers inherit from it ; this widget will implement a common API that could be used uniformly by the ActionManager (e.g. restore(), canBeLeft(), renderButtons(), getTitle()...). - move the ControlPanel handling from the ActionManager to the AbstractAction. --- addons/web/static/tests/widgets/data_export_tests.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'addons/web/static/tests/widgets/data_export_tests.js') diff --git a/addons/web/static/tests/widgets/data_export_tests.js b/addons/web/static/tests/widgets/data_export_tests.js index d251e3dea15..192944ce3b5 100644 --- a/addons/web/static/tests/widgets/data_export_tests.js +++ b/addons/web/static/tests/widgets/data_export_tests.js @@ -53,7 +53,7 @@ QUnit.module('widgets', { data: this.data, arch: '', viewOptions: { - sidebar: true, + hasSidebar: true, }, mockRPC: function (route) { if (route === '/web/export/formats') { @@ -144,7 +144,7 @@ QUnit.module('widgets', { data: this.data, arch: '', viewOptions: { - sidebar: true, + hasSidebar: true, }, mockRPC: function (route) { if (route === '/web/export/formats') { -- cgit v1.2.3