From c63c618312481cfbc3d31cb733d22d54fcc0e7c9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alexandre=20K=C3=BChn?= Date: Tue, 4 Sep 2018 09:54:59 +0200 Subject: [REF] web: improved fix from 'Edit View: X' (017e7132) Revision on https://github.com/odoo/odoo/commit/017e71322b6b7f0c232f0d66ba659a5972fc3534 Commit above correctly fixes an issue with 'Edit View: X' menu item in the debug manager, in which the name of the view was missing. To do so, it lets the controller be aware of the name of the view, so that it can be used in the template of the debug menu. However, we think there is a much better solution to fixing this issue: since the debug manager has knowledge of the view action, we can extend this object with the name of the view. This is exactly what this commit does: extend the action view object so that it knows the name of the view. That way, the template is much more readable, as `view.displayName` is more meaningful than `controller.viewName`. Task-ID 1878254 --- addons/web/static/tests/tools/debug_manager_tests.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/web/static/tests/tools/debug_manager_tests.js') diff --git a/addons/web/static/tests/tools/debug_manager_tests.js b/addons/web/static/tests/tools/debug_manager_tests.js index e861afc6546..424ebe1517f 100644 --- a/addons/web/static/tests/tools/debug_manager_tests.js +++ b/addons/web/static/tests/tools/debug_manager_tests.js @@ -48,6 +48,7 @@ QUnit.module('DebugManager', {}, function () { // Simulate update debug manager from web client var action = { views: [{ + displayName: "List", fieldsView: { view_id: 1, }, @@ -55,7 +56,6 @@ QUnit.module('DebugManager', {}, function () { }], }; var view = { - viewName: "List", viewType: "list", }; debugManager.update('action', action, view); -- cgit v1.2.3