From d1f1cc9c275de726de3cd2491c8d8b4866bbeb0e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Tue, 10 Jul 2018 13:52:18 +0200 Subject: [FIX] web: prevent tab shortcut from crashing when no input field Currently, using the shortcut "tab" inside a list will crash if the list has no input field (ex. if it has only a textarea field). This commit prevents the bug. Also moved the test for the orderedResIDs crash in the correct module. PR #25209 --- addons/web/static/src/js/views/list/list_editable_renderer.js | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) (limited to 'addons/web/static/src') diff --git a/addons/web/static/src/js/views/list/list_editable_renderer.js b/addons/web/static/src/js/views/list/list_editable_renderer.js index bf54ad19f22..382df0b9444 100644 --- a/addons/web/static/src/js/views/list/list_editable_renderer.js +++ b/addons/web/static/src/js/views/list/list_editable_renderer.js @@ -768,10 +768,13 @@ ListRenderer.include({ var record = this.state.data[this.currentRow]; var recordWidgets = this.allFieldWidgets[record.id]; var firstWidget = _.find(recordWidgets, function (widget) { - var isFirst = widget.$el.is(':visible') && - (widget.$el.has('input').length > 0 || - widget.tagName== 'input') && - !widget.$el.hasClass('o_readonly_modifier'); + var isFirst = + widget.$el.is(':visible') && + ( + widget.$('input').length > 0 || widget.tagName === 'input' || + widget.$('textarea').length > 0 || widget.tagName === 'textarea' + ) && + !widget.$el.hasClass('o_readonly_modifier'); return isFirst; }); return firstWidget; -- cgit v1.2.3