From c72e5a8bc5c3e7fab01f9d669c0670f40c2a95ca Mon Sep 17 00:00:00 2001 From: Romeo Fragomeli Date: Mon, 14 Jan 2019 10:22:50 +0000 Subject: Revert "[FIX] web: empty kanban view on mobile" Original commit breaking kanban view: 4cd379cf6ecffa00e0085a9833228128b484d48a Commit reverted: 287136b85e55b4abca03122c7b1c59099abd0854 Two fixes were added independently to fix this bug but only one is needed. odoo/enterprise@c8fe86fa225d3a5967e629f8fd35e1c92aa1fa61 best fix 287136b85e55b4abca03122c7b1c59099abd0854 other fix (now reverted) Reverting this commit fix the following bugs: - Swipe on kanban : Not able to swipe on empty column. it only works on cards - Popup activity on kanban card is unusable - On kanban separation, "Undefined" cards are before the kanban separation closes odoo/odoo#30177 --- addons/web/static/src/js/views/kanban/kanban_renderer_mobile.js | 3 +-- addons/web/static/src/scss/kanban_view_mobile.scss | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-) (limited to 'addons/web/static/src') diff --git a/addons/web/static/src/js/views/kanban/kanban_renderer_mobile.js b/addons/web/static/src/js/views/kanban/kanban_renderer_mobile.js index b7f2dd62b28..8619448e793 100644 --- a/addons/web/static/src/js/views/kanban/kanban_renderer_mobile.js +++ b/addons/web/static/src/js/views/kanban/kanban_renderer_mobile.js @@ -143,7 +143,7 @@ KanbanRenderer.include({ onSuccess: function () { // update the columns and tabs positions (optionally with an animation) var updateFunc = animate ? 'animate' : 'css'; - self.$('.o_kanban_mobile_tab, .o_kanban_group').removeClass('o_current'); + self.$('.o_kanban_mobile_tab').removeClass('o_current'); _.each(self.widgets, function (column, index) { var columnID = column.id || column.db_id; var $column = self.$('.o_kanban_group[data-id="' + columnID + '"]'); @@ -157,7 +157,6 @@ KanbanRenderer.include({ } else if (index === moveToIndex) { $column[updateFunc]({left: '0%'}); $tab[updateFunc]({left: '50%'}); - $column.addClass('o_current'); $tab.addClass('o_current'); } else if (index < moveToIndex) { $column.css({left: '-100%'}); diff --git a/addons/web/static/src/scss/kanban_view_mobile.scss b/addons/web/static/src/scss/kanban_view_mobile.scss index 1c5a9eab531..b74ae8aaea5 100644 --- a/addons/web/static/src/scss/kanban_view_mobile.scss +++ b/addons/web/static/src/scss/kanban_view_mobile.scss @@ -36,9 +36,6 @@ margin-left: 0; // override the margin-left: -1px of the desktop mode border: none; - &.o_current { - position: initial; - } .o_kanban_header { display: none; } -- cgit v1.2.3