From 45e94ec756e0da4766110bd3ce94ede4203e4486 Mon Sep 17 00:00:00 2001
From: xmo-odoo <xmo@odoo.com>
Date: Thu, 8 Jun 2017 14:16:43 +0200
Subject: [FIX] web: CrashManager can crash if trying to show an empty message
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

If `d.message` is an empty string, `!!d.message` is false and the
crashmanager will try to display `d.error.data.message`… which does
not exist as it's a warning with an empty message not an upstream error.

That causes the crashmanager itself to crash, and even the warning
name/title to be lost.
---
 addons/web/static/src/xml/base.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'addons/web/static/src/xml/base.xml')

diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml
index c846e969827..161509b364f 100644
--- a/addons/web/static/src/xml/base.xml
+++ b/addons/web/static/src/xml/base.xml
@@ -22,7 +22,7 @@
 <t t-name="CrashManager.warning">
     <div class="o_dialog_warning">
         <t t-js="d">
-            var message = d.message ? d.message : d.error.data.message;
+            var message = (d.message !== undefined) ? d.message : d.error.data.message;
             d.html_error = context.engine.tools.html_escape(message).replace(/\n/g, '<br/>');
         </t>
         <t t-raw="html_error"/>
-- 
cgit v1.2.3