From 922a04dbd2acbd547c0279b046099647c5f9eb3f Mon Sep 17 00:00:00 2001 From: Harshad Modi Date: Wed, 7 Jun 2017 13:45:04 +0530 Subject: [FIX] project: fix traceback while setting cover image from project task kanban view (PR #17165) --- addons/web/static/src/xml/base.xml | 5 ----- 1 file changed, 5 deletions(-) (limited to 'addons/web/static/src/xml/base.xml') diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml index ccbf030ff1b..c4a3cc3939f 100644 --- a/addons/web/static/src/xml/base.xml +++ b/addons/web/static/src/xml/base.xml @@ -835,11 +835,6 @@ t-att-width="widget.node.attrs.img_width || widget.node.attrs.width" t-att-height="widget.node.attrs.img_height || widget.node.attrs.height"/> - -
- -
-
-- cgit v1.2.3 From 45e94ec756e0da4766110bd3ce94ede4203e4486 Mon Sep 17 00:00:00 2001 From: xmo-odoo Date: Thu, 8 Jun 2017 14:16:43 +0200 Subject: [FIX] web: CrashManager can crash if trying to show an empty message MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If `d.message` is an empty string, `!!d.message` is false and the crashmanager will try to display `d.error.data.message`… which does not exist as it's a warning with an empty message not an upstream error. That causes the crashmanager itself to crash, and even the warning name/title to be lost. --- addons/web/static/src/xml/base.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/web/static/src/xml/base.xml') diff --git a/addons/web/static/src/xml/base.xml b/addons/web/static/src/xml/base.xml index c846e969827..161509b364f 100644 --- a/addons/web/static/src/xml/base.xml +++ b/addons/web/static/src/xml/base.xml @@ -22,7 +22,7 @@
- var message = d.message ? d.message : d.error.data.message; + var message = (d.message !== undefined) ? d.message : d.error.data.message; d.html_error = context.engine.tools.html_escape(message).replace(/\n/g, '
');
-- cgit v1.2.3