From 4974f8edb76e27471bb00c1659c878d0b7a04daf Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Wed, 29 Nov 2017 17:58:24 +0100 Subject: [FIX] web: make submodals backdrop appear on top of parent modals Commit https://github.com/odoo/odoo/commit/7dcb8fea642858e0bb1d68cea9707cb3c8d4328d (and https://github.com/odoo/odoo/commit/e64cf3d606bd94f7e0d82ec907ce7d1d66222287) were supposed to make submodals backdrop appear on top of parent modals. The feature was however broken by another commit before it was released: https://github.com/odoo/odoo/commit/f997c128c7295b5e76d7f77d79c4a82898debbcf --- addons/web/static/src/less/bootstrap_overridden.less | 13 +++++++++++++ 1 file changed, 13 insertions(+) (limited to 'addons/web/static/src/less/bootstrap_overridden.less') diff --git a/addons/web/static/src/less/bootstrap_overridden.less b/addons/web/static/src/less/bootstrap_overridden.less index 0582ec8c384..ada94dbf4ca 100644 --- a/addons/web/static/src/less/bootstrap_overridden.less +++ b/addons/web/static/src/less/bootstrap_overridden.less @@ -72,6 +72,19 @@ @modal-inner-padding: @odoo-horizontal-padding; @modal-title-padding: @odoo-horizontal-padding; +// Change the z-index of the modal-backdrop elements to be equal to the +// modal elements' ones. Bootstrap does not support multi-modals, and without +// this rule all the modal-backdrops are below all the opened modals. +// Indeed, bootstrap forces them to a lower z-index as the modal-backdrop +// element (unique in their supported cases) might be put after the modal +// element (if the modal is already in the DOM, hidden, then opened). This +// cannot happen in odoo though as modals are not hidden but removed from +// the DOM and are always put at the end of the body when opened. +// +// Note that the variable @zindex-modal-background may be renamed/removed in +// newer versions of bootstrap. +@zindex-modal-background: @zindex-modal; + //== Navs @nav-link-padding: 10px 15px; @nav-pills-border-radius: 0; -- cgit v1.2.3 From dc5755698cc41e0c5f51ab5dccee1356a0f23a3f Mon Sep 17 00:00:00 2001 From: qsm-odoo Date: Tue, 5 Dec 2017 17:20:26 +0100 Subject: [FIX] web: restore saas modals This commit basically reverts 4974f8edb76e27471bb00c1659c878d0b7a04daf The fix was unstable (as restoring a feature that was not there before release, even if originally merged before). This was in particular breaking saas modals as lots of them are still opened using 8.0 system... and opening them this way might make them appear below their own backdrop in the new system the mentioned commit restored. We will think about that feature again for a future version. --- addons/web/static/src/less/bootstrap_overridden.less | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) (limited to 'addons/web/static/src/less/bootstrap_overridden.less') diff --git a/addons/web/static/src/less/bootstrap_overridden.less b/addons/web/static/src/less/bootstrap_overridden.less index ada94dbf4ca..ca6383e0116 100644 --- a/addons/web/static/src/less/bootstrap_overridden.less +++ b/addons/web/static/src/less/bootstrap_overridden.less @@ -83,7 +83,10 @@ // // Note that the variable @zindex-modal-background may be renamed/removed in // newer versions of bootstrap. -@zindex-modal-background: @zindex-modal; +// +// TODO the following code was disabled because it is saas-incompatible +// +// @zindex-modal-background: @zindex-modal; //== Navs @nav-link-padding: 10px 15px; -- cgit v1.2.3