From d658fe67db994ba365f42f0caa2a3f13e8e3fb18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A9ry=20Debongnie?= Date: Sun, 23 Apr 2017 09:01:09 +0200 Subject: [FIX] web: debugmanager view metadata should not crash In general, I think that we can safely consider that crashes are not the intended behaviour. In this case, viewing metadata crashed because we tried to format a date which was not parsed (so, a string), instead of a moment object. We simply just parse the date before, and it works as intended. --- addons/web/static/src/js/widgets/debug_manager.js | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'addons/web/static/src/js/widgets/debug_manager.js') diff --git a/addons/web/static/src/js/widgets/debug_manager.js b/addons/web/static/src/js/widgets/debug_manager.js index 3796fcbda7f..cdb3236aa64 100644 --- a/addons/web/static/src/js/widgets/debug_manager.js +++ b/addons/web/static/src/js/widgets/debug_manager.js @@ -327,15 +327,21 @@ DebugManager.include({ var ds = this._view_manager.dataset; if (!this._active_view.controller.getSelectedIds().length) { console.warn(_t("No metadata available")); - return + return; } ds.call('get_metadata', [this._active_view.controller.getSelectedIds()]).done(function(result) { + var metadata = result[0]; + metadata.creator = field_utils.format.many2one(metadata.create_uid); + metadata.lastModifiedBy = field_utils.format.many2one(metadata.write_uid); + var createDate = field_utils.parse.datetime(metadata.create_date); + metadata.create_date = field_utils.format.datetime(createDate); + var modificationDate = field_utils.parse.datetime(metadata.write_date); + metadata.write_date = field_utils.format.datetime(modificationDate); new Dialog(this, { title: _.str.sprintf(_t("Metadata (%s)"), ds.model), size: 'medium', $content: QWeb.render('WebClient.DebugViewLog', { - perm : result[0], - format : field_utils.format + perm : metadata, }) }).open(); }); -- cgit v1.2.3