From 03fe95d6af9d96f961c47d9acfaec498966b8cfa Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Mon, 22 Oct 2018 11:03:17 +0000 Subject: [REF] web: small refactoring pass on some web components (mainly views and ActionManager) - add missing docstrings - fix typos - correctly order functions and imports - put functions in correct sections - stop using 'event' as argument of handlers - don't call handlers directly - remove trailing spaces/tabs - move module created in stable version to its own file - follow js guidelines in general closes odoo/odoo#28024 --- addons/web/static/src/js/views/graph/graph_controller.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'addons/web/static/src/js/views/graph/graph_controller.js') diff --git a/addons/web/static/src/js/views/graph/graph_controller.js b/addons/web/static/src/js/views/graph/graph_controller.js index 48f15de8902..09992695506 100644 --- a/addons/web/static/src/js/views/graph/graph_controller.js +++ b/addons/web/static/src/js/views/graph/graph_controller.js @@ -175,17 +175,17 @@ var GraphController = AbstractController.extend(GroupByMenuInterfaceMixin,{ * Do what need to be done when a button from the control panel is clicked. * * @private - * @param {MouseEvent} event + * @param {MouseEvent} ev */ - _onButtonClick: function (event) { - var $target = $(event.target); + _onButtonClick: function (ev) { + var $target = $(ev.target); var parent; var field; if ($target.hasClass('o_graph_button')) { this._setMode($target.data('mode')); } else if ($target.parents('.o_graph_measures_list').length) { - event.preventDefault(); - event.stopPropagation(); + ev.preventDefault(); + ev.stopPropagation(); field = $target.data('field'); this._setMeasure(field); } -- cgit v1.2.3