From f85a54257d7bac46d3df7daba60a4242381a3107 Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Wed, 25 Apr 2018 09:22:36 +0200 Subject: [FIX] web: BasicRenderer: button's name attr in DOM Rev. 374af56 changed the way 'button' nodes are rendered in basic views (form, list, kanban). As a consequence, their 'name' attribute wasn't transmitted to the produced html elements anymore. However, this attribute is very convenient to debug views, and to write selectors in tests. For instance, it broke the test added by rev. 8d17a2a once forwardported in master. This commit reverts 1ce5bea. --- addons/web/static/src/js/views/basic/basic_renderer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/web/static/src/js/views/basic/basic_renderer.js') diff --git a/addons/web/static/src/js/views/basic/basic_renderer.js b/addons/web/static/src/js/views/basic/basic_renderer.js index c05d467052e..16507184915 100644 --- a/addons/web/static/src/js/views/basic/basic_renderer.js +++ b/addons/web/static/src/js/views/basic/basic_renderer.js @@ -529,7 +529,7 @@ var BasicRenderer = AbstractRenderer.extend({ */ _renderButtonFromNode: function (node, options) { var btnOptions = { - attrs: _.omit(node.attrs, 'icon', 'string', 'type', 'name', 'attrs', 'modifiers', 'options'), + attrs: _.omit(node.attrs, 'icon', 'string', 'type', 'attrs', 'modifiers', 'options'), icon: node.attrs.icon, }; if (options && options.extraClass) { -- cgit v1.2.3