From 36b4d78a2678806b25aaa5650b64496f9da9d205 Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Fri, 29 Sep 2017 08:50:28 +0200 Subject: [FIX] web,mail: reset focus after onchange on x2many Rev. 2728fe1 introduced an attempt of restoring the focus on the currently focused field in an x2many list after an onchange returned, and the list has been updated. However, it was often wrong (e.g. leaving a field by pressing tab/shift+tab, clicking on another field...) and reset the focus on an unexpected field. In addition to fixing this issue, this rev. also unifies the helper functions to get and set the cursor positions in an input or textarea, as they were duplicated between mail and web. --- addons/web/static/src/js/views/basic/basic_renderer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/web/static/src/js/views/basic/basic_renderer.js') diff --git a/addons/web/static/src/js/views/basic/basic_renderer.js b/addons/web/static/src/js/views/basic/basic_renderer.js index 24922622a42..93dd1f4fb73 100644 --- a/addons/web/static/src/js/views/basic/basic_renderer.js +++ b/addons/web/static/src/js/views/basic/basic_renderer.js @@ -127,7 +127,7 @@ var BasicRenderer = AbstractRenderer.extend({ this.editRecord(id); if (typeof offset === "number") { var field = _.findWhere(this.allFieldWidgets[id], {name: fieldName}); - dom.setCursor(field.getFocusableElement(), offset); + dom.setSelectionRange(field.getFocusableElement().get(0), {start: offset, end: offset}); } }, -- cgit v1.2.3