From 870aa81ad9ef26b88bff8190a71e8c805fe33beb Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Fri, 11 Aug 2017 08:46:11 +0200 Subject: [FIX] web: BasicModel: default_get: handle false value for o2m The value for one2many fields returned by default_get may be a list of commands, or directly a list of ids. These cases were correctly handled. However, it seems that the value can also be false, and when this happened, it crashed. For instance, go to Sales > Leads (must be activated in the Settings) > in the list view, check several leads > in 'Action', click on 'Convert to Opportunities' > crash. --- addons/web/static/src/js/views/basic/basic_model.js | 1 + 1 file changed, 1 insertion(+) (limited to 'addons/web/static/src/js/views/basic/basic_model.js') diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js index 67688c83fdc..8bb46ea68aa 100644 --- a/addons/web/static/src/js/views/basic/basic_model.js +++ b/addons/web/static/src/js/views/basic/basic_model.js @@ -2895,6 +2895,7 @@ var BasicModel = AbstractModel.extend({ x2manyList._changes = []; var many2ones = {}; var r; + result[name] = result[name] || []; // handle false value var isCommandList = result[name].length && _.isArray(result[name][0]); if (!isCommandList) { result[name] = [[6, false, result[name]]]; -- cgit v1.2.3