From 4872c8da31bc10738c0f195c8665b59ec61f0e42 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?G=C3=A9ry=20Debongnie?= Date: Wed, 5 Apr 2017 12:15:49 +0200 Subject: [FIX] web: don't save readonly fields Readonly fields can be modified with onchanges, but they should not be saved. --- addons/web/static/src/js/views/basic/basic_model.js | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'addons/web/static/src/js/views/basic/basic_model.js') diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js index ced26fb7cb2..304f7e475f7 100644 --- a/addons/web/static/src/js/views/basic/basic_model.js +++ b/addons/web/static/src/js/views/basic/basic_model.js @@ -612,6 +612,15 @@ var BasicModel = AbstractModel.extend({ // make sure we don't write an undefined id delete changes.id; + // remove readonly fields from the list of changes + if (method === 'write') { + for (var fieldName in changes) { + if (record.fields[fieldName].readonly) { + delete changes[fieldName]; + } + } + } + // in the case of a write, only perform the RPC if there are changes to save if (method === 'create' || Object.keys(changes).length) { var args = method === 'write' ? [[record.data.id], changes] : [changes]; -- cgit v1.2.3