From 05a33052747da7767fb6c3db160126d37520381a Mon Sep 17 00:00:00 2001 From: Adrien Dieudonne Date: Mon, 17 Apr 2017 23:06:21 +0200 Subject: [FIX] web: BasicModel: active_id should always be defined Before this fix, active_id wasn't defined on non existing record. For example: when you tried to add a new contact on a new partner. Now, active_id is false if there is no id on the current record. So, you can use this value to evaluate the context --- addons/web/static/src/js/views/basic/basic_model.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) (limited to 'addons/web/static/src/js/views/basic/basic_model.js') diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js index 233ad1933bb..cd1dedb2f6c 100644 --- a/addons/web/static/src/js/views/basic/basic_model.js +++ b/addons/web/static/src/js/views/basic/basic_model.js @@ -1898,10 +1898,8 @@ var BasicModel = AbstractModel.extend({ _getEvalContext: function (element) { var evalContext = this.get(element.id, {raw: true, noUnsetNumeric: true}).data; evalContext.active_model = element.model; - if (evalContext.id) { - evalContext.active_id = evalContext.id; - evalContext.active_ids = [evalContext.id]; - } + evalContext.active_id = evalContext.id || false; + evalContext.active_ids = evalContext.id ? [evalContext.id] : []; if (element.parentID) { var parent = this.get(element.parentID, {raw: true}); if (parent.type === 'list' && this.localData[element.parentID].parentID) { -- cgit v1.2.3