From 0eaee456591b31e35b56f365cdfbf1e618b17a6c Mon Sep 17 00:00:00 2001 From: Aaron Bohy Date: Thu, 24 Jan 2019 08:08:30 +0000 Subject: [IMP] web: force activeActions to be boolean The docstring says they are boolean, but they actually aren't (e.g. edit="0" in the arch would lead to activeActions.edit=0). This could cause issue if that value is used to toggle a class with jQuery, as in this case the flag argument *must* be a boolean. --- addons/web/static/src/js/fields/relational_fields.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'addons/web/static/src/js/fields/relational_fields.js') diff --git a/addons/web/static/src/js/fields/relational_fields.js b/addons/web/static/src/js/fields/relational_fields.js index 24a1eced358..d30d263fa12 100644 --- a/addons/web/static/src/js/fields/relational_fields.js +++ b/addons/web/static/src/js/fields/relational_fields.js @@ -817,10 +817,10 @@ var FieldX2Many = AbstractField.extend({ var arch = this.view && this.view.arch; if (arch) { this.activeActions.create = arch.attrs.create ? - JSON.parse(arch.attrs.create) : + !!JSON.parse(arch.attrs.create) : true; this.activeActions.delete = arch.attrs.delete ? - JSON.parse(arch.attrs.delete) : + !!JSON.parse(arch.attrs.delete) : true; this.editable = arch.attrs.editable; } -- cgit v1.2.3