From 5dda9a709eb93af7de5b184cb823b0ebeaad2db1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20Gonz=C3=A1lez?= Date: Sat, 21 Mar 2020 23:43:29 +0000 Subject: [FIX] web,mail: Harmful or incomplete aria-label attributes Some elements contain superfluous `aria-label` attributes, which overrides any default useful information. For instance, some dropdown menus contain the `aria-label` "Dropdown menu" (e.g. the company switcher), which doesn't add any useful information, as dropdown menus are already labelled correctly using `aria-expanded`. This change applies on the following buttons: - Schedule an activity - View attachments - View followers - Switch company - Open user options from systray - The widget `state_selection` closes odoo/odoo#48317 X-original-commit: e3c7f66e89d7be39dfa4cc3d6b038c6f4a114aa5 Signed-off-by: Nicolas Lempereur (nle) --- addons/web/static/src/js/fields/basic_fields.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/web/static/src/js/fields/basic_fields.js') diff --git a/addons/web/static/src/js/fields/basic_fields.js b/addons/web/static/src/js/fields/basic_fields.js index 879ee978220..3a3a037a0f0 100644 --- a/addons/web/static/src/js/fields/basic_fields.js +++ b/addons/web/static/src/js/fields/basic_fields.js @@ -2362,7 +2362,7 @@ var StateSelectionWidget = AbstractField.extend({ .addClass(currentState.state_class) .prop('special_click', true) .parent().attr('title', currentState.state_name) - .attr('aria-label', currentState.state_name); + .attr('aria-label', this.string + ": " + currentState.state_name); // Render "FormSelection.Items" and move it into "FormSelection" var $items = $(qweb.render('FormSelection.items', { -- cgit v1.2.3