From ac3e0fcd32d66d6e0bacfabd2d224805d92dbfd1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Luis=20Gonz=C3=A1lez?= Date: Sat, 13 Mar 2021 18:11:00 +0000 Subject: [FIX] web: Aria attributes on buttons Export All & optional columns Some aria attributes were missing or incorrectly set on these new buttons: - The button "Export All" was missing an `aria-label` attribute - The button to show/hide optional columns was also missing an `aria-label` attribute, and its menu items (checkboxes to show/hide columns) were missing a proper role - Ever since the debug manager was added in frontend on 73327db0656b, the `aria-label` attribute was not being rendered correctly on the button to open developer tools closes odoo/odoo#70390 X-original-commit: 620e4cc28cefed6f4a3b5ca89b11cc37222acfaf Signed-off-by: Nicolas Lempereur (nle) --- addons/web/static/src/js/core/dom.js | 3 +++ 1 file changed, 3 insertions(+) (limited to 'addons/web/static/src/js/core') diff --git a/addons/web/static/src/js/core/dom.js b/addons/web/static/src/js/core/dom.js index b14684e4acd..4f1696b43ea 100644 --- a/addons/web/static/src/js/core/dom.js +++ b/addons/web/static/src/js/core/dom.js @@ -485,6 +485,9 @@ var dom = { if (options && options.prop) { $input.prop(options.prop); } + if (options && options.role) { + $input.attr('role', options.role); + } return $container.append($input, $label); }, /** -- cgit v1.2.3