From 852781cf64ad6bb10c552e106e93e2bb6035e34b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Thu, 11 Mar 2021 17:58:38 +0000 Subject: [FIX] web: prevent popover race condition between unmount and event These are throttled/debounced so the handlers are sometimes called after the component has been destroyed. opw-2451752 closes odoo/odoo#67723 Signed-off-by: Aaron Bohy (aab) --- addons/web/static/src/js/core/popover.js | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'addons/web/static/src/js/core') diff --git a/addons/web/static/src/js/core/popover.js b/addons/web/static/src/js/core/popover.js index d2102b56d3c..2400f075ca0 100644 --- a/addons/web/static/src/js/core/popover.js +++ b/addons/web/static/src/js/core/popover.js @@ -219,6 +219,9 @@ odoo.define('web.Popover', function (require) { * @param {Event} ev */ _onResizeWindow(ev) { + if (this.__owl__.status === 5 /* destroyed */) { + return; + } this._compute(); } @@ -230,6 +233,9 @@ odoo.define('web.Popover', function (require) { * @param {Event} ev */ _onScrollDocument(ev) { + if (this.__owl__.status === 5 /* destroyed */) { + return; + } this._compute(); } -- cgit v1.2.3