From 71a2d7c06a6142bfe3e967aa8ff60552e24eb0c1 Mon Sep 17 00:00:00 2001 From: Pierre Paridans Date: Wed, 27 Mar 2019 13:50:22 +0000 Subject: [REF] web: don't destroy twice a widget's children MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Widget class indirectly inherits from ParentedMixin (through PropertiesMixin). The Widget's children are destroyed in both the ParentedMixin and the Widget's own destroy() method. This commit prevents from trying to destroy already destroyed children and specifically from looping again on those children (resulting into a minor performance improvement). closes odoo/odoo#32174 Signed-off-by: Adrien Dieudonné (adr) --- addons/web/static/src/js/core/widget.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'addons/web/static/src/js/core/widget.js') diff --git a/addons/web/static/src/js/core/widget.js b/addons/web/static/src/js/core/widget.js index 0de8c6aa1cd..441899e30db 100644 --- a/addons/web/static/src/js/core/widget.js +++ b/addons/web/static/src/js/core/widget.js @@ -172,13 +172,10 @@ var Widget = core.Class.extend(mixins.PropertiesMixin, ServicesMixin, { * destroying itself. */ destroy: function () { - this.getChildren().forEach(function (child) { - child.destroy(); - }); + mixins.PropertiesMixin.destroy.call(this); if (this.$el) { this.$el.remove(); } - mixins.PropertiesMixin.destroy.call(this); }, //-------------------------------------------------------------------------- -- cgit v1.2.3