From 12fcd1be2f1a891b7fe099ad0044e68c45280907 Mon Sep 17 00:00:00 2001 From: "uco (OpenERP)" Date: Fri, 19 Nov 2010 19:18:01 +0530 Subject: [IMP] : Added context=None on methods used for _constraints and replaced context={} with context=None. bzr revid: uco@tinyerp.com-20101119134801-974ev29j4tu46pq2 --- addons/project_issue/project_issue.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'addons/project_issue/project_issue.py') diff --git a/addons/project_issue/project_issue.py b/addons/project_issue/project_issue.py index 2887b25610d..46341dd2990 100644 --- a/addons/project_issue/project_issue.py +++ b/addons/project_issue/project_issue.py @@ -486,8 +486,8 @@ class project(osv.osv): 'reply_to' : fields.char('Reply-To Email Address', size=256) } - def _check_escalation(self, cr, uid, ids): - project_obj = self.browse(cr, uid, ids[0]) + def _check_escalation(self, cr, uid, ids, context=None): + project_obj = self.browse(cr, uid, ids[0], context=context) if project_obj.project_escalation_id: if project_obj.project_escalation_id.id == project_obj.id: return False -- cgit v1.2.3 From 8035df3e1152a8f9d9703037d9d1bee718d94331 Mon Sep 17 00:00:00 2001 From: "uco (OpenERP)" Date: Mon, 22 Nov 2010 16:07:53 +0530 Subject: [IMP]: Added context=None in function argument for rest modules. bzr revid: uco@tinyerp.com-20101122103753-idv9fdaqc28rvugu --- addons/project_issue/project_issue.py | 21 ++++++++++++++++----- 1 file changed, 16 insertions(+), 5 deletions(-) (limited to 'addons/project_issue/project_issue.py') diff --git a/addons/project_issue/project_issue.py b/addons/project_issue/project_issue.py index 46341dd2990..17624502535 100644 --- a/addons/project_issue/project_issue.py +++ b/addons/project_issue/project_issue.py @@ -230,7 +230,9 @@ class project_issue(crm.crm_case, osv.osv): }), } - def _get_project(self, cr, uid, context): + def _get_project(self, cr, uid, context=None): + if not context: + context = {} user = self.pool.get('res.users').browse(cr, uid, uid, context=context) if user.context_project_id: return user.context_project_id.id @@ -300,6 +302,8 @@ class project_issue(crm.crm_case, osv.osv): def _convert(self, cr, uid, ids, xml_id, context=None): + if not context: + context = {} data_obj = self.pool.get('ir.model.data') id2 = data_obj._get_id(cr, uid, 'project_issue', xml_id) categ_id = False @@ -310,9 +314,13 @@ class project_issue(crm.crm_case, osv.osv): return True def convert_to_feature(self, cr, uid, ids, context=None): + if not context: + context = {} return self._convert(cr, uid, ids, 'feature_request_categ', context=context) def convert_to_bug(self, cr, uid, ids, context=None): + if not context: + context = {} return self._convert(cr, uid, ids, 'bug_categ', context=context) def next_type(self, cr, uid, ids, *args): @@ -344,7 +352,7 @@ class project_issue(crm.crm_case, osv.osv): result = {} if not task_id: return {'value':{}} - task = self.pool.get('project.task').browse(cr, uid, task_id, context) + task = self.pool.get('project.task').browse(cr, uid, task_id, context=context) return {'value':{'assigned_to': task.user_id.id,}} def case_escalate(self, cr, uid, ids, *args): @@ -370,7 +378,7 @@ class project_issue(crm.crm_case, osv.osv): self._history(cr, uid, cases, _('Escalate')) return True - def message_new(self, cr, uid, msg, context): + def message_new(self, cr, uid, msg, context=None): """ Automatically calls when new email message arrives @@ -378,7 +386,8 @@ class project_issue(crm.crm_case, osv.osv): @param cr: the current row, from the database cursor, @param uid: the current user’s ID for security checks """ - + if not context: + context = {} mailgate_pool = self.pool.get('email.server.tools') subject = msg.get('subject') or _('No Title') @@ -400,7 +409,7 @@ class project_issue(crm.crm_case, osv.osv): if res: vals.update(res) context.update({'state_to' : 'draft'}) - res = self.create(cr, uid, vals, context) + res = self.create(cr, uid, vals, context=context) self.convert_to_bug(cr, uid, [res], context=context) attachents = msg.get('attachments', []) @@ -487,6 +496,8 @@ class project(osv.osv): } def _check_escalation(self, cr, uid, ids, context=None): + if not context: + context = {} project_obj = self.browse(cr, uid, ids[0], context=context) if project_obj.project_escalation_id: if project_obj.project_escalation_id.id == project_obj.id: -- cgit v1.2.3 From 6dd290e8245f4ea91ce87b0f3b5f29bafeaf12e9 Mon Sep 17 00:00:00 2001 From: "uco (OpenERP)" Date: Tue, 23 Nov 2010 12:35:05 +0530 Subject: [REF]: Replace the condition 'if not context' with 'if context is None'. bzr revid: uco@tinyerp.com-20101123070505-9i2lrqhgxzaii3zn --- addons/project_issue/project_issue.py | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) (limited to 'addons/project_issue/project_issue.py') diff --git a/addons/project_issue/project_issue.py b/addons/project_issue/project_issue.py index 17624502535..9e8c5aa7863 100644 --- a/addons/project_issue/project_issue.py +++ b/addons/project_issue/project_issue.py @@ -231,8 +231,6 @@ class project_issue(crm.crm_case, osv.osv): } def _get_project(self, cr, uid, context=None): - if not context: - context = {} user = self.pool.get('res.users').browse(cr, uid, uid, context=context) if user.context_project_id: return user.context_project_id.id @@ -302,8 +300,6 @@ class project_issue(crm.crm_case, osv.osv): def _convert(self, cr, uid, ids, xml_id, context=None): - if not context: - context = {} data_obj = self.pool.get('ir.model.data') id2 = data_obj._get_id(cr, uid, 'project_issue', xml_id) categ_id = False @@ -314,13 +310,9 @@ class project_issue(crm.crm_case, osv.osv): return True def convert_to_feature(self, cr, uid, ids, context=None): - if not context: - context = {} return self._convert(cr, uid, ids, 'feature_request_categ', context=context) def convert_to_bug(self, cr, uid, ids, context=None): - if not context: - context = {} return self._convert(cr, uid, ids, 'bug_categ', context=context) def next_type(self, cr, uid, ids, *args): @@ -386,8 +378,7 @@ class project_issue(crm.crm_case, osv.osv): @param cr: the current row, from the database cursor, @param uid: the current user’s ID for security checks """ - if not context: - context = {} + if context is None: context = {} mailgate_pool = self.pool.get('email.server.tools') subject = msg.get('subject') or _('No Title') @@ -475,8 +466,6 @@ class project_issue(crm.crm_case, osv.osv): return True def copy(self, cr, uid, id, default=None, context=None): - if not context: - context={} issue = self.read(cr, uid, id, ['name'], context=context) if not default: default = {} @@ -496,8 +485,6 @@ class project(osv.osv): } def _check_escalation(self, cr, uid, ids, context=None): - if not context: - context = {} project_obj = self.browse(cr, uid, ids[0], context=context) if project_obj.project_escalation_id: if project_obj.project_escalation_id.id == project_obj.id: -- cgit v1.2.3 From d827b2f6ea63dc04b91a7e59b3e7fecd7c5810d3 Mon Sep 17 00:00:00 2001 From: "uco (OpenERP)" Date: Mon, 13 Dec 2010 12:13:09 +0530 Subject: [REF]: Added remaining context changes in _constraints. Removed unnecessary checking for context from methods. bzr revid: uco@tinyerp.com-20101213064309-vg36f1510xv2f8zb --- addons/project_issue/project_issue.py | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) (limited to 'addons/project_issue/project_issue.py') diff --git a/addons/project_issue/project_issue.py b/addons/project_issue/project_issue.py index 9e8c5aa7863..dc272404688 100644 --- a/addons/project_issue/project_issue.py +++ b/addons/project_issue/project_issue.py @@ -78,8 +78,6 @@ class project_issue(crm.crm_case, osv.osv): return res def _compute_day(self, cr, uid, ids, fields, args, context=None): - if context is None: - context = {} """ @param cr: the current row, from the database cursor, @param uid: the current user’s ID for security checks, @@ -143,8 +141,6 @@ class project_issue(crm.crm_case, osv.osv): return res def _get_issue_task(self, cr, uid, ids, context=None): - if context is None: - context = {} issues = [] issue_pool = self.pool.get('project.issue') for task in self.pool.get('project.task').browse(cr, uid, ids, context=context): @@ -152,8 +148,6 @@ class project_issue(crm.crm_case, osv.osv): return issues def _get_issue_work(self, cr, uid, ids, context=None): - if context is None: - context = {} issues = [] issue_pool = self.pool.get('project.issue') for work in self.pool.get('project.task.work').browse(cr, uid, ids, context=context): @@ -339,8 +333,6 @@ class project_issue(crm.crm_case, osv.osv): def onchange_task_id(self, cr, uid, ids, task_id, context=None): - if context is None: - context = {} result = {} if not task_id: return {'value':{}} @@ -378,7 +370,8 @@ class project_issue(crm.crm_case, osv.osv): @param cr: the current row, from the database cursor, @param uid: the current user’s ID for security checks """ - if context is None: context = {} + if context is None: + context = {} mailgate_pool = self.pool.get('email.server.tools') subject = msg.get('subject') or _('No Title') @@ -418,8 +411,6 @@ class project_issue(crm.crm_case, osv.osv): return res def message_update(self, cr, uid, ids, vals={}, msg="", default_act='pending', context=None): - if context is None: - context = {} """ @param self: The object pointer @param cr: the current row, from the database cursor, -- cgit v1.2.3