From fdb23e282b90ad95e4f909f7232eb0aa36038836 Mon Sep 17 00:00:00 2001 From: Victor Feyens Date: Mon, 10 Aug 2020 13:17:00 +0000 Subject: [IMP] *: wrong any() usage Replace wrong usages of any(list|recordset), by any(generator) to speed up computations, avoiding list creations and/or looping twice on a recordset for nothing. any([generator]) => any(generator) any(filtered) => any(generator) closes odoo/odoo#55768 Related: odoo/enterprise#12360 Signed-off-by: Victor Feyens (vfe) --- addons/mail_bot/models/res_partner.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'addons/mail_bot') diff --git a/addons/mail_bot/models/res_partner.py b/addons/mail_bot/models/res_partner.py index 2a6ec5eca55..8a3fc3ca106 100644 --- a/addons/mail_bot/models/res_partner.py +++ b/addons/mail_bot/models/res_partner.py @@ -20,8 +20,7 @@ class Partner(models.Model): [users, partners] = super(Partner, self).get_mention_suggestions(search, limit=limit) if len(partners) + len(users) < limit and "odoobot".startswith(search.lower()): odoobot = self.env.ref("base.partner_root") - if not any([elem['id'] == odoobot.id for elem in partners]): - if odoobot: - partners.append({'id': odoobot.id, 'name': odoobot.name, 'email': odoobot.email}) + if odoobot and not any(elem['id'] == odoobot.id for elem in partners): + partners.append({'id': odoobot.id, 'name': odoobot.name, 'email': odoobot.email}) return [users, partners] -- cgit v1.2.3