From 2002c6a599a685f4a18fc670a9f7992c8d595c0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Theys?= Date: Mon, 16 Nov 2020 12:36:47 +0000 Subject: [FIX] mail: fix race conditions, especially with scroll MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The `_update` of some components must take place before the `_update` of other (usually sibling) components that might directly influence their layout. This is in particular the case for `_update` that are relying on height. Prevent force save of scroll position if there are pending hints to adjust it, and prevent pending hints from overriding new scroll value. Prevent flicker with message date. This should fix all known issues related to incorrectly saving or restoring scroll position. task-2344226 task-2358066 task-2369332 task-2372339 task-2373741 closes odoo/odoo#61054 Related: odoo/enterprise#14736 Signed-off-by: Alexandre Kühn (aku) --- .../mail/static/src/components/thread_view/thread_view.js | 13 +++++-------- 1 file changed, 5 insertions(+), 8 deletions(-) (limited to 'addons/mail/static/src/components/thread_view/thread_view.js') diff --git a/addons/mail/static/src/components/thread_view/thread_view.js b/addons/mail/static/src/components/thread_view/thread_view.js index ceff30d1077..132425184b3 100644 --- a/addons/mail/static/src/components/thread_view/thread_view.js +++ b/addons/mail/static/src/components/thread_view/thread_view.js @@ -6,6 +6,7 @@ const components = { MessageList: require('mail/static/src/components/message_list/message_list.js'), }; const useStore = require('mail/static/src/component_hooks/use_store/use_store.js'); +const useUpdate = require('mail/static/src/component_hooks/use_update/use_update.js'); const { Component } = owl; const { useRef } = owl.hooks; @@ -18,6 +19,10 @@ class ThreadView extends Component { constructor(...args) { super(...args); useStore((...args) => this._useStoreSelector(...args)); + useUpdate({ + func: () => this._update(), + priority: 100, // must be executed after composer height adjust + }); /** * Reference of the composer. Useful to set focus on composer when * thread has the focus. @@ -29,14 +34,6 @@ class ThreadView extends Component { this._messageListRef = useRef('messageList'); } - mounted() { - this._update(); - } - - patched() { - this._update(); - } - //-------------------------------------------------------------------------- // Public //-------------------------------------------------------------------------- -- cgit v1.2.3