From cfe2ee93414914d41d97f5406c8d2c5daa36cc64 Mon Sep 17 00:00:00 2001
From: Olivier Colson <oco@odoo.com>
Date: Fri, 12 Jul 2019 09:10:30 +0000
Subject: [FIX] l10n_do: use the right sign on every tax tags

Some signs had been inverted when converting from 12.2 to 12.3 model.

closes odoo/odoo#34817

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
---
 addons/l10n_do/data/account.tax.template.xml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

(limited to 'addons/l10n_do')

diff --git a/addons/l10n_do/data/account.tax.template.xml b/addons/l10n_do/data/account.tax.template.xml
index 7d970672e91..dfb8cd06bd1 100644
--- a/addons/l10n_do/data/account.tax.template.xml
+++ b/addons/l10n_do/data/account.tax.template.xml
@@ -798,7 +798,7 @@
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('do_niif_21030203'),
-                    'plus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
+                    'minus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
                 }),
             ]"/>
             <field name="refund_repartition_line_ids" eval="[(5,0,0),
@@ -811,7 +811,7 @@
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('do_niif_21030203'),
-                    'minus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
+                    'plus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
                 }),
             ]"/>
         </record>
@@ -836,7 +836,7 @@
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('do_niif_21030202'),
-                    'plus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
+                    'minus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
                 }),
             ]"/>
             <field name="refund_repartition_line_ids" eval="[(5,0,0),
@@ -849,7 +849,7 @@
                     'factor_percent': 100,
                     'repartition_type': 'tax',
                     'account_id': ref('do_niif_21030202'),
-                    'minus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
+                    'plus_report_line_ids': [ref('account_tax_report_itbs_retcn_prsn')],
                 }),
             ]"/>
         </record>
-- 
cgit v1.2.3


From 333c22edd9eee246214259be587e10b8202f40a0 Mon Sep 17 00:00:00 2001
From: Olivier Colson <oco@odoo.com>
Date: Mon, 15 Jul 2019 08:19:08 +0000
Subject: [FIX] l10n_*: fix taxes repartition so that 12.3 matches what is
 defined in 12.2

[IMP] l10n_*: don't define accounts or tags on tax repartition line templates anymore for 0% taxes

[FIX] account: remove old function used to migrate the former tax model, incompatible with the new one
---
 addons/l10n_do/data/account.tax.template.xml | 30 ----------------------------
 1 file changed, 30 deletions(-)

(limited to 'addons/l10n_do')

diff --git a/addons/l10n_do/data/account.tax.template.xml b/addons/l10n_do/data/account.tax.template.xml
index dfb8cd06bd1..7aaf53e8cee 100644
--- a/addons/l10n_do/data/account.tax.template.xml
+++ b/addons/l10n_do/data/account.tax.template.xml
@@ -1217,36 +1217,6 @@
             <field name="tax_group_id" ref="group_ret"/>
         </record>
 
-        <record id="tax_group_moral_construction" model="account.tax.template">
-            <field name="chart_template_id" ref="do_chart_template"/>
-            <field name="sequence">62</field>
-            <field name="name">Retención a Jurídica (Servicios Construcción con Materiales)</field>
-            <field name="amount_type">group</field>
-            <field eval="0" name="amount"/>
-            <field name="type_tax_use">none</field>
-            <field name="tax_group_id" ref="group_ret"/>
-            <field name="invoice_repartition_line_ids" eval="[(5,0,0),
-                (0,0, {
-                    'factor_percent': 100,
-                    'repartition_type': 'base',
-                }),
-                (0,0, {
-                    'factor_percent': 100,
-                    'repartition_type': 'tax',
-                }),
-            ]"/>
-            <field name="refund_repartition_line_ids" eval="[(5,0,0),
-                (0,0, {
-                    'factor_percent': 100,
-                    'repartition_type': 'base',
-                }),
-                (0,0, {
-                    'factor_percent': 100,
-                    'repartition_type': 'tax',
-                }),
-            ]"/>
-        </record>
-
         <record id="tax_group_person_services" model="account.tax.template">
             <field name="chart_template_id" ref="do_chart_template"/>
             <field name="sequence">58</field>
-- 
cgit v1.2.3