From 49fc197925f44b0ffd09ca7a821f5e7ac5476b68 Mon Sep 17 00:00:00 2001 From: Martin Trigaux Date: Mon, 13 Jul 2020 08:27:55 +0000 Subject: [FIX] gamification: use right field on goal domain There is no field 'ids' on a gamification.goal, but one called 'id' Without this commit, calling _get_serialized_challenge_lines (or indirectly, calling report_progress) with a non-empty subset_goals was failing due to an invalid domain. This is not supposed to happen on standard flow but can be triggered with manual modification of date fields and refreshing a challenge. Fixes odoo/odoo#25913 closes odoo/odoo#54387 X-original-commit: 1e3483d2fc99763940396936758cf99b14d0a118 Signed-off-by: Martin Trigaux (mat) --- addons/gamification/models/challenge.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/gamification') diff --git a/addons/gamification/models/challenge.py b/addons/gamification/models/challenge.py index b2f9289303e..2a1be3c6b88 100644 --- a/addons/gamification/models/challenge.py +++ b/addons/gamification/models/challenge.py @@ -472,7 +472,7 @@ class Challenge(models.Model): ('state', '!=', 'draft'), ] if restrict_goals: - domain.append(('ids', 'in', restrict_goals.ids)) + domain.append(('id', 'in', restrict_goals.ids)) else: # if no subset goals, use the dates for restriction if start_date: -- cgit v1.2.3