From c87b351855b4e2f2c42be8a73ea468d6b1006e57 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thibault=20Delavall=C3=A9e?= Date: Fri, 29 Mar 2019 12:28:50 +0000 Subject: [REF] fetchmail: clean and remove unnecessary code about mail.mail Purpose: small cleaning of code linked to mail.mail model in order to avoid unnecessary overrides * create mail: default_fetchmail_server_id in context should be sufficient as it is the base mechanism of default_get; * write: unused in codebase. Anyway we should not write on mail and if it is the case giving fetchmail_server_id directly should be the correct way of doing it; In case of a clean_context use we might loose default_fetchmail_server_id key. It is used notably for tracking message generation. In that case this information could be lost. However the whole concept of propagating a fetrchmail_server-id from incoming mail server to outgoing emails (as mail.mail is used only for sending email) is strange and does not require so much specific code. Sub-part of task 1853147 (pre-cleaning before implementing mail gateway improvements) Linked to PR #32974 --- addons/fetchmail/models/fetchmail.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/fetchmail/models/fetchmail.py') diff --git a/addons/fetchmail/models/fetchmail.py b/addons/fetchmail/models/fetchmail.py index d04641bb450..62334f45562 100644 --- a/addons/fetchmail/models/fetchmail.py +++ b/addons/fetchmail/models/fetchmail.py @@ -160,7 +160,7 @@ class FetchmailServer(models.Model): MailThread = self.env['mail.thread'] for server in self: _logger.info('start checking for new emails on %s server %s', server.server_type, server.name) - additionnal_context['fetchmail_server_id'] = server.id + additionnal_context['default_fetchmail_server_id'] = server.id additionnal_context['server_type'] = server.server_type count, failed = 0, 0 imap_server = None -- cgit v1.2.3