From b9e8786ef86b4ef89af84aab1a2a2c44d09826b9 Mon Sep 17 00:00:00 2001 From: "mra (Open ERP)" Date: Mon, 5 Jan 2009 18:14:34 +0530 Subject: changes on quality module bzr revid: mra@tinyerp.com-20090105124434-oll8rix427lv524l --- .../base_module_quality/method_test/method_test.py | 32 ++++++++++------------ 1 file changed, 15 insertions(+), 17 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index 38a07c9428b..b07e7f349e1 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -31,21 +31,15 @@ class quality_test(base_module_quality.abstract_quality_check): def __init__(self): super(quality_test, self).__init__() -# self.result = """ -#===Method Test===: -# -#This test checks if the module classes are raising exception when calling basic methods or no. -# -#""" self.bool_installed_only = True self.ponderation = 1.0 + self.result_det = {} return None - def run_test(self, cr, uid, module_path, module_state): + def run_test(self, cr, uid, module_path): pool = pooler.get_pool(cr.dbname) module_name = module_path.split('/')[-1] obj_list = self.get_objects(cr, uid, module_name) - result = {} ok_count = 0 ex_count = 0 for obj in obj_list: @@ -71,29 +65,33 @@ class quality_test(base_module_quality.abstract_quality_check): except: temp.append('Exception') ex_count += 1 - result[obj] = temp -# self.result += ('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ') % ('Object Name'.ljust(40), 'search()'.ljust(16), 'fields_view_get()'.ljust(20), 'read()'.ljust(16)) - header_list = ['Object Name', 'search()', 'fields_view_get', 'read'] -# for res in result: -# self.result += ('\n|-\n| %s \n| %s \n| %s \n| %s ') % (res, result[res][0],result[res][1], result[res][2]) -# self.result += '\n|}' + self.result_det[obj] = temp self.score = (ok_count + ex_count) and float(ok_count)/float(ok_count + ex_count) or 0.0 + return None + + def get_result(self, cr, uid, module_path, module_state): + self.run_test(cr, uid, module_path) if not self.bool_installed_only or module_state=="installed": summary = """ ===Method Test===: This test checks if the module classes are raising exception when calling basic methods or no. -""" #+ "Score: " + str(self.score) + "/10\n" +""" + "Score: " + str(self.score) + "/10\n" else: summary =""" \n===Method Test===: The module has to be installed before running this test.\n\n """ header_list = "" self.error = True - self.result = self.format_table(test='method', header=header_list, data_list=[summary,result,self.error]) - return None + return summary + def get_result_detail(self): + header_list = ['method', 'Object Name', 'search()', 'fields_view_get', 'read'] + detail = "\n===Method Test===\n" + if not self.error: + detail += self.format_table(header=header_list, data_list=[self.result_det]) + return detail # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: -- cgit v1.2.3 From aef3884e59c6b1aec0e0f127e3e6c1969f4289a9 Mon Sep 17 00:00:00 2001 From: qdp Date: Mon, 5 Jan 2009 17:25:46 +0100 Subject: improvements on base_module_quality bzr revid: qdp@tinyerp.com-20090105162546-yr8su19er4gkih48 --- addons/base_module_quality/method_test/method_test.py | 18 +++++++----------- 1 file changed, 7 insertions(+), 11 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index b07e7f349e1..ed53a535bcb 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -67,26 +67,22 @@ class quality_test(base_module_quality.abstract_quality_check): ex_count += 1 self.result_det[obj] = temp self.score = (ok_count + ex_count) and float(ok_count)/float(ok_count + ex_count) or 0.0 + self.result = self.get_result() + self.result_details = self.get_result_details() + return None - def get_result(self, cr, uid, module_path, module_state): - self.run_test(cr, uid, module_path) - if not self.bool_installed_only or module_state=="installed": - summary = """ + + def get_result(self): + summary = """ ===Method Test===: This test checks if the module classes are raising exception when calling basic methods or no. """ + "Score: " + str(self.score) + "/10\n" - else: - summary =""" \n===Method Test===: - -The module has to be installed before running this test.\n\n """ - header_list = "" - self.error = True return summary - def get_result_detail(self): + def get_result_details(self): header_list = ['method', 'Object Name', 'search()', 'fields_view_get', 'read'] detail = "\n===Method Test===\n" if not self.error: -- cgit v1.2.3 From 9ac4708047bf57345624001a486d0cba32428001 Mon Sep 17 00:00:00 2001 From: "mra (Open ERP)" Date: Wed, 7 Jan 2009 15:03:01 +0530 Subject: small changes bzr revid: mra@tinyerp.com-20090107093301-riilvjtanc4ibqdq --- addons/base_module_quality/method_test/method_test.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index ed53a535bcb..5c244309b14 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -31,6 +31,7 @@ class quality_test(base_module_quality.abstract_quality_check): def __init__(self): super(quality_test, self).__init__() + self.name = _("Method Test") self.bool_installed_only = True self.ponderation = 1.0 self.result_det = {} @@ -69,22 +70,17 @@ class quality_test(base_module_quality.abstract_quality_check): self.score = (ok_count + ex_count) and float(ok_count)/float(ok_count + ex_count) or 0.0 self.result = self.get_result() self.result_details = self.get_result_details() - return None - def get_result(self): summary = """ -===Method Test===: - This test checks if the module classes are raising exception when calling basic methods or no. - -""" + "Score: " + str(self.score) + "/10\n" +""" return summary def get_result_details(self): header_list = ['method', 'Object Name', 'search()', 'fields_view_get', 'read'] - detail = "\n===Method Test===\n" + detail = "" #"\n===Method Test===\n" if not self.error: detail += self.format_table(header=header_list, data_list=[self.result_det]) return detail -- cgit v1.2.3 From 1d2fef3edfc768aa681dd609db2516d34fae27a0 Mon Sep 17 00:00:00 2001 From: "mra (Open ERP)" Date: Wed, 7 Jan 2009 18:37:53 +0530 Subject: quality module bzr revid: mra@tinyerp.com-20090107130753-n0or93qkfcuj96b6 --- addons/base_module_quality/method_test/method_test.py | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index 5c244309b14..8ca77b996f5 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -35,6 +35,7 @@ class quality_test(base_module_quality.abstract_quality_check): self.bool_installed_only = True self.ponderation = 1.0 self.result_det = {} + self.data_list = [] return None def run_test(self, cr, uid, module_path): @@ -67,6 +68,7 @@ class quality_test(base_module_quality.abstract_quality_check): temp.append('Exception') ex_count += 1 self.result_det[obj] = temp + self.data_list.append(self.result_det) self.score = (ok_count + ex_count) and float(ok_count)/float(ok_count + ex_count) or 0.0 self.result = self.get_result() self.result_details = self.get_result_details() @@ -79,10 +81,14 @@ This test checks if the module classes are raising exception when calling basic return summary def get_result_details(self): - header_list = ['method', 'Object Name', 'search()', 'fields_view_get', 'read'] - detail = "" #"\n===Method Test===\n" + header_list = [] + header_list.append('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ') + header_list.append('\n|-\n| %s \n| %s \n| %s \n| %s ') + header_view = ['Object Name', 'search()', 'fields_view_get', 'read'] + self.data_list.append(header_view) + detail = "" if not self.error: - detail += self.format_table(header=header_list, data_list=[self.result_det]) + detail += self.format_table(header=header_list, data_list=self.data_list) return detail # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: -- cgit v1.2.3 From 78d2de2600f3d383edffacb6c0b213b8d8200817 Mon Sep 17 00:00:00 2001 From: "Jay (Open ERP)" Date: Wed, 7 Jan 2009 19:53:15 +0530 Subject: Corrected terp test on Quality Module bzr revid: jvo@tinyerp.com-20090107142315-xb8qq0u9coexf04m --- addons/base_module_quality/method_test/method_test.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index 8ca77b996f5..58c536e9e9c 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -76,7 +76,7 @@ class quality_test(base_module_quality.abstract_quality_check): def get_result(self): summary = """ -This test checks if the module classes are raising exception when calling basic methods or no. +This test checks if the module classes are raising exception when calling basic methods or not. """ return summary -- cgit v1.2.3 From 5b6bcfb55917f2755e4998ed5f684a1b19f8d872 Mon Sep 17 00:00:00 2001 From: qdp Date: Thu, 8 Jan 2009 09:49:26 +0100 Subject: *imrpovements bzr revid: qdp@tinyerp.com-20090108084926-n4dxtv1bczx9id1t --- .../base_module_quality/method_test/method_test.py | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index 58c536e9e9c..b9c52279875 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -34,8 +34,6 @@ class quality_test(base_module_quality.abstract_quality_check): self.name = _("Method Test") self.bool_installed_only = True self.ponderation = 1.0 - self.result_det = {} - self.data_list = [] return None def run_test(self, cr, uid, module_path): @@ -44,8 +42,9 @@ class quality_test(base_module_quality.abstract_quality_check): obj_list = self.get_objects(cr, uid, module_name) ok_count = 0 ex_count = 0 + result_dict = {} for obj in obj_list: - temp = [] + temp = [obj] try: res = pool.get(obj).search(cr, uid, []) temp.append('Ok') @@ -67,11 +66,10 @@ class quality_test(base_module_quality.abstract_quality_check): except: temp.append('Exception') ex_count += 1 - self.result_det[obj] = temp - self.data_list.append(self.result_det) + result_dict[obj] = temp self.score = (ok_count + ex_count) and float(ok_count)/float(ok_count + ex_count) or 0.0 self.result = self.get_result() - self.result_details = self.get_result_details() + self.result_details = self.get_result_details(result_dict) return None def get_result(self): @@ -80,15 +78,11 @@ This test checks if the module classes are raising exception when calling basic """ return summary - def get_result_details(self): - header_list = [] - header_list.append('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ') - header_list.append('\n|-\n| %s \n| %s \n| %s \n| %s ') - header_view = ['Object Name', 'search()', 'fields_view_get', 'read'] - self.data_list.append(header_view) + def get_result_details(self, dict): + header = ('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ', [_('Object Name'), 'search()', 'fields_view_get()', 'read()']) detail = "" if not self.error: - detail += self.format_table(header=header_list, data_list=self.data_list) + detail += self.format_table(header, dict) return detail # vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4: -- cgit v1.2.3 From 8a06bea953c16c90d4bef269638b5d6b467b89a9 Mon Sep 17 00:00:00 2001 From: qdp Date: Thu, 8 Jan 2009 14:03:20 +0100 Subject: base_module_quality improvements: *added note field *improved transability *improved output *cleaned *modified format_table method bzr revid: qdp@tinyerp.com-20090108130320-ypcc4jxbx51jv1ra --- .../base_module_quality/method_test/method_test.py | 25 ++++++++++------------ 1 file changed, 11 insertions(+), 14 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index b9c52279875..1abaa288e86 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -32,6 +32,9 @@ class quality_test(base_module_quality.abstract_quality_check): def __init__(self): super(quality_test, self).__init__() self.name = _("Method Test") + self.note = _(""" +This test checks if the module classes are raising exception when calling basic methods or not. +""") self.bool_installed_only = True self.ponderation = 1.0 return None @@ -47,38 +50,32 @@ class quality_test(base_module_quality.abstract_quality_check): temp = [obj] try: res = pool.get(obj).search(cr, uid, []) - temp.append('Ok') + temp.append(_('Ok')) ok_count += 1 except: - temp.append('Exception') + temp.append(_('Exception')) ex_count += 1 try: res1 = pool.get(obj).fields_view_get(cr, uid,) - temp.append('Ok') + temp.append(_('Ok')) ok_count += 1 except: - temp.append('Exception') + temp.append(_('Exception')) ex_count += 1 try: res2 = pool.get(obj).read(cr, uid, []) - temp.append('Ok') + temp.append(_('Ok')) ok_count += 1 except: - temp.append('Exception') + temp.append(_('Exception')) ex_count += 1 result_dict[obj] = temp self.score = (ok_count + ex_count) and float(ok_count)/float(ok_count + ex_count) or 0.0 - self.result = self.get_result() - self.result_details = self.get_result_details(result_dict) + self.result = self.get_result(result_dict) return None - def get_result(self): - summary = """ -This test checks if the module classes are raising exception when calling basic methods or not. -""" - return summary - def get_result_details(self, dict): + def get_result(self, dict): header = ('{| border="1" cellspacing="0" cellpadding="5" align="left" \n! %-40s \n! %-16s \n! %-20s \n! %-16s ', [_('Object Name'), 'search()', 'fields_view_get()', 'read()']) detail = "" if not self.error: -- cgit v1.2.3 From a527763cd835f56f4d5eff5b37003f8e52307397 Mon Sep 17 00:00:00 2001 From: Quentin Date: Thu, 8 Jan 2009 15:47:35 +0100 Subject: bugfixes bzr revid: qdp@jade-20090108144735-0005tsmvb1nzxtp9 --- addons/base_module_quality/method_test/method_test.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) (limited to 'addons/base_module_quality/method_test/method_test.py') diff --git a/addons/base_module_quality/method_test/method_test.py b/addons/base_module_quality/method_test/method_test.py index 1abaa288e86..34841dd41cc 100644 --- a/addons/base_module_quality/method_test/method_test.py +++ b/addons/base_module_quality/method_test/method_test.py @@ -20,9 +20,7 @@ # ############################################################################## - -import os -from tools import config +from tools.translate import _ from base_module_quality import base_module_quality import pooler -- cgit v1.2.3