From 2030ebe18804edc8d3a4eeb7986df9a7eaca7255 Mon Sep 17 00:00:00 2001 From: tivisse Date: Thu, 18 Feb 2021 15:10:50 +0000 Subject: [FIX] hr_holidays: Can not approve or validate time off A leave manager should be able to approve a time off that already begun. opw:2447240 closes odoo/odoo#66481 Signed-off-by: Simon Goffin (sig) Co-authored-by: simongoffin --- addons/hr_holidays/models/hr_leave.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/addons/hr_holidays/models/hr_leave.py b/addons/hr_holidays/models/hr_leave.py index 8d12097cdd9..fbf20ee87af 100644 --- a/addons/hr_holidays/models/hr_leave.py +++ b/addons/hr_holidays/models/hr_leave.py @@ -793,7 +793,7 @@ class HolidaysRequest(models.Model): is_officer = self.env.user.has_group('hr_holidays.group_hr_holidays_user') or self.env.is_superuser() if not is_officer: - if any(hol.date_from.date() < fields.Date.today() for hol in self): + if any(hol.date_from.date() < fields.Date.today() and hol.employee_id.leave_manager_id != self.env.user for hol in self): raise UserError(_('You must have manager rights to modify/validate a time off that already begun')) employee_id = values.get('employee_id', False) -- cgit v1.2.3