summaryrefslogtreecommitdiff
path: root/addons
AgeCommit message (Collapse)Author
2021-05-31[FIX] point_of_sale: print not working in Mobile AppRomeo Fragomeli
Before this commit, "document.execCommand" was first method used when attempting to print, due to a bug in Safari for Windows (ndr. which is deprecated as the last version of Safari for Windows is 5.1.7 from may 2012). On the mobile App, the "document.execCommand('print')" call returns "true" even if nothing has actually been done, which therefore prevents from executing "window.print()". After this commit, we execute directly "window.print()" as it's supported by all modern browsers (except Firefox Android, which doesn't support printing at all). Notes: * "document.execCommand" is deprecated and the "print" command isn't even documented * Safari 5.1.7 doesn't support Promise/Async/Await, and therefore not Odoo 13+. References: * https://developer.mozilla.org/en-US/docs/Web/API/Document/execCommand * https://developer.mozilla.org/en-US/docs/Web/API/Window/print * https://caniuse.com/?search=await * https://caniuse.com/?search=promise * https://apple.stackexchange.com/questions/68836/where-can-i-download-safari-for-windows opw-2486818 closes odoo/odoo#70155 Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
2021-05-31[FIX] point_of_sale: no black backgrounded receiptRomeo Fragomeli
Like commit odoo/odoo@1c5c762f3cd6329ad56149616f836b39efe68148 On some device (like Android Mobile) where the background is printed, the receipt (which is white) is surrounded by a black background. This commit fixes it by matching the receipt background (cf. white) for the whole document and avoiding to print unnecessary background colors. opw-1940434
2021-05-31[FIX] website: remove "add image" button from the normal modeYounn Olivier
The "Add image" button was shown out of the editor mode when removing all images from a snippet. task-2469516 closes odoo/odoo#71424 X-original-commit: c1f4a39071c8f99499a7e1e5214362ac29df8881 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2021-05-28[FIX] website_forum: fix image size in postsYounn Olivier
Before this commit, big images would overflow from posts containers. task-2469516 Part of https://github.com/odoo/odoo/pull/70235 closes odoo/odoo#71412 X-original-commit: 17f736c19ae67acbaa16d2f8452e9ccb58dd3ef3 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2021-05-28[FIX] website_forum: fix image display in a forum postYounn Olivier
The container size of a forum post was not correct when an image was displayed with right or left alignment. The css property clear was added at the end of the posts so that floating elements do not float over the next section. task-2469516 Part of https://github.com/odoo/odoo/pull/70235 X-original-commit: 0c58901cbef8b1d1808f673b7b34d1de93c2fd6d
2021-05-31[FIX] account, mail: link attachments to invoiceAdrien Widart
When using the "Send & Print" functionality, if the user adds an attachment, the latter won't be linked to the record. To reproduce the error: 1. Open a posted invoice 2. Send & Print 3. Attach a file > Select a file on your device 4. Send the email Error: The invoice's PDF is added to record's attachments, but not the other file (from step 3). When the module selects the attachments that need to be linked to the invoice, it only keeps the ones currently linked to `mail.compose.message`: https://github.com/odoo/odoo/blob/6441ab71cb68648aa735057952bf757677a20ee3/addons/mail/models/mail_thread.py#L1719-L1725 This is correct when the user creates a message directly in the chatter. However, when the mail is created thanks to `Send & Print` functionality, the attachment is linked to `account.invoice.send`. Another flow have a similar issue: from invoices list, select few ones, Action > Send & Print: the generated PDF won't be attached to their invoice. In such a situation, here is the source of the problem: https://github.com/odoo/odoo/blob/05ad6c477f7da2a495e5baf5b4629323b9d11fa0/addons/mail/wizard/mail_compose_message.py#L363-L367 There isn't any information about the invoice, therefore it is not possible to linked the attachment to it. OPW-2438457 closes odoo/odoo#71425 X-original-commit: e87f599d4eb22250b628d650b9f59b54db8d043c Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
2021-05-28[IMP] web: add findWhere utilsBruno Boi
closes odoo/odoo#70936 Taskid: 2412172 Related: odoo/enterprise#18366 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2021-05-28[FIX] web: parseDateTime util optimizationsBruno Boi
- `parseDateTime` util: we now caches "without zero" date and time formats Taskid: 2412172
2021-05-30[I18N] Update translation terms from TransifexOdoo Translation Bot
2021-05-28[FIX] web: allow custom filters by ID intervalIvan Yelizariev
Infinite number of records cannot be exported, so after some limit we will get a timeout error. If you need to export more records than that limit, you should be able to filter records into batches. The easiest way to do it is making a filter by ID: ``` [Y| ID Greater than 100000] [Y| ID less than or equal to 200000] ``` --- opw-2517946 closes odoo/odoo#71345 X-original-commit: 2e0127af0d283d1d9bdb033de356e2ddf0973cce Signed-off-by: Aaron Bohy (aab) <aab@odoo.com> Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>
2021-05-28[FIX] point_of_sale: perform stock operation only when necessaryAndrea Grazioso (agr-odoo)
Fine tuning of https://github.com/odoo/odoo/commit/bdd36f7ce68999576dfc30298f4ddf2572b4c7ec to perform the assignment and related operation only when 'consignment' is enabled opw-2508371 closes odoo/odoo#71396 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2021-05-28[FIX] stock: reset stock move stateAdrien Widart
On a delivery, when changing the initial demand of a stock move, if its value was 0 and becomes > 0, its state will be 'Partially Available' but the reserved quantity will still be 0. To reproduce the error: 1. Create 2 products P01, P02 - Product Type: Storable - Qty On Hand: 1 2. Create + Confirm a SO with 1xP01 and 1xP02 3. Open SO's delivery 4. Unlock, set P01's initial demand to 0, Save, Lock 5. Unreserve, Check Availability 6. Unlock, set P01's initial demand to 1, Save 7. Click on PO1 line Error: The stock move state is "Partially Available", but the initial demand is 1 and the reserved quantity is 0. It should be "Waiting Availability" On step 5, since the wanted quantity of P01 is 0, the state of the stock move becomes "Available". Then, when increasing the requested quantity, the state automatically becomes "Partially Available" because the module does not consider the case where the state is "Available" with a reserved quantity equal to 0. OPW-2488580 closes odoo/odoo#71371 X-original-commit: 5773a1e0658d014e6d93a8728f324d76f51fbe25 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
2021-05-27[FIX] mail: use template lang on layout and display namenie
Steps: - Install sale - Go to Settings / Translations / Languages - Activate Dutch - Go to Settings / Users & Companies / Users - Edit demo - Language: Dutch - Go to Sales - Create a quotation: - Customer: demo - Go to Settings / Technical / Automation / Scheduled Actions - Create a new action: - Model: Sales Order - Python code: ```python last_id = model.search([], order='id desc', limit=1)[0].id env.ref('sale.email_template_edi_sale').send_mail(last_id, notif_layout='mail.mail_notification_paynow') ``` - Click "Run Manually" - Go to Settings / Technical / Email / Emails - Open the last email you just sent Bug: Parts of the email are not in Dutch Explanation: This commit makes a template pass the rendering language to the layout and the display name when calling `template.send_mail()`. opw:2467640 closes odoo/odoo#68656 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-05-28[FIX] portal: fix image display in a text block snippetYounn Olivier
The container size of a text block snippet (and every snippet without rows) was not correct when an image was displayed with right or left alignment. The css property clear was added at the end of the containers so that floating elements from the section do not float over the next section. task-2469516 closes odoo/odoo#69621 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2021-05-28[FIX] link_tracker: Filter by tracked URL code is not workingLuis González
When trying to filter links by a tracked URL code, the following warning is shown: WARNING dbname odoo.models: Cannot execute name_search, no _rec_name defined on link.tracker.code and the applied filter gives all records. closes odoo/odoo#71376 X-original-commit: 3687dabbc373e57e24ca4596c18ef1dacfde8273 Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
2021-05-28[FIX] web: add the context in the parameters of the rpc in the _renderBannerDjamel (otd)
Steps to reproduce the bug: - Install Accounting - Connect with a user who has a default company (e.g: Company A) and allowed companies (e.g: “Company A” and “Company B”) - Choose in the company selector “Company B” - Make sure that the onboarding panel in the default company has not been closed - Go to accounting and close the onboarding panel - Refresh the page Problem: The onboarding panel is still open because in the `account/account_dashboard_onboarding` method we check the`account_dashboard_onboarding_state` field of the default company instead of the current company because "allowed_company_ids" is not in the context This problem is also present in all the other views where an onboarding panel is present Solution: Add the context in the parameters of the rpc in the _renderBanner opw-2477148 closes odoo/odoo#71384 X-original-commit: 902950541f8c361e03821314aab4bf4f304ac37d Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com> Signed-off-by: Djamel Touati <DjamelTouati@users.noreply.github.com>
2021-05-28[FIX] point_of_sale: cash rounding on invoicePierre Masereel
When an invoice is created from pos having a cash rounding method, the value of the rounding can depend on the payment methods. When no rounding has been applied because of the order has been partially paid by cash and bank, the rounding line should be deleted from the invoice. We should also adapt the terms lines. closes odoo/odoo#71375 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-05-20[FIX] point_of_sale: random failure when reprint receiptJacky (trj)
Because the `receiptHtml` was taken from a component which was mounted outside of the DOM, it was hardly ever destroyed for some unknown reasons and the `el.outerHTML` could not be taken to create the receipt. closes odoo/odoo#71087 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-05-28[FIX] survey: Unescape characters in mail subjectAdrien Widart
To reproduce the error: Create a survey (title must contain ") and send it Error: The mail subject is incorrect: the character " is replaced with &#34; OPW-2536206 closes odoo/odoo#71363 X-original-commit: a2d46c2d1a64c5006d6a7d9ddf5a08a48e5452b9 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
2021-05-05[FIX] point_of_sale: double dipping in COGS and stock delivered accountsJoseph Caburnay
To reproduce: 1. Sell an anglo product (inventory valuation = automated) in the pos app. 2. Go back to the backend, find the pos.order and invoice it. 3. Close the session. 4. Open the journal items related to the session (click the Journal Items button in the session form). 5. You will see COGS (Expenses) Account and Stock Interim (Delivered) are debited in two journal entries - one from the invoice and one from the created picking after the closing of session. This is because we are not properly skipping the invoiced order when generating the global picking for the session. This commit fixes the described issue. closes odoo/odoo#70374 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-05-27[FIX] website, web_editor: fix colorpicker previewxO-Tx
Issue: > Set bg color combination for a snippet... > Save > Edit mode > Select the snippet > Open color palette in bg option > Hover a color option > When a color button is left, the preview is cancelled but the color combination class is not applied anymore. In '_computeWidgetState' (for 'selectStyle' method), the right value ('o_cci') is not returned because we get empty "colorNames" (the "colorPalette" is not rendered on start). The goal of this commit is to fix this behaviour by rendering the colorPalette in start for snippet options, this way, the new code won't affect the speed fix added in [1] for 'OPTIONS' tab. [1]: https://github.com/odoo/odoo/pull/65223/commits/ce54c3f21293513673cb1fc6073ada5f0a2b5641 task-2538326 closes odoo/odoo#71174 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2021-05-27[FIX] hr_maintenance: fix typo in compute attributeIvan Yelizariev
It was introduced in https://github.com/odoo/odoo/commit/3bd345597fa932abdaf780f72bacf331690f549b closes odoo/odoo#71338 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2021-05-27[FIX] stock_account: fix computation of anglo saxon price unitAnh Thao Pham (pta)
- Create a product with Category configured with: * Costing Method: First In First Out (FIFO) * Inventory Valuation: Automated - Create a PO to buy 2 units at $100 (PO1) and receive the products - Create a SO to sell 2 units (SO1) and deliver the products => COGS of SO1 should be $200 ($100 * 2) - Return 1 unit from previous delivery => COGS of SO1 should be $100 - Create a SO to sell 1 unit (SO2) and deliver product => COGS of SO2 is $100 - Create a PO to buy 1 unit at $200 (PO2) and receive the product - Re-deliver the returned unit from SO1 => COGS of SO1 should be $300 ($100 + $200) - Create invoice for SO1 and post it The journal items (account.move.line) corresponding to the COGS have an incorrect value: $200 ($100 + $100), instead of $300 ($100 + $200) The issue comes from the method computing the anglo saxon price unit. It does not take into account quantities from stock moves that have been returned. This commit computes the number of units that have been returned for each stock moves used to compute the anglo saxon price unit and to take the result into account during the computation (of the anglo saxon price unit). opw-2501260 closes odoo/odoo#71317 X-original-commit: 4d3147a0b123ab591c1ca03a2ee86479992424d8 Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com> Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
2021-05-11[FIX] crm_livechat: do not set public user partner as lead customer usign ↵Florent de Labarre
/lead command Before this commit, when you create a lead from livechat with the command /lead, the public user is used inside the lead. Because the public user is archived, and self.env.ref('base.public_partner').user_ids return an empty recordset. closes odoo/odoo#70655 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-05-27[FIX] website: remove non-fictional number from templatesnie
Steps: - Go to Website - Click "Go to Website" Bug: The default phone number on the website is not fictional and may cause unwanted spam. Explanation: In North America, only 555-0100 through 555-0199 are specifically reserved for fictional use. > The industry also reserved a block of 100 numbers as fictitious, > non-working numbers (555-0100 through 0199) for use by the > entertainment and advertising industries. Source: https://www.nationalnanpa.com/pdf/NRUF/ATIS-0300115.pdf opw:2530388 closes odoo/odoo#71311 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2021-05-26[FIX] mrp: use work center's TZ to plan operationsAdrien Widart
When planning a Manufacturing Order, if an operation takes place in work center with a different time zone, the computed date may be incorrect (the start date may be outside the working hours) To reproduce the error: (Use demo data. Current timezone: Europe/Brussels) 1. In Settings, enable "Work Orders" 2. Open an existing Work Center 3. Click on "Standard 40 hours/week" 4. Set Timezone to "Asia/Bangkok" - Note that all slots are between 8:00-12:00 and 13:00-17:00 5. Create two storable products P_compo and P_finished 6. Create a Bill of Materials BM: - Product: P_finished - BoM Type: Manufacture this product - Components: 1 x P_compo - Operations: 3 x Operation with existing work centers 7. Create a Manufacturing Order: - Bill of Material: BM - Quantity: 100 8. Save, Confirm, Plan Error: (it depends on the time the test is done) The 'Scheduled Start Date' of the second operation is incorrect. Adding the time zone difference gives a time that is outside the work center's timetable (i.e., outside 8:00-12:00 and 13:00-17:00). The computations do not consider the time zone of the work center. OPW-2393330 closes odoo/odoo#70841 Related: odoo/enterprise#18524 Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
2021-05-25[FIX] account: set default_partner_id to bank_partner_id for partner_bank_idjbw
Change “default_partner_id” from “commercial_partner_id” to “bank_partner_id” for “partner_bank_id” field in from view. If not, on an invoice, a newly created partner bank (via “Recipient Bank” field) would be created for the partner instead of the current company. closes odoo/odoo#71213 Task: 2524441 Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2021-05-26[FIX] point_of_sale: Fix down/up roundingRobin Heinz
While using the cash rounding, there were issues when rounding up and down. The pre filled amount was correct but the rest of the transaction was wrong. (Wrong due, wrong change,...) This commit re calculate the rounding applied when using up or down payment. closes odoo/odoo#71219 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-05-18[FIX] portal: fix copyright color on the portalYounn Olivier
Before this commit, for default colors, the text-muted class color was set as !important from the portal and could not be overriden by the website, leading to inconsistent display between the website and the portal for the copyright. As a fix for stable, we do not change the text-muted color from the portal when using default colors. task-2468472 closes odoo/odoo#70538 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2021-05-26[FIX] point_of_sale: Load all existing Payment Method but displayed linked onesRobin Heinz
Before, when using the manage order, if a payment method was used and then removed from the pos.config, we couldn't load the old order anymore because of unknow reference. To fix this, we load all methods at the opening of the pos but when we display the payment methods we only show those in the pos.config. closes odoo/odoo#71263 Task-id: 2541708 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-05-26[FIX] mrp: use correct UoM for each component in MOAdrien Widart
In a Manufacturing Order, the components' quantities are rounded using the rounding precision of the produced product's UoM. This leads to incorrect values. To reproduce the error: 1. In Settings, enable "Units of Measure" 2. In UoM, edit Units: - Rounding Precision: 1 3. Create two products P_finished and P_compo - P_compo's Product Type: Consumable - P_compo's UoM: L - P_finished's UoM: Units 4. Create a Bill of Materials - Product: P_finished - 1 Component: - Product: P_compo - Quantity: 0.2 - UoM: L 5. Create a Manufacturing Order: - Product: P_finished 6. Confirm, Mark as Done Error: Qty to consumes became 0 and consumed qty is 0. Both values should be 0.2L, but they have been rounded using the rounding precision of Units OPW-2529462 closes odoo/odoo#71146 Signed-off-by: Steve Van Essche <svs-odoo@users.noreply.github.com>
2021-05-25[FIX] point_of_sale: show pack lot input popup when scanning productJoseph Caburnay
When scanned product is tracked by lot or SN, the popup that asks for lot should be shown, just like as when a tracked product is clicked from the product list. We accomplish this by introducing a new method that can be used both by `_clickProduct` and `_barcodeProductAction`, and by making the `_barcodeProductAction` be independent from `scan_product` method from `PosModel`. So instead of calling directly `scan_product`, we indentify the product first based on the barcode, then we call the newly introduced method to ask for the lot inputs, then we call `add_product` with proper options including the type of the parsed barcode. closes odoo/odoo#71209 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-05-25[FIX] point_of_sale: compare the quantity to number typeJoseph Caburnay
When identifying whether to show the decrease quantity popup or not, the current quantity of the selected orderline is compared to the new input quantity. This fix properly compares the current quantity to the new input quantity in number format.
2021-05-25[FIX] point_of_sale: dot input should be recognized even at different langJoseph Caburnay
Language such as FR recognizes `,` as the decimal separator. However, it is possible that the keyboard setting is American so the decimal point in the numpad will send `.` when pressing it. POS should be able to recognize both. This fix allows `.` sent from keyboard to be interpreted as decimal separator even at language where the decimal separator is `,`. This is okay because number inputs in POS doesn't take into account the thousand separator.
2021-05-26[FIX] mail,test_mass_mailing: unblacklist with mass mailingNicolas Lempereur
The optimization 2ccf0bd0dc does not take into account that to "unblacklist" a user, you have the archive the mail.blacklist record so only mail.blacklist active records need to be taken into account. Added test without the fix fails with: AssertionError: False is not true : MailTrace: email test.record.02@test.example.com (recipient res.partner(), state: sent, record: mailing.test.blacklist(166,)): found 0 records (1 expected) opw-2536304 closes odoo/odoo#71239 X-original-commit: 8ffd82249728b79959cfa61490730991a2b339d6 Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2021-05-26[FIX] stock: fix check of package all in move linesGuewen Baconnier
The `groupby` function is used to builds groups of(product, lot) keys and their corresponding move lines / quants. `groupby` groups *consecutive* keys, which is why the input is sorted by the keys. `sorted` on recordsets keys will not sort as we would expect in this particular situation, as the comparison operators on records act as Set Comparison operators on the record ids, i.e. to compare the sets superset/subset relationships: ``` >>> env["product.product"].browse(1) < env["product.product"].browse(2) False >>> env["product.product"].browse(1) < env["product.product"].browse([1, 2]) True ``` Example of sorted on stock.move.line records, where the product id 7313 is both in the slots 4 and 12 instead of being consecutive: ``` >>> [l.product_id.id for l in sorted(lines, key=itemgetter('product_id'))] [7436, 7437, 7352, 7423, 7313, 7351, 7423, 7424, 7320, 7398, 7312, 7352, 7313, 7436, 7437, 7442, 7443, 7320, 7423, 7424, 7318, 7396, 7368, 7355, 7316] ``` Now when we group by id the 2 ids 7313 are correctly placed together in slots 1 and 2: ``` >>> [l.product_id.id for l in sorted(lines, key=attrgetter('product_id.id'))] [7312, 7313, 7313, 7316, 7318, 7320, 7320, 7351, 7352, 7352, 7355, 7368, 7396, 7398, 7423, 7423, 7423, 7424, 7424, 7436, 7436, 7437, 7437, 7442, 7443] ``` This commit aims to sort by "id" of the related records, to ensure the same (product, lot) couples are consecutive. closes odoo/odoo#71126 X-original-commit: 3317249dd88c97f96e8130d3d67a33a1075e0748 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2021-05-25[FIX] l10n_cl: module categorywan
Localization modules need to be `Accounting/Localizations/Account Charts` Because this will install `l10n_generic_coa` otherwise https://github.com/odoo/odoo/blob/36a9e761c8d6c1c6e9611cc410ecca82ff2b1659/addons/account/__init__.py#L28 closes odoo/odoo#71202 Signed-off-by: Josse Colpaert <jco@openerp.com>
2021-05-26[REV] mail: fix a traceback when sending a message in a "email channel"std-odoo
Bug === Since 4da64b3f3c8dff88d8e0e01c65374590cc0bf4f7 , if multiple users of different companies are in the same channel, and if the type of the channel is "email", a traceback is raised when sending a message. Technical ========= "with_user" drop the SU flag and is not enough to bypass the multi company ACLs. Moreover, we do not want to send a "channel_seen" bus notifications and we can mark the message as seen on the JS side directly. Changes ======= So now, the traceback is not raised anymore in that case, and the message is marked as seen if the receiver has the web client open. But, if the receiver has not the web client open, when he will login, the message will not be marked as seen. This can be improved but at the moment we just want to revert the fix that cause the traceback and fix the issue in most cases. Task 2427790 closes odoo/odoo#65185 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-05-21[FIX] mail: chat window should remain folded on new messageDhruv Patel
If the chat window was initially folded and when a new message is received the chat window automatically unfolds. it is annoying having a window that pops up each time a new message is coming while having folded it once. So, It should remain folded when a new message is received if the chat window is already folded. Task : 2522141 closes odoo/odoo#70737 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2021-05-11[FIX] survey: display right date format in datepickerNasreddin (bon)
Issue - Install 'Survey' & 'website' module - Enable "es_VE" language and activate on main website - Go to Website Homepage - Switch to "Spanish (VE)" language (footer) - Go to "Survey" module - Create a survey: - Add a question of type 'Date' then save - Click on "TEST" button - Start survey and add a date with the datepicker - Submit survey Error message : 'This is not a date' Cause When submit survey, not using the database date format. Solution When validating form (on submit), check if date is formated with database format and (not the moment locale since user can alter date and datetime format). opw-2452237 closes odoo/odoo#70273 X-original-commit: ddfcecc6c3d013532d06409633a37e653cc05e0f Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
2021-05-25[FIX] l10n_in: decrease a value of B2CS and HSN in case of refundJigar Vaghela
Before this commit: B2CS is not decreased in case of refund but it's shown in CDNUR but CDNUR has a condition that only shows a refund of B2CL. HSN value is not decreased in case of refund After this commit: Refund is decreased from B2CS and not show that in CDNUR HSN value is decreased in case of refund B2CS = Business to Consumers Small B2CL = Business to Consumers Large (invoice value is more than Rs.2.5 lakhs) CDNUR = Credit/Debit Notes for Unregistered HSN = Harmonized System of Nomenclature(hsn code per product) closes odoo/odoo#71170 Opw: 2446769 X-original-commit: 93d64e2e439fc6b64ce17740e85653f66e5f06b5 Related: odoo/enterprise#18467 Signed-off-by: Josse Colpaert <jco@openerp.com> Signed-off-by: Jigar Vaghela <jva-odoo@users.noreply.github.com>
2021-05-22[FIX] l10n_fr_pos_cert: hash doesn't appear in ticket during reprintFlorent de Labarre
- Create a pos order, pay and valide - Close Pos - reopen pos - search this order - click print ticket --> Issue the hash doesn't appear on the ticket closes odoo/odoo#71172 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2021-05-17[FIX] mail: prevent useless writeFlorent de Labarre
In database with frontend and live chat there are lot of bad query error. bad query: UPDATE "mail_channel_partner" SET "write_uid"=5,"write_date"=(now() at time zone 'UTC') WHERE id IN (328111) closes odoo/odoo#70506 Error: Could not serialize access due to concurrent update Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-05-23[I18N] Update translation terms from TransifexOdoo Translation Bot
2021-05-21[FIX] sale, mass_mailing_sms, test_mail_full: correctly support partner-only ↵Thibault Delavallée
records When performing an sms marketing on a model having only a ``partner_id`` field available (aka no ``phone`` or ``mobile``) it crashes due to seen list computation (aka already contacted recipients). This is due to an SQL query not taking into account those models as it works only for those with a phone field. We fix it as done in ``mass_mailìng`` app, aka fetching information on the related partner if available. Some tests for models using a 2many relationships towards recipients are added. Note that this kind of model does not really support complete SMS notification, as only the first found partner is notified. Mass SMS on this kind of model is currently not possible as seen list is not supported. There is no standard use case of this in Odoo codebase. Correctly support sms marketing on sale model by defining the necessary methods. As sale order has only a partner_id field available we have to correctly override phone related methods for SMS. LINKS Task ID-2431217 COM PR odoo/odoo#71140 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-05-21[IMP] test_mail_full: add test for SMS mailing default domain and optoutThibault Delavallée
Purpose is to test specific behavior of opt-out for SMS marketing. This is currently not tested and working a bit strangely, as they are flagged as blacklist. This will soon be updated in another task but at least current behavior is logged somewhere. We also update some test models in order to reflect potential strange and non-default behavior, notably partner_id field used as contact field. It will be used soon when cleaning some opt-out behavior. Tests are added to check phone sanitized is correctly taken into account in default domains when inheriting from the phone blacklist mixin. Some counters notes are also updated next to some last updates. Task ID-2431217 COM PR odoo/odoo#71140
2021-05-21[FIX] mass_mailing: correctly update list subscriptions when updating contactsThibault Delavallée
There is a missing depends on subscription_ids fields, meaning it is not correctly refreshed when contacts are updated. When dealing with m2m using the o2m model as relational table, depends have to be specified on field itself to allow recomputing the fields. Task ID-2431217 COM PR odoo/odoo#71140
2021-05-18[FIX] web, website: display default company name on frontend layoutYounn Olivier
Before, the "Company name" placeholder was hardcoded in the frontend layout template, and the user had to change it with his company name from the website view, which was not user-friendly if the website module was not installed. Now, by default, the frontend layout template displays the user's company name. If the website module is installed, it is editable. task-2468472 closes odoo/odoo#69943 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2021-05-21[FIX] event_sale: ticket price with pricelistnie
Steps: - Install Events - Go to Events / Configuration / Settings - Enable Tickets - Go to Sales / Configuration / Settings - Enable Multiple Sales Prices per Product - Go to Sales / Products - Edit Event Registration - Sales tab - Pricing - Pricelist: Public Pricelist (USD) - Price: $6 - Go to Sales - Create a new quotation - Pricelist: Public Pricelist (USD) - Product: Event Registration - Event: Design Fair - Ticket: VIP Bug: The pricelist is not taken into account. Unit price should be $900 but is $1500. Explanation: The original issue comes from this commit: https://github.com/odoo/odoo/commit/379f1490c93dc599a74add2d678c18fbba1efa62 The advertised amount was not the one showing up in the cart. This is because the pricelist was not taken into account anymore when entering the payment process. Using `price_reduce` instead of `price` enables all kinds of discounts on the final price. However, `price_reduce` relies on the context to find the current pricelist. This commit adds the context needed to compute the price of the tickets. This context is the same as the one in the sales module since pricelists are working fine there: https://github.com/odoo/odoo/blob/b208570ce8399bc6d3e4a8ba02eef6558e0a6ccc/addons/sale/models/sale.py#L1494 The currency conversion is done in `product.price`. It's therefore already done when calling `price_reduce`. opw:2519453 closes odoo/odoo#71114 X-original-commit: e92282f712d485ca97feb8a729abe3b975183451 Signed-off-by: backspac <backspac@users.noreply.github.com>
2021-05-21[FIX] l10n_it_edi: Vendor bill is not being created from PECPaolo (pgi)
When one or more vendor bills in Italian e-invoice format were sent to the registered PEC mailbox, if they are in the PKCS#7 format ('.xml.p7m'), nothing happened. The e-invoice content should be automatically decoded and the invoice should be created as soon as the xml file is fetched from the PEC mailbox. A new remove_signature function has been added in a tools/remove_signature.py file to handle this case. The OpenSSL and pyOpenSSL libraries must be installed. They are not in requirements.txt but they're probably available. New tests has been provided for the signed email reading method. opw-2460485 closes odoo/odoo#71138 Signed-off-by: Josse Colpaert <jco@openerp.com>