| Age | Commit message (Collapse) | Author |
|
|
|
Before this commit, when duplicating a task,
the pad of the original one was updated with plain text
Hence losing all the layout.
This was because, in all likelihood, Odoo's Etherpad server did not support pushing HTML
At the time of the commit, Odoo's pads can receive HTML.
We then push HTML by default, falling back to pushing text as before
if necessary
OPW 806064
|
|
The old code used Request(data=)]( https://github.com/odoo-dev/odoo/blob/723b083cf5e51beec166059350466e5504db46c9/addons/pad/py_etherpad/__init__.py#L39)
Which however means it did a POST:
> the HTTP request will be a POST instead of a GET when the data parameter is provided
yet the code currently uses `requests.get`, so [it looks very much like a mistake when converting from urllib to requests](https://github.com/odoo-dev/odoo/commit/01e35141479b8dfc4a390518f89fc52e7cec5396#diff-3303eb022ac36e1ef7258c28f24f6de6).
|
|
In Python 3, all of these were "consolidated" under urllib(.request,
.parse, .errors) which is inconvenient.
Since we already have hard dependencies on requests and
werkzeug(.urls, which is a backport of Python 3's unicode-aware
urllib.parse) migrate *everything* to that.
A sticking point is urllib2.URLError, those were (mostly) replaced by
the slightly more general IOError which URLError extends.
|
|
werkzeug's version, this one was useful to handle sequences
The API of werkzeug's version does not accept a boolean
as the second argument, so this crashes.
bzr revid: odo@openerp.com-20140218182643-a13mvcmsav195dfx
|
|
urliblib.encode does not accept unicode
bzr revid: dle@openerp.com-20140129121316-b5f5e4r6fz9l80kq
|
|
bzr revid: mat@openerp.com-20130514103113-8idhvhokt0e8jzea
|
|
bzr revid: chm@openerp.com-20120920105713-meckyb4pnlxbapzk
|