summaryrefslogtreecommitdiff
path: root/addons/gamification/security
AgeCommit message (Collapse)Author
2020-03-20[IMP] *: declare ir.rule in noupdateVictor Feyens
ir.rule are default values but can be customized based on the company's policy and needs. This is typically a record that is in noupdate as should be customization-friendly.
2020-03-20[IMP] *: remove global field definition in ir rules xmlVictor Feyens
It is a computed field, there is no need to manually set its value.
2020-02-04[ADD] *: add ir.model.access on all transient modelsMartin Trigaux
Following changes needing ir.model.access on transient models too. Remove groups declaration on the action to move it to ir.model.access when possible. Rules are strict by default with no unlink access by default and high priviledge asked. Adaptations may be needed later. Write access is given as a wizard may need to be modified in case the action triggers an error and the user has to correct a value account*: use account.group_account_user for all transient by default remove account.print.journal relic stock*: use stock.group_stock_user by default survey: survey user can send invitations mail: allow any employee to execute wizards additional verifications are made to ensure they are executed only on the documents the user has access to you give portal access to mail.compose.message as portal still does some actions like posting messages on the forum add ir.rule to avoid reading somebody else messages increase the query count because of undeterminist count crm: saleman for lead2opp, manager for massmailing partner manager for actions linked to partners avoid a write in test_lead_lost sms: any employee can send sms mrp: mrp user can execute wizards give unlink access as making write during do_produce operation base_import: employees can import files delivery: stock user can deliver event_sale: sale user can configure the wizards event user inherit from sale rights gamification: employee can give badge google_service: resolve FIXME hr: add specific rights manager can set a plan according to group on button anyone who can write on an employee can register a departure hr_expense: set rights based on buttons hr_holidays: an approver can make a summary report hr_recruitment: recruiter can refuse a candidate hr_timesheet: can use the wizard if can create a timesheet l10n_eu_service: managers can create fiscal positions mass_mailing: same group as on mass.mailing.list membership: accountant can create invoice from membership payment: accountant can create a link as the source is an account.move keep the payment.acquirer.onboarding.wizard to system user only as it is called during company configuration point_of_sale: PoS manager only can use wizards never create closing_balance_confirm_wizard records product_expiry: stock user has rights on stock.picking product_margin: access from accounting menus repair: same rules as for above models sale: set ir.rule for self wizard only add rule from model introduced in payment to add salesman group sale_crm: saleman can create a quotation from a lead sale_coupon: any saleman can generate coupon add self ir.rule sale_product_configurator: salesman can select product variants snailmail: employee can send letters website: designers can write on website website_crm_partner_assign: same rule as group on action website_sale: sale ACL as for payment.acquirer.onboarding.wizard website_slides: anyone can send invitation base: base.language.*: allow employee (cf lang_install) change.password.user: can not read change password wizard of other users test.*: no access is needed Courtesy of Damien Bouvy, William Andre and Antoine Prieëls for review of acl
2019-11-05[IMP] gamification: track karma change on usersPatrick Hoste
PURPOSE Allow karma gain tracking enabling notably display of top users based on weekly / monthly gain in website profile. SPECIFCIATIONS Each time a user gains karma a record is created in the gamification karma tracking model. Scheduled activity runs to consolidate the records into monthly gain records to avoid having crowdy table and unnecessary noise in karma gain. This model is made private and only accessible through some dedicated compute methods / controllers used in website profile. In website profile module buttons are added to see users ranking based on their total karma (like before) but also by last week and last month gains (using the newly introduced tracking model). LINKS Task ID 2003505 PR #34594
2019-05-13[IMP] base: Contextualize the multi companyYannick Tivisse
Purpose ======= Allow the user to select the allowed companies for which he wants to see records on top of selecting his current company. It is confusing for users to see the records from the company he is connected to and the records of the children companies. Instead of using the hierarchy of companies to access records across companies, the user can now select (from his set of allowed companies) the companies for which he wants to access records. /!\ This means that the user will interact with records from company A when in company B. Example: a SO has been created and confirmed in A. When in B, I create the invoice from it. Specifications ============== 1/ Deprecate the parent/children hierarchy on the res.company model. The fields are kept on the res.company model to ensure the retro-compatibility, but won't be used accross the standard code anymore. The only functional usage for this mechanism was to allow to see records from several companies by creating a virtual parent company, which will be possible with the new mechanism. 2/ By default, a user will only see the records of the company he is connected to (or records without a company). (It is still editable by the user if needed). For that, put this information in the user context, to allow having different configurations on different browser tabs. Instead of having domains like ['|', ('company_id', '=', False), ('company_id', 'child_of', user.company_id.id)] you'll have something like ['|', ('company_id', '=', False), ('company_id', 'in', company_ids)] Note that the 'company_ids' is a value that is passed in the evaluation context on the record rule, as we already have user, or time. company_ids is a list of the ids of all the enabled companies in the user's context. 3/ Out of the generic improvements brought by this task, this will illustrate issues that could exist since several versions. For example, it should not be possible to create a scrap order for the company A with a package of the company B, or it should not be possible to create an invoice on the company A with payment terms from the company B. Before the version 12.0, it was easy to encounter this kind of issues as the admin was the SUPERUSER_ID. A positive side effect of the fact that the SUPERUSER_ID has become an inactive user was to make it more difficult to introduce mismatch on the records, but haven't solved the issue, as it was still possible to do it with parent companies configuration. Some of these issues have been fixed in this commit, but all the business flows should be re-tested to check if an ir.rule should be introduced (eg: a multi company rule for stock.quand.package), if the company of a record is correctly transfered to another record created from the first record (eg: From a SO, create an invoice and a payment, the company of the sales order should be transfered on the invoice and the payment, even if the company of the sales order is A and I'm logged into the company B with the company A enabled. 4/ Currently, if I click on a button on a notification email (example 'View Task'), I face a traceback if I'm not logged into the company of the record. Now, if you click on a button and if you have access to the record, the correct company will be automatically set. 5/ If I display a kanban view with several records from several companies (and an image), all the images should be displayed. 6/ Currently if you copy paste an url, this will crash if you're not in the correct company. This won't be fixed because it's quite impossible to do it in a clean way. This task brings a workaround. Copy/Paste -> Traceback -> Log into the correct company, re-copy/paste -> Ok. 7/ 2 property methods have been added on the environment to retrieve the company on which the user is logged in and the companies the user enabled, on a specific tab. That way, when creating a record, instead of doing default=lambda self: self.env.user.company_id do default=lambda self: self.env.company_id On the other hand, to retrieve the enabled companies, do companies = self.env.company_ids 8/ Modify the Company Switcher widget to allow to log into another company WITHOUT writing on the res.users (and thus bringing cache invalidation issues and so on). Also allow to enable several companies and see records from several companies, and independantly of the other browser's tabs. 9/ When focusing on a tab, save the current company configuration on the local storage. That way, when doing 'CTRL+T' or a middle click, the context is propagated to the new tab. 10/ Improve the error message in case of multi company access errors. Now, when the user is in debug mode, display the related names of the records and the name of the user who brings the issue. 11/ Remove the context erasing when writing on a res.users This is probably coming from the migration to new API of the base module. The context was not propagated at this moment, which was a common mistake at that time. When migrating the module, probably by using the 'black box' method, as the context was not propagated, it was erased on the new version. This is now an issue because the context (i.e. the enabled companies) was erased when writing on a res.users, leading to tracebacks. See: https://github.com/odoo/odoo/commit/7eab8e26d3d46c53f4be924d6a34e80a66e74960#diff-4c2e738ee8f64f11806c889ea097b5e7R624 12/ Fix the crash manager on redirect warnings. The issue is the following - Create an invoice on a company without a configured CoA. - Set a partner - On the onchange_partner_id, a redirect warning is raised to propose you to configure a CoA - Click on 'Go to the configuration panel' - A generic warning says something like 'Do you want to discard your changes?' - Click on yes, the page refreshes, but not on the redirect action. Now, set correctly the action on the hash, and reload instead. The breadcrumb is lost for example, but you reach the correct action at least. 13/ Introduce a res.group to enable/disable the multi company per tab feature. 14/ To help the users to know which tab is in which company, add the possibility to have a favicon per company. When creating a company, the classical 'O' icon is colored by default in a random color. 15/ Remove the company switcher on the frontend. This was mainly there to allow a user to swicth to the company linked to the website. This behavior is now transparent to the user. If the website A is activated, then the company set on the context is the company of the website. 16/ Deprecated the _company_default_get method on the res.company model. Remove the method _get_company on the res.users model. 17/ Add 'allowed_company_ids' and 'current_company_id' on the pyeval context. You can now use those variables on domains in the views to access directly to the activated company.ies on the current tab. TaskID: 1960971 closes odoo/odoo#32341 Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-02-07[IMP] gamification : add ranks based on karmaDavid Beguin
To encourage forum and slides users to be more active ranks are now added. They are directly linked to karma. The more the user has karma the more his rank will be high. The default rank is Newbie, with 1 point of karma. Users with 0 karma are considered as inactive on forum or slides. When a user reach a new rank a mail is sent to him to congratulate him with his new rank. To add a button in the mail template to allow users to go directly on a website section (like forum or slides) simply override get_gamification_redirection_data to add the target url. Partial commit linked to eLearning project. Main specifications related to gamification and user profile can be found on task 1922159 (PR #30514). Main specifications related to eLearning can be found on task 1902304 (PR #29876).
2017-03-23[REM] portal_gamification: kill the moduleJérome Maes
The goal is to prepare the removal of 'portal' module. Since this module only provides access rules and rights, those ones are moved directly into its parent module (aka gamification). Since no module depends on it, we can remove it without problem.
2016-09-02[FIX] gamification: remove duplicated manager groupsMartin Trigaux
hr_gamification should be adding hr groups to the security of gamification. Creating the group base.group_hr_manager in gamification in case hr is not installed is confusing and redundant with existing manager groups.
2016-08-05[MIG] gamification: Migrate to new APIXavier Morel
Includes compatibility-change to website_forum: a selection(callable) converted to a Selection(list) since that can easily be extended in the new API.
2015-08-12[IMP] gamification: groups and config udpateGaurav Panchal
Clean access, groups and categories in gamification. Remove custom goal_category aka Gamification category. As gamification is mostly integrated in HR, use HR categories. Remove custom group_goal_manager group, replaced by HR manager. Gamification groups and configuration is therefore linked to HR now. Updated access rights accordingly.
2014-05-12[FIX] gamification: correct name of ir.rule fixing bad copy-pasteMartin Trigaux
bzr revid: mat@openerp.com-20140512085041-b0euexzgxgvb30oe
2014-04-16[FIX] gamification: add security rule for multicompany (avoid getting error ↵Martin Trigaux
messages on home page when displaying top 3 goals) bzr revid: mat@openerp.com-20140416130924-8pyuejefcu7hnzmf
2013-12-17[REF] gamificationMartin Trigaux
bzr revid: mat@openerp.com-20131217170232-e0zruxzl1wlycaji
2013-12-17[REF] gamification: pretty much changing half of the code to make tde happy...Martin Trigaux
bzr revid: mat@openerp.com-20131217161541-oxsgy7gmko2x6qui
2013-12-16[IMP] gamification: add portal_gamification module to add security rulesMartin Trigaux
bzr revid: mat@openerp.com-20131216150726-su27319fvvxevam6
2013-12-12[FIX] gamification: no, actually make record rule for every user, will ↵Martin Trigaux
handle portal later bzr revid: mat@openerp.com-20131212115524-u25hz4xjj9l8gatb
2013-12-12[FIX] gamification: make record rule global and not for employees onlyMartin Trigaux
bzr revid: mat@openerp.com-20131212113639-lg2w2pm1mldbqe7a
2013-04-24[IMP] better security rulesMartin Trigaux
bzr revid: mat@openerp.com-20130424081216-cjyq0edrht6r0j1v
2013-04-15[FIX] avoid warning for anonymousMartin Trigaux
bzr revid: mat@openerp.com-20130415144455-w2jl8lxh0pdd6fo1
2013-04-12[IMP] gamification officer rulesMartin Trigaux
bzr revid: mat@openerp.com-20130412092603-aotk0y53snjz9c9i
2013-04-10[IMP] fixing and UIMartin Trigaux
bzr revid: mat@openerp.com-20130410101454-nkt8mbt8qb13zrge
2013-04-08[IMP] better UIMartin Trigaux
bzr revid: mat@openerp.com-20130408141132-or43mhdl8d5ds7xb
2013-04-08[IMP] security rulesMartin Trigaux
bzr revid: mat@openerp.com-20130408101940-syg67y7nx3hw12gg
2013-04-05[IMP] better security rulesMartin Trigaux
bzr revid: mat@openerp.com-20130405073205-gfcolcdv3oomlo0z
2013-04-04[REF] cleaning codeMartin Trigaux
bzr revid: mat@openerp.com-20130404152359-3x3gt9xhkrkr0au4
2013-03-29[ADD] autostart discover planMartin Trigaux
bzr revid: mat@openerp.com-20130329163137-l6e45b0qj89yfm5c
2013-03-29[FIX] users shouldn't be able to write to badgesMartin Trigaux
bzr revid: mat@openerp.com-20130329095932-gc58i4q2j32vpcxy
2013-03-29[FIX] no warning message for anonymousMartin Trigaux
bzr revid: mat@openerp.com-20130329082627-cp3iolafolqxsosu
2013-03-19[FIX] every employee is a goal_userMartin Trigaux
bzr revid: mat@openerp.com-20130319100035-le3qkcbi35lf95r5
2013-03-14[IMP] small changesMartin Trigaux
bzr revid: mat@openerp.com-20130314142439-04espxwt7049xzz5
2013-03-14[IMP] remove useless rule auth and better domainMartin Trigaux
bzr revid: mat@openerp.com-20130314120157-ac8nygcm2p11xu48
2013-03-14[ADD] add security rule for badgesMartin Trigaux
bzr revid: mat@openerp.com-20130314110529-pl65an41ds08sazb
2013-03-13[ADD] badge menu and related security rulesMartin Trigaux
bzr revid: mat@openerp.com-20130313110225-bjxs9rn3shux9rqh
2013-03-13[ADD] gamification: security rulesMartin Trigaux
bzr revid: mat@openerp.com-20130313095154-b5wi1ohu0wo6hz5w