| Age | Commit message (Collapse) | Author |
|
|
|
|
|
|
|
|
|
Steps to follow to reproduce the bug:
- Create a new “Internal User”
- Add him a “default company”
- Add in the “allowed companies” a different company than his default company
- In the “Technical” section, check that the “multi companies” box is checked
- Log in with the new user
- At the top right select a company other than his “default company”
- In the “Calendar” app/ create a new meeting with a future date
- Add another user as a participant
- Confirm the meeting
- Access rights error is triggered
Problem:
When participant are added, an invitation by email must be sent to all participants.
The problem is in the template of the email that is sent, precisely in the "body", we add the name of the user's default company which we do not have access.
Opw-2494399
closes odoo/odoo#69935
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
|
|
|
|
|
Improve calendar recurrency creation performances by moving the call to
super().create out of the for loop. For a client database with 120
recurrences creating around 50k calendar events in total, the 5 times
averaged execution time went from 1410s to 630s, so a speed up slightly
bigger than 2.
|
|
When creating a recurrent event, an SQL contraint requires the field
`day` to be correcly defined. However, if the recurrence rule is like
"every last Monday of the month", the field becomes useless and may be
undefined. As a result, the SQL constraint will prevent the creation of
such a recurrent event.
For example, the situation will happen when the user creates this
recurrent event on Microsoft Calendar and then tries to sync with Odoo.
The recurrent event data will contain:
```python
{
'rrule_type': 'monthly',
'day': 0,
'byday': '2',
'month_by': 'day',
'weekday': 'TU',
# ...
}
```
OPW-2439814
closes odoo/odoo#69106
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
|
|
|
|
|
|
|
|
|
|
|
|
Context
-------
in the module website_calendar, the controller create
an event with alarm with the Public user and the company of the public
user
and set partner_ids that may belong to a different company
Issue
-----
The company of the user that create the event remains in the context
and _notify_next_alarm check for each user which event should be notify
using with user of the partner that may be notified and check the access
rules to filter the event the partner should actually see.
The check of the acces rules need env.companies that remains the company
of the user that create the event which the current user may not see
which trigger the following error.
"Access to unauthorized or invalid companies."
Solution
--------
Wipe the company in the context when calling get_next_notif
closes odoo/odoo#66933
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
|
|
|
unit test
Issue
- Install 'Calendar' module
- Create new event from Calendar view
- Edit event
- Set True to 'Recurrent' in options tab
- Repeat every 2 weeks
- Until : Number of repetitions 2
- Save and go back to calendar view
- Events are shifted (+ 1 week)
Cause
The rrule.rrule (who create the generator with the recurrence ranges dates) use
by default `calendar.firstweekday()` as first week day ('wkst').
Solution
If recurrence frequency is 'weekly', get first week day based on user language,
and add it as param ('wkst') to the rrule.rrule.
https://dateutil.readthedocs.io/en/stable/rrule.html#classes
opw-2448325
closes odoo/odoo#66265
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Co-authored-by: LucasLefevre (lul) <lul@odoo.com>
|
|
|
|
|
|
|
|
Issue
- Install calendar
- Go to calendar and set 'week' view
- Go to first week of the year
- Add a 'Full Day' event
- Add an event of 'few hours'
- Click on filters -> Date -> Q1
Only 'Full Day' events remains displayed.
Cause
'start_date' is used to in the 'Date' filter
and this field is set only on 'Full Day' events.
Solution
Use 'start' field instead since always set.
opw-2439460
closes odoo/odoo#64992
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
|
|
|
|
|
|
|
|
to attendees
When emails related to calendar events are sent email_from is set from
templates like invite template. Author of those email is however not set
and current user is used as default value.
In this commit we do as done in templates and try to set event responsible
as user, and fall back on current user if not set.
This notably solves an issue when using website_calendar. Appointments are
done using public user and mails have public user as author. This leads to
emails not being accessible or having a false email_from.
Task ID-2413792
closes odoo/odoo#64027
X-original-commit: odoo/odoo@160d321
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
|
|
|
|
|
|
|
STEPS:
* Update cron "Calendar: Event Reminder": set Execute every 2 minutes
* create a recurring event:
* date: now() - 8 weeks
* time: now() + 1 hour + 3 minutes
* Repeat every 1 week, until "now() + 8 weeks"
* Reminders: "Notification-1 hour", "Email-1 hour", "SMS-1 hour"
* wait 3 minutes
* Wait 0-5 minutes
* Check menu ``[[ Settings ]] >> Technical >> Discuss >> Messages``
* Check menu ``[[ Settings ]] >> Technical >> Phone / SMS >> SMS``
BEFORE: you get mail/sms/UI notifications for all passed dates
AFTER: you get mail/sms/UI notifications only for the comming event
WHY: in v13.0-, recurring calendar.event records were virtual, so
_get_occurrences was used to generate those virtual records. In Odoo v14+ it's not needed
---
opw-2389877
closes odoo/odoo#62701
Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>
|
|
|
|
Before this commit, a notification was sent to all the attendees
whenever a past event was modified.
Now the notification is only sent if the event is taking place in the
future.
closes odoo/odoo#62584
Taskid: 2409394
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
|
|
When we try 'My Meetings' filter in the Calendar module,
it can't filter out the meetings that the user is attending.
Steps to reproduce:
go to calendar > list view > filters > my meetings
Previously the filter was worked based on context `mymeetings`
on search_read but during the refactoring of the calendar that
is removed.
So in this commit, add domain based on user_ids to filter the
my meetings.
closes odoo/odoo#62524
Taskid: 2389382
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
|
|
|
|
Issue
- Install "Calendar" and "Studio" modules
- Go to Calendar app an open any event
- Switch to Studio mode
- Add a selection field X in the form then close Studio
- Go to list view and try group by X
Error message : "Grouping by X is not allowed."
Cause
`_get_public_fields` does not get custom fields created with studio.
Solution
Add custom fields to public fields.
opw-2402667
closes odoo/odoo#62617
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
|
|
|
|
What are the steps to reproduce your issue ?
1. Install "google_calendar"
2. Log in with "admin"
3. Create an eventX with "admin" and "demo" has attendees
4. Run "Google Calendar Synchronization" from "Scheduled Actions"
What is currently happening ?
eventX is successfully added to Google but without admin
if you sync Odoo to Google one more time, Google will overwrite eventX
and it will remove admin from attendees
What are you expecting to happen ?
Sync Odoo to Google and Google to Odoo without lost attendees
Why is this happening ?
Because there is a filter that prevent addition of current user to the attendees
How to fix the bug ?
Remove the filter
This reverts commit 287ee0f83ae6fd457e5356860c8a8ab5a4e66754.
opw-2382443
closes odoo/odoo#62406
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
|
|
|
Behavior prior to the commit:
- the accept link in the reminder email for a meeting has a parameter
`event_id`, instead of `id`, which causes an error 500 when the user
tries to accept the meeting
Behavior after the commit:
- the accept link uses the correct `id` parameter
opw-2366173
closes odoo/odoo#61983
Signed-off-by: Nicolas Galler <ngaller@users.noreply.github.com>
|
|
Courtesy of Transifex's translators for reporting bad/unclear sentences.
closes odoo/odoo#61785
Related: odoo/enterprise#14751
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
|
|
|
|
|
When the test starts after 00:00:00 UTC, the test fails.
closes odoo/odoo#60238
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
|
|
Except Spanish, waiting for cleanup
closes odoo/odoo#60848
Related: odoo/enterprise#14421
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
|
Behavior prior to the fix:
When accepting a meeting invite from the invitation email, if not logged
in, an Internal Server Error is received. Additionally, if already
logged in, an Internal Server Error is also received (albeit for a
different reason)
Behavior after the fix:
Accepting (or declining) the meeting invite works and shows the
accepted/declined meeting.
opw-2366173
closes odoo/odoo#60556
Related: odoo/enterprise#14359
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
|
The purpose of this commit is to have reliable calendar event reminder.
Before, the reminders was not send directly and was instead put in mailing
queue, which was leading to some delay. This is due do mail_notify_force_send
context key being force to False when being in cron mode. However here we
do not want to have calendar cron scheduling emails, then mailing cron
sending them as it implies two delays.
In order to try to send reminder mails as soon as possible compared to their
schedule let us send mails directly during the calendar cron.
Task ID-2331999
closes odoo/odoo#57994
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
|
Issue
- Install "Calender"
- Install "Google Calendar"
- Try to sync google in "Calendar"
Every created events will trigger the sending mail to attendees
even if the event date is past
Cause
'events' was not filtered
Solution
Filter 'events' to get all the events that have not yet happened
opw-2358123
closes odoo/odoo#60379
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
|
There was a problem in the Transifex translations for Spanish and all
translations were overwritten by mistake with english defaults.
This commit reverts all modified es.po files to their previous version
while we work to restore the translations on Transifex.
|
|
|
|
|
|
* mail,calendar,note
Before this commit:
When accessing activities from the systray, any existing breadcrumb-item should
be clearer.
After this commit:
Clear breadcrumb-item when access activities from the systray.
Task-2342246
closes odoo/odoo#59389
X-original-commit: 6dd181c789d22f99073fcd0a9b0fa2edccdfe0fc
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
|