summaryrefslogtreecommitdiff
path: root/addons/auth_password_policy/views/res_users.xml
AgeCommit message (Collapse)Author
2018-10-09[FIX] auth_password_policy: Cannot read property 'decorations' of undefinedAlexandre Kühn
Revision on https://github.com/odoo/odoo/commit/a47f6093f80cefa51c5a1bc1301db01007f97761 The commit above introduced a visual 'password strength' next to the password wizard in Settings > Users, when the module `auth_password_policy` is installed. However, there was an traceback when trying to access the 'General Settings' when some specific apps and modules were installed. This issue comes from the small design issue with the new PasswordField: it was designed as a field object that was instantiated and returned in the `init` function of an InputField with the password attribute set. This is not a solid design, because the documentation of the `init` function does not specify that it should return the newly instantiated object. As a result, the implementation was very fragile and only worked on FieldChar but not FieldText. This commit fixes the issue by turning the FieldPassword a field widget. As a result, the enabling of the password meter next to a password input has changed: Before this commit: ``` <field name="new_passwd" password="True" options="{'password_meter': True}"/> ``` With this commit: ``` <field name="new_passwd" password="True" widget="password_meter"/> ``` Closes #27440 closes odoo/odoo#27586
2018-10-02[ADD] auth_password_policy{_signup}: password strength widgetsXavier Morel
* generic strenght meter widget which can be included in various places * password field, taking over the isPassword special cases strewn throughout the codebase, this should probably become an actual thing in core /cc @ged-odoo, the meter is opt-in as most uses of `field[@password=True]` are passwords & secrets for third-party services or external servers for which a meter would not make sense * separate override of the ChangePassword wizard which isn't a regular view for some reason * direct implementation for signup pages (create user & reset password) Skip/comment/remove existing testing of @password fields: the policy replacement/augmentation needs to make an RPC call and does not support readonly use (because it doesn't seem to be used anywhere so that made sense?); and there currently is no way to augment or override/replace existing tests, so the tests will either fail when auth_password_policy is installed (current situation) or fail when auth_password_policy is not installed (if updated to be compatible with APP).