| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
When embedding to pdf, the name of the attached file should be 'factur-x.xml' (official specifications, section 6.2)
closes odoo/odoo#70293
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
raise an exception any more when creating a new invoice
Before this commit, when an attachment was present in the xml (pdf) and the import was to create a new invoice, it crashed when trying to post the pdf on the not-yet existant invoice.
This commit also fixes:
- In the tests, `create_invoice_from_file` didn't handle the subfolder parameter correctly
- `create_invoice_from_file` now returns the created invoice
closes odoo/odoo#69582
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
|
|
|
|
|
|
|
|
- don't show Electronic Invoicing field on account.move view if no EDI require web-service
Backport of https://github.com/odoo/odoo/pull/64493 (TASK ID: 2439258)
- don't show account_edi_format field on account_invoice_send
closes odoo/odoo#67049
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
When we want to send the invoice to the client, a hack was made in account_edi
to make sure that we put the XML of the electronic invoice formats as well, in
the case of web services such that the client has the XML we sent to the government.
For MX however, we also send the payment to the government. However when we wanted
to send the confirmation about the different changes, we still needed to add the XML
manually before this fix. Now it should be added manually even when manually composing
the mail to the customer with the payment receipt confirmation. (but we hope it dies)
closes odoo/odoo#66728
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
|
|
Before the introduction of account_edi_extended and blocking_level, if an edi.document was in error, it was retried each the time the edi.documents were processed. With account_edi_extended a bug was introduced and only the document not in error were processed. This commit aims to restore the previous behavior.
Also fixes tests of account_edi.
See https://github.com/odoo/odoo/commit/a9a46cf09b0c841c7fda95b5ed03033fc6936ca2
|
|
|
|
allows OCR to run automatically.
Before this commit, account_invoice_extract and account_edi where independent in parsing files uploaded or added as attachment in an invoice. Some tricks where used to avoid clash, but they were not perfect and some bugs appeared like the OCR not triggering automatically or an attachment being parsed twice by account_edi when parsing failed. The goal of this commit is to unify the import of files between the two features and ensure that they will not clash.
For more information about potential problems that appeared before :
See https://github.com/odoo/odoo/pull/61169
See https://github.com/odoo/enterprise/pull/15124/
closes odoo/odoo#65510
Related: odoo/enterprise#16138
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
- Some errors will never get fixed until user intervention, it doesn't make sense to run the CRON when there is such error.
+ some small improvements and esthetic changes
- When we are in a CRON, we need to commit the changes between each call to web-service to avoid loss of data.
- Small refactor of edi.document prepare_jobs and process_jobs
- Added an arbitrary key to create the batches.
|
|
processing EDI
- On account_edi_document, lock the documents successively instead of all at once.
- Lock account_move that should be cancelled. Before, cancelling the invoice after cancelling it on the web-service could fail.
- Lock ir_attachment that might be unlinked. Before, attachments that weren't attached to any model could become unreachable but still present in the database when an invoice was cancelled or a new attachment was produced.
closes odoo/odoo#64870
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
|
|
|
Steps:
- Install accounting
- On the dashboard, try to upload an "encrypted" PDF like this one https://launchpadlibrarian.net/24827090/DS-0157.pdf
Bug:
Traceback:
PyPDF2.utils.PdfReadError: file has not been decrypted
Explanation:
In 13.0, these errors were caught in a catch all `except` as shown here: https://github.com/odoo/odoo/blob/4e089041252c25cc197a30f9e285d82f7162d809/addons/account_facturx/models/account_move.py#L303-L328
From this SO comment: https://stackoverflow.com/questions/52047944/pdfbox-extracting-blanks-from-pdf-encrypted-with-no-password#comment91054285_52047944
> A PDF can be encrypted with two passwords: a user password and an owner password. When a PDF is encrypted with a user password, you can't open the document in a PDF viewer without entering that password. When a PDF is encrypted with an owner password only, everyone can open a PDF without that password, but some restrictions may be in place.
From time to time, we get a PDF encrypted with an owner password. The
content is still readable, but PyPDF2 fails because it thinks the PDF is
encrypted. With this fix, we try to unwrap the PDF by providing an empty
user password. This way, PyPDF2 thinks the content is now decrypted.
However, PyPDF2 only supports decrypting versions 1 and 2 of the
encryption implementation. If the version is different, we skip reading
the attachments and carry on to allow the user to upload the document.
opw:2375993
closes odoo/odoo#62557
Signed-off-by: backspac <backspac@users.noreply.github.com>
|
|
|
|
|
|
|
|
this is more safe way than previously applied in
https://github.com/odoo/odoo/pull/62939
because it doesn't require ``-u account_edi`` in cases when it worked
correctly, i.e. when _compute_edi_web_services_to_process is called, but
computes empty string value.
Additionally, it fixes same problem in account.payment model.
---
opw-2414500
closes odoo/odoo#63397
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
|
|
|
|
- Before the fix, the banner with the button would show when the move is posted or in creation mode even though no async edi is associated to this move.
closes odoo/odoo#62939
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
closes odoo/odoo#62838
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
When importing an xml in tests, if the import fails, the OCR will try to parse the file, which will cause an user access error. This polutes the logs and makes it hard to debug the code/test. With this commit a helper is added to create and invoice with OCR deactivated to be used to import the file.
closes odoo/odoo#62730
Related: odoo/enterprise#15124
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
closes odoo/odoo#62721
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
|
|
Courtesy of Transifex's translators for reporting bad/unclear sentences.
closes odoo/odoo#62539
Related: odoo/enterprise#15032
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
|
|
|
|
|
This commit will add a new group in the payment view with the list of
the edi documents for this payment. The group will only be visible in
debug mode. This is done to help the debugging and the error finding
when there is a problem with an edi document.
Related to 2e01da4713f9ee68813b248a8b88f367785fc937
closes odoo/odoo#61543
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
|
|
|
|
When creating an invoice from an attachment fails, we call super() which creates a new invoice and post the attachment to it without the `no_new_invoice` context key. This triggers an new import of the attachment.
closes odoo/odoo#61169
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
Except Spanish, waiting for cleanup
closes odoo/odoo#60848
Related: odoo/enterprise#14421
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
|
Allow having in an attachment as well as an error in the same document.
This will allow to see the document that generates the error, and easy
the process of debugging.
closes odoo/odoo#60163
Related: odoo/enterprise#14167
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
|
|
There was a problem in the Transifex translations for Spanish and all
translations were overwritten by mistake with english defaults.
This commit reverts all modified es.po files to their previous version
while we work to restore the translations on Transifex.
|
|
This commit will add a new tab in the account move view with the list of
the edi documents for this move. The tab will only be visible in debug
mod. This is done to help the debugging and the error finding when there
is a problem with an edi document.
closes odoo/odoo#60152
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
|
|
|
|
- account.edi.document require edi_format_id and move_id because it's its very own reason of existence
- account.edi.format require code because it's the way it's identified
closes odoo/odoo#60155
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
Determines whether user should be warned of all problems and also causes some correctable problems to be fatal. Since we just want the widest compatibility when reading PDF, strict=False seems acceptable.
TASK ID: 2358822
closes odoo/odoo#59731
X-original-commit: 9fb637577e0c13778e253b4f1329f59459ab0824
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: bfr-o <bfr-o@users.noreply.github.com>
|
|
|
|
|
|
|
