| Age | Commit message (Collapse) | Author |
|---|
|
The resequence wizard should consider that the sequence is shared for
invoices, journal entries and receipts; only refunds have a separate
sequence.
You could have journal entries in the purchase journal for expense
reports for instance. In that case, we want to be able to resequence all
of it at once.
closes odoo/odoo#68810
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
the tour
Steps to follow to reproduce the bug:
-In V14
-Go to accounting
-In the tour, click on Create First Bill
-Choose ‘Try a sample vendor bill’ and click on continue
-an error is triggered
Problem:
The returned value of ”create_invoice_from_attachment” method is treated as an “account.move” recordset, but it is a dict used for ‘ir.actions.act_window'
Solution:
We retrieve the ‘account.move’ from the ‘res_id’ found in the dict.
The issue was introduced by this commit : https://github.com/odoo/odoo/commit/8435d0e8990509ee67425977f970ab27bea8133a
opw-2469567
closes odoo/odoo#67573
Signed-off-by: William André (wan) <wan@odoo.com>
|
|
The current behavior was to set the label as memo in the payment register wizard.
However, this is to restrictive when a vendor bill hasn't any payment reference but a bill reference.
In that case, the user is expecting to have the bill 'ref' in the payment 'memo'.
Since the matching rules in the reconciliation widget are matching line.name, then line.move_id.ref and then line.move_id.name, the same logic is applied here to construct the payment 'memo'.
closes odoo/odoo#67997
Opw: 2440389
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
|
|
|
|
allows OCR to run automatically.
Before this commit, account_invoice_extract and account_edi where independent in parsing files uploaded or added as attachment in an invoice. Some tricks where used to avoid clash, but they were not perfect and some bugs appeared like the OCR not triggering automatically or an attachment being parsed twice by account_edi when parsing failed. The goal of this commit is to unify the import of files between the two features and ensure that they will not clash.
For more information about potential problems that appeared before :
See https://github.com/odoo/odoo/pull/61169
See https://github.com/odoo/enterprise/pull/15124/
closes odoo/odoo#65510
Related: odoo/enterprise#16138
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
- Go to Accounting > Configuration > Tax Report
- Create a Tax Report (with Lines having Tag Name)
- Go to Accounting > Accounting > Tax Adjustments
In wizard, no Report Line can be selected for mandatory "Report Line" field.
Report lines are filtered on "report_id" field, which is a related field to the report line field.
Therefore there is no way to select a Report Line.
opw-2449295
closes odoo/odoo#65393
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
closes odoo/odoo#65273
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
'percentage' is computed by default whatever the wizard action (change_period/change_account) but there is a constraint raised when the percentage is != 100 in change_account.
closes odoo/odoo#64736
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
Previously, in batch payments wizard, available payment methods where
always set to wizard.journal_id.outbound_payment_method_ids when
the batch length was > 1.
Event when the payment type was inbound and not outbound.
closes odoo/odoo#64562
Task: 2439250
Related: odoo/enterprise#15767
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
Since 'move_line_ids' isn't inside the view, `account_type` is never computed and then, the accrual account is never displayed/editable on the view.
closes odoo/odoo#64484
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
From Invoice list view select 2+ invoices (A, B), click Action>send and print
In each invoice 2 invoices will be sent:
- In A, you'll find A and A
- In B, you'll find A and B
This occur because the composition_mode of the composer is computed
after the attachment has been generated.
When the composer has an attachment, it is included into
the sent mail along the relevant one, generated on the fly for each record.
opw-2428544
closes odoo/odoo#64360
Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com>
|
|
When sending several invoices, customers also receive those that do not
concern them.
To reproduce the error:
(Need mailcatcher)
1. Go to Invoicing
2. Select two invoices
- Status must be "Posted"
- Customers must be different
3. Action > Send & Print
4. Uncheck "Print", then click on "Send"
5. Repeat 2-4
Err: Each customer receives both invoices. (In some cases, a third mail
is event sent). Each customer must receive his own invoices.
The mail composer wasn't correctly configured.
OPW-2422117
closes odoo/odoo#64314
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
|
|
Percentage is not used when change_account is selected. Then, the constraint must not be triggered in that case.
closes odoo/odoo#64083
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
When adding a credit note, the user can only select the "Partial
Refund" credit method.
To reproduce the error:
1. Go to Invoicing
2. Create a new one
- Add at least one invoice line
3. Save, Confirm
4. Click on "Add Credit Note"
=> You can not change the credit method.
The method field is editable only when the residual amount is different
from 0. Here is the issue: when clicking on "Add Credit Note", it
actually triggers some `onchange` methods. The latter uses a new record
to compute the values:
https://github.com/odoo/odoo/blob/45422d56bce413b8577f1784e10dd22ede93c751/odoo/models.py#L6147-L6148
Then, some `_compute` methods are also triggered. Among them, the amount
residual computation of the associated `account_move_line`. However,
`_compute_amount_residual` will skip the not-yet-created objects and set
the amount residual to 0. This is the reason why the residual amount of
the account move is zero and therefore, the user can't change the credit
method.
OPW-2418582
closes odoo/odoo#63674
Signed-off-by: Adrien Widart <adwid@users.noreply.github.com>
|
|
Steps to reproduce:
- Create a customer invoice I for a total of 1000€
- Confirm I
- Register a payment
Bug:
The default amout in the wizard was 0€ instead of 1000€
The default amount is computed by _get_wizard_values_from_batch with the sum of
amount_residual of all the lines. But in function _compute_amount_residual, it
checked line.id and this case, all the lines were in cache with NewId
opw:2413064
closes odoo/odoo#63023
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
|
|
During the accounting tour, users are invited to upload one of their
bill, send one by mail, or use a sample bill.
For the last one, the returned action which opens a list view with the
new move does not have the correct context, which makes clicking on
'create' launch the creation of a journal entry and not a vendor bill.
This will make sure the context is correctly set in this case.
task id #2368810
closes odoo/odoo#61247
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
|
Activate multicurrency:
* EUR with rate 1.0
* USD with rate 100.0
Have a company in currency USD
Create an invoice (in USD)
* invoice line of 12.15, no tax
Save, post and register payment
In the payment widget change currency to EUR.
The amount will be automatically converted in 0.12
Register payment
Invoice will be still marked to paid as the amount paid is 12.0.
This occur because the system does not check if the amount to be paid,
expressed in payment currency, is what has been paid.
opw-2376336
closes odoo/odoo#61938
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
The open_action_with_context was not using _for_xml_id, producing an
error when reading the action content.
In open_action, the action_name was taken from the context and needs
sanity checks. Ensure only actions from the account module can be
read and only if the user has access to the target model.
This is a limitation of the previous behaviour but, at the moment, all
known calls are made refering to an action from the account module.
Limit the scope of this method while the 14.0 is still early to avoid
having a door open to ready any action, and difficult to close later.
Remove old action fetching from the context in create_move that is no
longer used.
closes odoo/odoo#61365
Related: odoo/enterprise#14682
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Co-authored-by: Xavier Morel <xmo@odoo.com>
|
|
- The field 'invoice_ids' no longer exists on account.payment.
- When registering a payment using a payment token, the payment is not posted directly but the payment transaction is processed instead.
It means the payment is not posted until the CRON call. Since 14.0, the journal items can't be reconciled if not posted and then, we can't wait the CRON to update the payment state.
task: 2352628
|
|
The feature was actually not working as expected. It has been fixed,
and a test now ensures it does work as expected. This commit also fixes
some invalid parameters, hopefully nothing critical.
closes odoo/odoo#60402
Related: odoo/enterprise#14273
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
|
|
Before this commit, `journal_id` field was not required on model/view, Creating record without `journal_id` is not allowed since it is required on `account.move`.
Now field is required.
closes odoo/odoo#60133
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
|
- Activate debug mode
- Go to Settings > Technical > Templates
- Duplicate "Invoice: Send by email" and edit the copy (Name & Content)
- Go to Accounting > Customers > Invoices and create an Invoice
- Post it
- Send & Print
- In the wizard, select the duplicated template (the content will be updated)
- Uncheck "Email" option, the re-check it
The selected template is still the duplicated one, but the content is the one from the default template.
opw-2345200
closes odoo/odoo#59620
X-original-commit: cd6c54b15ce328b58888a4f33a64ae61c7744a90
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
|
|
If no bank journal with no account set can be found, we should return False
instead of an empty record.
closes odoo/odoo#59572
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
|
|
And other reported English mistakes in source string
Courtesy of Transifex translators
And remove leftover from gengo
closes odoo/odoo#59002
Related: odoo/enterprise#13776
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
|
|
closes odoo/odoo#58810
Related: odoo/enterprise#13676
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
If we select a line without an name for the automatic entry wizard, it
will be displayed as "false" in the preview widget. Even though, the
value will be set to NULL in the database, we don't want to see "false"
in the preview.
closes odoo/odoo#57641
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
When opening automatic entries on a group of entries which sum equals to
zero, a division by zero occurs which cause a traceback.
This commit will fix the issue.
task id #2334872
|
|
The upload bill wizard is missing a field related to its _inherits
reference, which cause a warning regularly in the console.
This commit will add this field to fix that.
Task id #2338970
closes odoo/odoo#57642
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
Task 2333152
The call to `ref` can not be done in py.js, it needs to be evaluated
before, when creating the action.
closes odoo/odoo#57759
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
|
Task 2327599
* The date is not copied on duplicate of account.move
* Do not throw traceback if we remove the invoice date of an
invoice/bill
* Add extra triggers in account_tour to ensure it is done in the right
view
* Update the position of some tour indicators
* Move the Product Categories in the Management menu
* The accounting onboarding is only visible on customer invoices list
view
* Switch the position of banc and bic
closes odoo/odoo#57107
Related: odoo/enterprise#12967
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
Recent changes to make post all entries works from the dashboard broke
it when used from the move list.
This commit will fix that and make sure it works in both situation
closes odoo/odoo#57249
closes odoo/odoo#57327
X-original-commit: 93138d447e49afa4bae9a438e73e95bf9543cdc4
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Nicolas Viseur <vin-odoo@users.noreply.github.com>
|
|
Two account.account M2O where authorizing off-balance accounts while
they should not be selectable. This change aim to fix that.
closes odoo/odoo#57317
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
|
https://github.com/odoo/odoo/commit/5309c252f6d0bc4994265a4c39259b70e7507fb1
This fix isn't working when using the 'modify' refund_method.
Also, you can't change the behavior of the whole invoices when there is only one move dealing with the auto_post feature.
https://github.com/odoo/odoo/commit/c9cd83e538a0be9d626d7587c465924146327cb2
This fix is only fixing the reversal wizard but must be done everytime a journal entry is duplicated.
closes odoo/odoo#56885
X-original-commit: 9b0aca617f20798eeb5ca2a538f6b9e241f752f4
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
Currently, if users try to send invoices / quotations / purchase orders to
themselves in order to look at final result, they can't do so because our
default chatter protection prevents sending mails to authors themselves.
This commit uses 'mail_notify_author' context key and allows users to send
mails from the header buttons available on SO / PO / invoices to themselves
if they are in recipients.
This commit targets only those buttons as this is the main case where we
want to allow people to send emails to themselves. In order to avoid
side effects no other use case is supported.
Task ID-2294130
closes odoo/odoo#55809
X-original-commit: 09918f320ba712b0bd90a6852825fad864655b04
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
|
The tooltip message on default_account in the journal is too obvious, and it has an issue
(There is no way to control the tooltip title when the field appears multiple times in the view,
it is always taking the label of the last time the field appears)
which is a limitation of the framework.
Thus, it is removed.
Fix the display of emails on the accounting dashboard, as they only should be
visible when properly set and on the purchase journal.
Improve the flow of the new bank account wizard to avoid forcing the user
to chose an existing journal when one of them exists without account.
This should still be a possibility, but the user should be able to decide
to create a new journal if wanted.
Task id #2322724
closes odoo/odoo#56177
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
|
|
When creating a bank account, the BIC should be enough to find or create
a new bank.
task id #2321110
closes odoo/odoo#55993
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
The current accounting tour is broken, this change will fix it.
Task id #2289610
closes odoo/odoo#55850
Related: odoo/enterprise#12389
Related: odoo/upgrade#1643
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
|
|
Added edi.documents representing an electronic document for a move and an edi.format.
A format can be asynchronous if it needs to call a web-service to generate the document, it will then be generated by the CRON (otherwise it's generated in post).
The formats can support payments if needed (can be generated immediately or by the CRON).
Added support for errors and related views.
Setting defaults format on a journal can be done automatically (based on a hook).
Added tests : xml comparaison with diff and helpers to test a EDI import/export
--task: 2247368
|
|
Replace wrong usages of any(list|recordset), by any(generator)
to speed up computations, avoiding list creations and/or looping twice on a recordset
for nothing.
any([generator]) => any(generator)
any(filtered) => any(generator)
closes odoo/odoo#55768
Related: odoo/enterprise#12360
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
|
|
There are inconsistencies in the m2o accounts create & edit behavior.
New off-balance account type was not correctly filtered
This change correct those two issues
Task ID: #2288757
closes odoo/odoo#54626
Related: odoo/enterprise#11920
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
|
|
closes odoo/odoo#50711
Task: 1930680
Related: odoo/enterprise#10394
Related: odoo/upgrade#1147
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
|
|
- Use the one defined in the account module allowing paying multiple journal entries
and group payments together.
- Remove the hr_expense_check module that contains only duplicated features regarding the
register payment wizard.
--task: 2273528
|
|
Miscellaneous changes aiming to improve the user experience in the accounting module,
mainly in the journal model and its form view.
Also aim to improve the bank account creation wizard.
Task ID: #2250349
closes odoo/odoo#54494
Related: odoo/upgrade#1546
Related: odoo/enterprise#11862
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
|
|
Order move for hash: In the method write, we sort the recordset following this rule: by date, by ref and by id.
This rule is used because we need to be consistent with the method _compute_name.
If we don't filter moves like that, we could possibly have a problem.
If you have several moves and you post them at the same moment with the action "Post entries", the hash sequence
could be in another order than the name sequence.
For example:
Move_20 (29/07/2020) - Hash_2
Move_21 (02/07/2020) - Hash_1
About security check, if the hash is activated, the user cannot reorder by date with resequence
because we don't want that the name sequence have not the same order than hash sequence.
Task ID: 2297407
closes odoo/odoo#55669
X-original-commit: b3ae96dc52178a3b13dda845244fe34268aed8a0
Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
|
|
The problem of using fields.Date.today() instead of
fields.Date.context_today() arose with the recent changes in the
account.move._post() method used in the POS tests, around 1 am.
This commit changes all occurences of today to context_today.
closes odoo/odoo#55511
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
Task 2227389
The wizards for creating Accrual Entries and Transfer Entries are quite
similar. We are merging them as they share code and business logic.
Entries in the future should not be posted for both wizards, but set to
be auto posted instead.
|
|
Add an easy way to not post the entries in the future when calling
post() on it, but rather set it to be auto-posted at accounting date.
This is useful when we are creating a lot of entries in batch and some
might be in the future, some in the past, and we don't want to separate
that in two batch every time. (asset, accrual, transfer,... )
|
|
- Create a vendor bill with amount X
- Register payment of X - 5 and mark as fully paid
=> The vendor bill is not fully paid.
closes odoo/odoo#55271
X-original-commit: 5c729d4cb7dacc46409259850ed7a5620fd6eb64
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
|
Clean various feedbacks reported by consultants WTA/CTH.
It concerns namely :
- CoA
- DEMO DATA
- SEQUENCE NUMBER ON JOURNALS
- PAYMENT STATUS
- BANK STATEMENTS
Task ID: #2300936
closes odoo/odoo#54874
Related: odoo/enterprise#11995
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
|
