summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-10-26[FIX] project: add follower as project userNicolas Martinelli
- Create a user A with access rights to Project set as 'User' - As user A, add a follower to a task An AccessError is raised. It happens because `allowed_user_ids` has the group `project.group_project_manager`. Since a Project User is allowed to set followers on a task, it is legitimate to set the appropriate portal user as allowed. opw-2369674 closes odoo/odoo#60702 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-26[FIX] web: update owl to last versionAaron Bohy
This commit updates owl from v1.0.10 to v1.0.13 See [1], [2] and [3] for the list of changes. [1] https://github.com/odoo/owl/commit/8da68e925b3baf00f671dd0435bc463d234031d7 [2] https://github.com/odoo/owl/commit/392185ab6740c8872ca6f19cc71e059b36d3a727 [3] https://github.com/odoo/owl/commit/d615ffd81b0b0c80780fcf022316769e10dc5dc1 closes odoo/odoo#60696 X-original-commit: cb12159a2bbfe71ba1cbe04c85c10ecce10e4c76 Signed-off-by: Géry Debongnie (ged) <ged@openerp.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2020-10-23[FIX] purchase: confirm receipt date if neededSwapnesh Shah
Before this commit, There would be Traceback (AttributeError: 'bool' object has no attribute 'date') on `Confirm Receipt Date` If order has no `Receipt Date`. Now, Button `Confirm Receipt Date` will be hidden if there is not `Receipt Date` to confirm. Closed #60222 closes odoo/odoo#60659 Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2020-10-23[FIX] web: preload font awesome font for frontend layoutsqsm-odoo
This commit adds an easy improvement fixing a page speed warning: the font awesome font (declared in a font-face in assets_common) can be preloaded. The only problematic point was that font-awesome defines the font by a series of URL using different font formats. Only one can be preloaded (otherwise you would load files for no reason). As all Odoo supported browsers use the woff2 format, we only preload that one. At the cost of a warning for other browsers which use a different format. task-2350647 closes odoo/odoo#60588 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-10-23[FIX] base, website_sale: vietnam zip not requiredJeremy Kersten
Zip cannot be required if not in format address. It will break ecommerce, because the customer cannot validate the adress because zip code is not displayed but required. Fix case in JS where field is not display to avoid traceback. This commit closes #58950 closes odoo/odoo#60694 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-10-22[FIX] website_sale_coupon_delivery,sale: validate taxcloud after carrierAndrea Grazioso (agr-odoo)
change Configure taxcloud, 2+ delivery carrier, card payment Go to the website shop Add product to cart Checkout with USA address On the Confirm Order page, the tax is computed via TaxCloud and shown on the right. Pay via payment acquirer site The Subtotal (without taxes) is sent to the Payment Acquirer instead of the Total This occur because when selecting delivery carrier coupon lines are recomputed. To be on the safe side with taxcloud, taxes are excluded before recomputing coupon lines, but never added in this specific flow. opw-2338103 opw-2362493 opw-2353048 closes odoo/odoo#60566 X-original-commit: f220e66d707654ee76dc343685dee8c2dda68dd5 Related: odoo/enterprise#14349 Signed-off-by: agr-odoo <agr-odoo@users.noreply.github.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-23[FIX] website_sale: fix fiscal position update in eCommerce cartAnh Thao Pham (pta)
- Install website_sale - Go to Website > Products > Products and create a Product with "Tax 15.00%" (i.e. Product X) - Publish the Product on Website - Go to Invoicing > Configuration > Fiscal Positions - Create a first Fiscal Position: * Fiscal Position (Name): Fiscal Position A * Tax Mapping: Tax 15.00% => Tax 15.00% - Create a second Fiscal Position: * Fiscal Position (Name): Fiscal Position B * Tax Mapping: Tax 15.00% => Tax 0.00% - Create a Portal User (i.e. User X) - Go to Contacts and edit User X to set his Fiscal Position to Fiscal Position A - Connect with User X - Go to online Shop and add Product X in the cart - Open "My Cart" => Taxes are displayed correctly - Process checkout and enter an address, but do not pay - Disconnect - Change Fiscal Position of User X to Fiscal Position B - Reconnect with User X and open "My cart" - Open "My Cart" => Taxes are displayed as if the Fiscal Position has not been changed The prices and taxes in the cart are still based on the previous fiscale position. To fix that, fiscale position of SO will be compared to fiscale position of user, even if user has not changed. Howerver, as it is a specific use case, it will only be done if "sale_order_id" is not in session anymore. Also the cart from user's last visit will not be reloaded, but a new one will be created, as it is done when used pricelist is not available anymore. opw-2300330 closes odoo/odoo#60585 X-original-commit: bd77d0ca35a0ab724d235aca989b9c2357a25caf Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-23[FIX] l10n_latam_invoice_document: Add credit note to invoiceAchraf (abz)
Issue - Install "l10n_latam_invoice_document" - Try to add a credit note to any invoice Cause "l10n_latam_manual_document_number" is unitialized when "l10n_latam_use_documents" is equal to False Solution Init "l10n_latam_manual_document_number" to False opw-2366298 closes odoo/odoo#60653 X-original-commit: 6b5f40f4310f02204d98c58d45f92a27c7fad7c1 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-23[FIX] website_mail_channel: fix load more repliesfw-bot
On a thread with at least 21 replies, click on "show N more replies". The first time, it does the last 10 replies. Click again: it appends the same batch of 10 replies to the thread. The button loads the replies starting from the last reply id, but this id is not updated after load. This is because the code searches for a `p.well` in the DOM assumed to be the `o_mg_read_more` parent (see c40f184). However, commit 59237ea removed the `.well` class of the parent. The new button is not found, the old button is not removed, and so it goes. Forward-Port of 4536764ad52b5b closes odoo/odoo#60643 X-original-commit: 69dd830a15da2d7e43e6040e26d960d2e941002e Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2020-10-23[FIX] account, l10n_ar, l10n_cl: web_studio broken due to dynamic view callNasreddin (bon)
Issue - Install "Accounting" & "Studio" modules - Go to "Accounting" and switch studio editor - Go to "Reports" tab and select "Invoices" report - Click on any block to edit. Not possible to edit document. Cause Studio cannot parse dynamic `t-call` and therefore not able to render the corrects hooks to edit the report. The issue has been introduced by this commit: https://github.com/odoo/odoo/commit/5c5710ae8ea045569fd94504f9d8dd5209f7b662 Solution In the corresponding localization report template, add an 'Inheritance Specs' (position="after") that will add a condition where it will retrieve the rigth report name in case localization enabled. opw-2362257 closes odoo/odoo#60609 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-23[FIX] product: archiving last variant must archive product templateNicolas Galler
Behavior prior to this fix: When archiving the last variant on a template, the product template stays active (contrary to the comment indicating that `toggle_active` will archive the related product.template if there is only one active `product.product`). Behavior after the fix: When archiving the last variant on a template, the product template is archived. When un-archiving that variant, the product template is unarchived as well, without un-archiving the other variants. Note: this is a remake of a fix implemented in 77e5472c041e, as that fix did not correctly count the inactive variants. opw-2349862 closes odoo/odoo#60635 X-original-commit: 01160ee5e7f726f3035c566a13e26825236dedfd Signed-off-by: Nicolas Galler <nicocrm@users.noreply.github.com>
2020-10-23[FIX] web_editor: do not show overlay for invisible elementsqsm-odoo
When a snippet is out of the viewport or hidden, the overlay should not be visible. Two distinct cases we had: - When the page is scrolled, the header is sometimes hidden thanks to tranform: translate(0, -100%); for some kind of effect -> the header is thus still visible but out of the viewport, any selected snippet inside that header would still have this overlay enabled so we would see the move and delete button on the top of the screen. - When the page is scrolled, with the vertical header, some part of the header are hidden for the affixed version. If any snippet in those hidden elements was selected, the overlay is still visible floating. task-2312878 closes odoo/odoo#58383 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com> Co-authored-by: Benjamin Vray <bvr@odoo.com> Co-authored-by: Thanh Dodeur <tso@odoo.com>
2020-10-23[FIX] point_of_sale: Fix issue for IoT upgradelejeune quentin
When we want to upgrade the IoT box to the lastest version we need install kpartx to the third partition. However the source are not up to date and we can't fetch the package. So we must update this partition before fetch the package X-original-commit: 83ec693cc2c4b92b29cdee6f63b283655c2633df m closes odoo/odoo#60638 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com> Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2020-10-23[FIX] account: Fix unbalanced journal entry when switching payment termsLaurent Smet
When switching immediate payment term to 30% advance then back to immediate payment term, the receivable line is back to its previous value. This is due to the '_get_fields_onchange_balance' that is not updating correctly the business fields since price_subtotal == amount_currency. So, when `writing`, debit/credit are removed from the dictionary because the values are the same as before. However, `price_unit` hasn't be updated with the new value and remains as its previous value. It leads to a recomputation of accounting fields regarding the business fields and then, trigger the unbalanced journal entry. closes odoo/odoo#60614 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2020-10-23[FIX] mail: force the model when creating basic threadDidier (did)
closes odoo/odoo#60285 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-10-23[FIX] mail: incorrect value for partner id.Didier (did)
2020-10-23[FIX] mail: handle the case when the user id isn't and array.Didier (did)
2020-10-23[FIX] mail: filter commands used in composer based on channel typeJulien Giannone
closes odoo/odoo#60052 Task-id: 2343850 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-10-23[FIX] sale_management: Pricelist singleton error while choosing optional productVanneri
closes odoo/odoo#60622 X-original-commit: b6ced2e13e328539b086067a836d1e0fba3990b7 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2020-10-23[FIX] point_of_sale: Update IoT Box version to 20_10lejeune quentin
We release a new version of IoT Box. So we need to update the version. closes odoo/odoo#60590 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2020-10-23[IMP] point_of_sale: Change raspbian to raspioslejeune quentin
We change the OS from Raspbian to Raspberry Pi OS So we change all occurence of raspbian to raspios m
2020-10-23[IMP] point_of_sale: Build IoT from new Raspberry Pi OSlejeune quentin
We update the image to build the IoT from Raspbian to Raspberry Pi OS
2020-10-23[FIX] mail: add test to the suggested recipient featureDidier (did)
task-2343795 closes odoo/odoo#59989 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-10-23[FIX] calendar: accepting meeting invite from emailNicolas Galler
Behavior prior to the fix: When accepting a meeting invite from the invitation email, if not logged in, an Internal Server Error is received. Additionally, if already logged in, an Internal Server Error is also received (albeit for a different reason) Behavior after the fix: Accepting (or declining) the meeting invite works and shows the accepted/declined meeting. opw-2366173 closes odoo/odoo#60556 Related: odoo/enterprise#14359 Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-23[FIX] mail: do not return members of channels in channel_infoSébastien Theys
This PR has 3 parts: The members fix itself, which is necessary for performance reasons especially at init messaging, as per described in the task. Adding the partner name in the typing payload, because due to not knowing all members anymore, it is necessary to properly display who is typing. Restrict restoring scroll position only if the corresponding scroll height is available, to make the scroll feature and particularly the corresponding tests more robust. task-2360020 closes odoo/odoo#60091 Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-10-23[FIX] doc: fix broken anchorAntoine Vandevenne (anv)
closes odoo/odoo#60601 Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>
2020-10-23[FIX] website_slides: hide "responsible" label if no responsible assignedAurélien Warnon
This commit makes a small adjustment to the course view to hide the responsible label in the course description if none is set. As this field is not required on the slide.channel model, it's not necessary to show a useless label when it's not set. Task 2368573 closes odoo/odoo#60579 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-10-16[FIX] account_edi: allow attachment and error in same documentJorge Pinna Puissant
Allow having in an attachment as well as an error in the same document. This will allow to see the document that generates the error, and easy the process of debugging. closes odoo/odoo#60163 Related: odoo/enterprise#14167 Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2020-10-23[FIX] base,calendar: fix calendar reminderJérémy Hennecart
The purpose of this commit is to have reliable calendar event reminder. Before, the reminders was not send directly and was instead put in mailing queue, which was leading to some delay. This is due do mail_notify_force_send context key being force to False when being in cron mode. However here we do not want to have calendar cron scheduling emails, then mailing cron sending them as it implies two delays. In order to try to send reminder mails as soon as possible compared to their schedule let us send mails directly during the calendar cron. Task ID-2331999 closes odoo/odoo#57994 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-10-23[FIX] base: remove duplicate call to cron.runThibault Delavallée
Oversight of conflict solving in forward port 9d1909f228aef664669152c16091a188377ee8bd
2020-10-21[FIX] product_email_template: use superuser account to send email in su modeNicolas Galler
Behavior prior to the fix: The email template associated with a product on an invoice placed via the web portal is sent with no email_from, resulting in a failure. The reason is that before 13.0 .sudo() before sending a mail would send it as superuser user (which was the intention in this case), but since 13.0 for the same intention we need .with_user(SUPERUSER_ID). Behavior after the fix: When sending the product email, if we are in SU mode, we'll switch to the super user account, emulating the pre-13.0 behavior. Similar fix to b12bcfbb1b44cc72cdf73506c540c387f00a37e9 opw-2346415 closes odoo/odoo#60409 X-original-commit: 7749fec536bd1533f0da0a2bc0df084e4e80ed4d Signed-off-by: Nicolas Galler <nicocrm@users.noreply.github.com> Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-10-21[IMP] packaging, l10n_dz, l10n_ro, survey: integrate Debian fixChristophe Monniez
With this commit, the executions bits are fixed on some xml, csv and ttf files. The fix was initialy made at the Debian packaging level. As xlwt is now in Debian buster, the overide is removed. The linked fonts in Debian package are now removed in one line to simplify the code. closes odoo/odoo#60114 Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2020-10-22[FIX] l10n_latam_invoice_document: skip `document_type` computation on installDenis Ledoux
Skip the computation of the field `l10n_latam_document_type_id` at the module installation. The case has been detected during an upgrade from Odoo 12.0 to Odoo 13.0, but the case could really well happen outside the context of an upgrade, for instance when you create a new subsidiary in Chile or Argentina while you already have a lot of accounting entries in your other subsidiaries (e.g. Odoo S.A. opens a new office in Chile and has to install `l10n_cl`) Without this, at the module installation, it would call `_compute_l10n_latam_document_type` on all existing records which can take quite a while if you already have a lot of moves. It can even fail with a MemoryError. In addition, it sets `_compute_l10n_latam_document_type = False` on all records because this field depends on the many2many `l10n_latam_available_document_type_ids`, which relies on having records for the model `l10n_latam.document.type` which only happens once the according localization module is loaded. (e.g. `l10n_cl/data/l10n_latam.document.type.csv`) The localization module is loaded afterwards, because the localization module depends on this module, (e.g. `l10n_cl` depends on `l10n_latam_invoice_document`, and therefore `l10n_cl` is loaded after) and therefore there are no records for the model `l10n_latam.document.type` at the time this fields gets computed on installation. Hence, all records' `_compute_l10n_latam_document_type` are set to `False`. In addition, multiple localization module depends on this module (e.g. `l10n_cl`, `l10n_ar`) So, imagine `l10n_cl` gets installed first, and then `l10n_ar` is installed next, if `l10n_latam_document_type_id` needed to be computed on install, the install of `l10n_cl` would call the compute method, because `l10n_latam_invoice_document` would be installed at the same time, but then `l10n_ar` would miss it, because `l10n_latam_invoice_document` would already be installed. Besides, this field is computed only for drafts invoices, as stated in the compute method: `for rec in self.filtered(lambda x: x.state == 'draft'):` So, if we want this field to be computed on install, it must be done only on draft invoices, and only once the localization modules are loaded. It should be done in a dedicated post init hook, filtering correctly the invoices for which it must be computed. Though I don't think this is needed. In practical, it's very rare to already have invoices (draft, in addition) for a Chilian or Argentian company (`res.company`) before installing `l10n_cl` or `l10n_ar`. ``` Traceback (most recent call last): File "/src/odoo/13.0/odoo/service/server.py", line 1190, in preload_registries registry = Registry.new(dbname, update_module=update_module) File "/src/odoo/13.0/odoo/modules/registry.py", line 86, in new odoo.modules.load_modules(registry._db, force_demo, status, update_module) File "/src/odoo/13.0/odoo/modules/loading.py", line 423, in load_modules loaded_modules, update_module, models_to_check) File "/src/odoo/13.0/odoo/modules/loading.py", line 315, in load_marked_modules perform_checks=perform_checks, models_to_check=models_to_check File "/src/odoo/13.0/odoo/modules/loading.py", line 202, in load_module_graph registry.init_models(cr, model_names, {'module': package.name}, new_install) File "/src/odoo/13.0/odoo/modules/registry.py", line 364, in init_models env['base'].flush() File "/src/odoo/13.0/odoo/models.py", line 5458, in flush self.recompute() File "/src/odoo/13.0/odoo/models.py", line 5875, in recompute process(field) File "/src/odoo/13.0/odoo/models.py", line 5859, in process recs.mapped(field.name) File "/src/odoo/13.0/odoo/models.py", line 5266, in mapped recs = recs._mapped_func(operator.itemgetter(name)) File "/src/odoo/13.0/odoo/models.py", line 5225, in _mapped_func vals = [func(rec) for rec in self] File "/src/odoo/13.0/odoo/models.py", line 5225, in <listcomp> vals = [func(rec) for rec in self] File "/src/odoo/13.0/odoo/models.py", line 5690, in __getitem__ return self._fields[key].__get__(self, type(self)) File "/src/odoo/13.0/odoo/fields.py", line 2329, in __get__ return super().__get__(records, owner) File "/src/odoo/13.0/odoo/fields.py", line 995, in __get__ self.compute_value(recs) File "/src/odoo/13.0/odoo/fields.py", line 1109, in compute_value records._compute_field_value(self) File "/src/odoo/13.0/odoo/models.py", line 3968, in _compute_field_value field.compute(self) File "/src/odoo/13.0/odoo/fields.py", line 579, in _compute_related record[self.name] = self._process_related(value[self.related_field.name]) File "/src/odoo/13.0/odoo/models.py", line 5699, in __setitem__ return self._fields[key].__set__(self, value) File "/src/odoo/13.0/odoo/fields.py", line 1070, in __set__ self.write(protected_records, value) File "/src/odoo/13.0/odoo/fields.py", line 2564, in write cache.update(records, self, [cache_value] * len(records)) File "/src/odoo/13.0/odoo/api.py", line 768, in update field_cache.setdefault(record_id, {})[key] = value MemoryError ``` Upgrade request 49495 closes odoo/odoo#60572 X-original-commit: f2a08faa1e65cb381315cbd5d1a359901e8b7deb Signed-off-by: Denis Ledoux (dle) <dle@odoo.com>
2020-10-22[FIX] bus, mail: fix im_status for archived partnersThanh Dodeur
Before this commit, archived and deleted partners had not their im_status being updated automatically. There were some issues with this, notably: - odoobot 'bot' status was not displayed in chatter - im_status of partners becoming archived were not updated. This commit fixes both issues. task-2329591 closes odoo/odoo#60398 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-10-21[FIX] web_editor: prevent switching to text tools immediatelyqsm-odoo
On editor start, "the cursor enters editable text" at a "random" time thus switching immediately to text tools or not depending on the fact text tools switching was initialized or not. We now only allow to do so after some fixed delay after the editor is ready, to prevent any automatic switching on editor start (which may break tours). Part of https://github.com/odoo/odoo/pull/60383 task-2352339 closes odoo/odoo#60383 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-10-21[FIX] web_editor: stop showing text tools on empty oe_structureqsm-odoo
Do not switch to text tools if the cursor is in an empty oe_structure (to encourage using snippets there and actually avoid breaking tours which suppose the snippet list is visible). Part of https://github.com/odoo/odoo/pull/60383 Related to task-2352339
2020-10-22[FIX] pos_restaurant: Order change receipts alignmentAntoine Prieels
The alignment of quantity and product name was off when the product name was split into multiple lines. opw-2360424 closes odoo/odoo#60545 X-original-commit: 58404f299f7fa9128758b4b7830a6393c64ad085 Signed-off-by: pimodoo <pimodoo@users.noreply.github.com> Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>
2020-10-22[FIX] base: update lastcall with manual cron execution as with automated ↵Jeremy Hennecart
execution Cron holds a lastcall field and context key allowing to compute an accessible range of processable records based on last execution. This lastcall value is updated when cron runs automatically. Manual call currently does not update. It makes sense to do the same update in manual call than with automated calls. Moreover lastcall context key is also updated. It is used notably in calendar. Otherwise only mails linked to "today" are taken into account, leading to reminder issues. Task ID-2331999 closes odoo/odoo#60537 X-original-commit: 6c34d1996f24f1ec647e4dd12b9d7e7eea3e62d3 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-10-22[FIX] *: avoid direct references to countriesVictor Feyens
Ensure the code works fine even if countries are deleted. Also consider "re"-created countries after deletion, by only considering the country code, not the data reference. This should reduce support requests related to deleted countries, and ease the resolution of such problems by the users themselves. TASK ID - 2368842 closes odoo/odoo#57837 Related: odoo/enterprise#13275 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2020-10-22[FIX] im_livechat: visitor sees typing notification of operatorAlexandre Kühn
task-2359991 closes odoo/odoo#60535 Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-10-22[FIX] website_sale_wishlist: Product with sale_ok = False in wishlistGoffin Simon
Steps to reproduce the bug: - Let's consider a sellable product P published on the shop - Let's consider a portal user PU adding P in his wishlist W - Set P with sale_ok = False (meaning unsellable) - With PU try to see W Bug: A 430 error was raised because the product P was not sellable opw:2362184 closes odoo/odoo#60523 Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2020-10-22[FIX] web: keep new widget el in ComponentAdapterMichael Mattiello (mcm)
Before this commit, when sub widget replaced its el, the ComponentAdapter parent kept the previous el. This caused some issues as in the ActivityRecordAdapter which lost its event listeners when re-rendered. This commit forces the ComponentAdapter to keep the new sub widget el after being patched. task id: 2360021 closes odoo/odoo#60517 X-original-commit: 393b5fd4cfba254ad054a526996e82922f9057e2 Signed-off-by: Aaron Bohy (aab) <aab@odoo.com> Signed-off-by: Michaël Mattiello <mcm-odoo@users.noreply.github.com>
2020-10-22[FIX] website_slides: correctly close subscription modal when savingAurélien Warnon
This commit fixes a small issue with the modal displayed when the user wants to manage his subscription to a course. When pressing the "Save" button, if no modification was made, the modal would not close and nothing would happen (which seems strange on a user POV). Now the modal correctly destroys itself and closes. Task 2363028 closes odoo/odoo#60504 X-original-commit: 32d0b1086b5db6c58c1e2891d8d77fafb9482de9 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-10-22[FIX] web_editor: restore overlay top options on top of the pageqsm-odoo
When the overlay covers a snippet, if that snippet is at the top of the page, the options at the top of the overlay are hidden. A system was made to make them change position in that case but this was broken by [1], leaving the toggling of a class for that case but without its related scss. This commit restores that scss and also improves the detection of that problematic case. [1]: https://github.com/odoo/odoo/commit/4f27e52cabb77b8b1a9637a11185ddf882adc9af closes odoo/odoo#60464 X-original-commit: 97f11571f9e3deacc9b9e1dc0d2cc8fc6b93f15c Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-10-22[FIX] website, portal: fix language selector inlineBenjamin Vray
This commit align vertically the copyright text and the inline language switcher items. This commit also add a padding on list-inline-item in the language selector. Because before this commit, there was no space between lines if the list was to be displayed on multiple lines. Part of #59581 task-2312878 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2020-10-22[FIX] website: hide the add language separator if it is the last itemBenjamin Vray
Before this commit, the add language separator was visible at the end of the inline language switcher even if the add language link was not displayed. Part of #59581 task-2312878
2020-10-13[I18N] l10n_ar: add missing translationsBruno Zanotti (ADHOC)
closes odoo/odoo#59030 Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2020-10-22[FIX] l10n_cn: incorrect account typewan
The fix c710c3a35a3f466ebadc5748c70784bc063a7eb2 has been forgotten while applying https://github.com/odoo/odoo/pull/43768 closes odoo/odoo#60492 X-original-commit: c5d355444a3dde2635025e5452360e853afca099 Signed-off-by: Laurent Smet <smetl@users.noreply.github.com> Signed-off-by: wan <william-andre@users.noreply.github.com>
2020-10-21[FIX] web_editor: disable embedded video for html fields in backendIEL
TLDR: the videos doesn't work anyway, but nobody noticed it for years; at the same time there is no easy way to fix it STEPS: * create a record with html field, e.g. project.task * add an embedded video (File/Image icon) * save BEFORE: video doesn't work AFTER: there is no option to add embedded video anymore WHY: * iframe tags are removed before storing html in database, so after saving a record, embedded video doesn't work anymore * possible fixes look too tricky for stable branches: * new field attribute sanitize_iframe=False -- requires changes in core python framework which may have side effect * adding iframe on client side -- the problem is that the backend doesn't have mechanism to use animation in html fields like it's done in website: https://github.com/odoo/odoo/blob/ced500e9bcbb5c84033463689d135ad4c7dc4f39/addons/website/static/src/js/content/snippets.animation.js#L623-L632 * adding iframe on server side -- parsing html fields in _read... Doesn't look good either * double selector is required to make it work both in frontend and backend: $editable.closest('.o_editable, .note-editor') * we don't need hardcoded exception for mailing.mailing, mail.compose.message because those fields marked as sanitized (default value) https://github.com/odoo/odoo/blob/c92f058571b0656451f24e24154dd1bdb3bdb48a/odoo/fields.py#L1589-L1590 https://github.com/odoo/odoo/blob/c92f058571b0656451f24e24154dd1bdb3bdb48a/addons/mail/wizard/mail_compose_message.py#L115 https://github.com/odoo/odoo/blob/61734cdaf1cf6857125b1ece63928ab080359c6c/addons/mass_mailing/models/mailing.py#L77 * I don't apply this for Odoo 12, because js is refactored in Odoo 13 (e.g. field_html.js has another name in Odoo 12) --- opw-2353103 closes odoo/odoo#60474 X-original-commit: 2dcbac08effcedafbcf50610355752030902b16d Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com> Signed-off-by: Ivan Yelizariev // IEL <yelizariev@users.noreply.github.com>
2020-10-21[FIX] account: Fix reversal of journal entry with tax_ids on tax lineLaurent Smet
A tax line could have something in the `tax_ids` field. Then, these condition needs to be inversed in order to not handle them as base lines. closes odoo/odoo#60469 X-original-commit: eada9f91f3361f8335c23b3a27161803cfda6608 Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com> Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>