summaryrefslogtreecommitdiff
path: root/addons/web/static/src/js/views/basic/basic_model.js
diff options
context:
space:
mode:
Diffstat (limited to 'addons/web/static/src/js/views/basic/basic_model.js')
-rw-r--r--addons/web/static/src/js/views/basic/basic_model.js36
1 files changed, 16 insertions, 20 deletions
diff --git a/addons/web/static/src/js/views/basic/basic_model.js b/addons/web/static/src/js/views/basic/basic_model.js
index 1ed8c36bb98..532af65744c 100644
--- a/addons/web/static/src/js/views/basic/basic_model.js
+++ b/addons/web/static/src/js/views/basic/basic_model.js
@@ -2259,31 +2259,27 @@ var BasicModel = AbstractModel.extend({
* context.
* @param {Object} modifiers
* @returns {Object}
+ * @throws {Error} if one of the modifier domains is invalid
*/
_evalModifiers: function (element, modifiers) {
- var result = {};
- var self = this;
- var evalContext;
- function evalModifier(mod) {
+ let evalContext = null;
+ const evaluated = {};
+ for (const k of ['invisible', 'column_invisible', 'readonly', 'required']) {
+ const mod = modifiers[k];
if (mod === undefined || mod === false || mod === true) {
- return !!mod;
+ if (k in modifiers) {
+ evaluated[k] = !!mod;
+ }
+ continue;
+ }
+ try {
+ evalContext = evalContext || this._getEvalContext(element);
+ evaluated[k] = new Domain(mod, evalContext).compute(evalContext);
+ } catch (e) {
+ throw new Error(_.str.sprintf('for modifier "%s": %s', k, e.message));
}
- evalContext = evalContext || self._getEvalContext(element);
- return new Domain(mod, evalContext).compute(evalContext);
- }
- if ('invisible' in modifiers) {
- result.invisible = evalModifier(modifiers.invisible);
- }
- if ('column_invisible' in modifiers) {
- result.column_invisible = evalModifier(modifiers.column_invisible);
- }
- if ('readonly' in modifiers) {
- result.readonly = evalModifier(modifiers.readonly);
- }
- if ('required' in modifiers) {
- result.required = evalModifier(modifiers.required);
}
- return result;
+ return evaluated;
},
/**
* Fetch all name_gets for the many2ones in a group