[FIX] sale_coupon: don't recompute coupon when confirming a quote

Before this commit:
When you 'CONFIRM SALE', it would recompute the coupons just before
confirming the quote.

This would cause 2 issues:
1. You had no way to know what the generated SO will looks like (maybe unless
   you know perfectly all the coupon promotions?).
   You would end up with a 'surprise' SO that could be totally different from
   the quote you just confirmed.
2. You had no way to cancel or prevent a coupon to be applied even if you
   wanted to.
   Eg: you don't wan't to offer this free forth iPad or this 10% discount to
   that customer or this week.

Obviously, you could set all your coupons to be used with a code so the
recompute won't add any coupon to the quote but that would not make sense since
you would be limited to one coupon per SO.

At the end, there is a `UPDATE PROMOTIONS` on the quote which it's only purpose
is to recompute the coupons. The good practice would be to use that button
instead of using the confirm quote step to recompute the coupons.

Comes from #1967 (see review comment)

0 files changed, 0 insertions, 0 deletions