diff options
| author | xmo-odoo <xmo@odoo.com> | 2017-05-10 09:39:55 +0200 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2017-05-10 09:39:55 +0200 |
| commit | fffaf735f58f1ac57781c095eb552de6d1fcdc47 (patch) | |
| tree | 88ab0ab65430d871862a836524e0ecc890d1674d /setup/setup_dev.py | |
| parent | 10eee18a047d35305dc46282e610e88936d81ffc (diff) | |
[FIX] P3: list -> iterable builtins (#16811)
In Python 3:
* various builtins and dict methods were changed to return
view/iterable objects rather than lists
* and the separate Python 2 view/iterable builtins and methods were
removed altogether
This is problematic when using these items as list (which the happens
repeatedly in Odoo), but more viciously when iterating *multiple times*
over them (which also happens, which I've messed up multiple times while
writing this, and which is a pain to debug even when you've just created
the issue).
Convert all code using these to semantics-matching cross-version
helper functions to get the LCD behaviour between P2 and P3, and
forbid the builtins via lint.
issue #8530
Diffstat (limited to 'setup/setup_dev.py')
| -rwxr-xr-x | setup/setup_dev.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/setup/setup_dev.py b/setup/setup_dev.py index 0038ad3fd8a..1ad6fe2f5ff 100755 --- a/setup/setup_dev.py +++ b/setup/setup_dev.py @@ -153,7 +153,7 @@ def main(): elif len(sys.argv) == 2 and sys.argv[1] in cmds: cmds[sys.argv[1]]() else: - sys.exit('Unknow command. Command available: %r' % (cmds.keys(),)) + sys.exit('Unknow command. Command available: %r' % (list(cmds,)) if __name__ == "__main__": main() |
