diff options
| author | Xavier Morel <xmo@odoo.com> | 2019-12-18 12:40:52 +0000 |
|---|---|---|
| committer | Xavier Morel <xmo@odoo.com> | 2020-01-21 06:56:15 +0000 |
| commit | b66a7feb0f468e263b507929237ae6c93f3ee4cd (patch) | |
| tree | d71773a99e7fe1f774fa2023873b51f8adf46d0e /odoo | |
| parent | 7b13ce17c2019d5e32241c7ccbc40df85d927b9e (diff) | |
[IMP] core: strip log_handler items before splitting them
Allows better formatted and commented log_handler items in
configuration files: configparser allows multiline values and
interspersed comments (stripping out comment lines), but while it
removes indent it leaves the linebreaks, so e.g.
foo =
bar,
# qux
quux
when parsed and split on "," results in `['\nbar', '\nquux']` which is
obviously an issue for logging (as it assumes the leading `\n` is part
of the logger name proper).
Since log_handler items can be fairly long and are not necessarily
self-descriptive as to *why* they were selected for re-configuration,
allowing one per line & comments is helpful.
Diffstat (limited to 'odoo')
| -rw-r--r-- | odoo/netsvc.py | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/odoo/netsvc.py b/odoo/netsvc.py index 2cf24a36a61..ee4c60348b4 100644 --- a/odoo/netsvc.py +++ b/odoo/netsvc.py @@ -200,7 +200,7 @@ def init_logger(): logging_configurations = DEFAULT_LOG_CONFIGURATION + pseudo_config + logconfig for logconfig_item in logging_configurations: - loggername, level = logconfig_item.split(':') + loggername, level = logconfig_item.strip().split(':') level = getattr(logging, level, logging.INFO) logger = logging.getLogger(loggername) logger.setLevel(level) |
